From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Cc: Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@cavium.com>,
Hannes Reinecke <hare@suse.de>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
Date: Wed, 28 Jun 2017 01:44:31 +0000 [thread overview]
Message-ID: <E582614F-2B53-44BF-8E2E-000E27D510AB@cavium.com> (raw)
In-Reply-To: <yq1bmp8zylp.fsf@oracle.com>
Hi Martin,
On 6/27/17, 6:32 PM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:
> In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
> qpair->qp_lock but do access members of the qpair before having the lock.
> Re-order the locking sequence to have all read and write access to qpair
> members under the qpair->qp_lock.
Cavium folks, please review!
I am testing it internally, will update by tomorrow.
--
Martin K. Petersen Oracle Linux Engineering
Thanks,
Himanshu
next prev parent reply other threads:[~2017-06-28 1:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 7:10 [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock Johannes Thumshirn
2017-06-28 1:32 ` Martin K. Petersen
2017-06-28 1:44 ` Madhani, Himanshu [this message]
2017-06-28 16:33 ` Madhani, Himanshu
2017-07-01 20:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E582614F-2B53-44BF-8E2E-000E27D510AB@cavium.com \
--to=himanshu.madhani@cavium.com \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).