From: Billy Tsai <billy_tsai@aspeedtech.com> To: Jonathan Cameron <Jonathan.Cameron@Huawei.com> Cc: "jic23@kernel.org" <jic23@kernel.org>, "lars@metafoo.de" <lars@metafoo.de>, "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: Re: [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml Date: Mon, 26 Jul 2021 06:53:07 +0000 [thread overview] Message-ID: <E650AFD8-FFD1-4D87-87B0-42D20D9C3BB4@aspeedtech.com> (raw) In-Reply-To: <20210723154456.00006744@Huawei.com> Hi Jonathan, On 2021/7/23, 10:45 PM, "Jonathan Cameron" <Jonathan.Cameron@Huawei.com> wrote: On Fri, 23 Jul 2021 16:16:14 +0800 Billy Tsai <billy_tsai@aspeedtech.com> wrote: > > The aspeed,ast2400-adc.yaml not only descriptor the bindings of ast2400. > > Rename it to aspeed,adc.yaml for all of the aspeed adc bindings. > > > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > We try to avoid 'wild' card type namings most of the time and instead > name after a particular part number. I say try because clearly > we let a few in over the years :( > It is very hard to know if this binding will apply to 'all' future > aspeed ADCs. > As such I'm not sure this particular rename makes sense. If I want to extend the yaml file to compatible more versions of the aspeed adc. Would you suggest to add new files call aspeed,ast2600-adc.yaml or just append it to the aspeed,ast2400-adc.yaml? Thanks Best Regards, Billy Tsai
next prev parent reply other threads:[~2021-07-26 6:53 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-23 8:16 [v2 0/8] Add support for ast2600 ADC Billy Tsai 2021-07-23 8:16 ` [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml Billy Tsai 2021-07-23 14:44 ` Jonathan Cameron 2021-07-26 6:53 ` Billy Tsai [this message] 2021-07-29 20:31 ` Rob Herring 2021-07-31 17:27 ` Jonathan Cameron 2021-07-23 8:16 ` [v2 2/8] dt-bindings: iio: adc: Binding ast2600 adc Billy Tsai 2021-07-23 14:51 ` Jonathan Cameron 2021-07-26 7:21 ` Billy Tsai 2021-07-23 8:16 ` [v2 3/8] iio: adc: aspeed: completes the bitfield declare Billy Tsai 2021-07-23 14:55 ` Jonathan Cameron 2021-07-23 8:16 ` [v2 4/8] iio: adc: aspeed: Allow driver to support ast2600 Billy Tsai 2021-07-23 15:29 ` Jonathan Cameron 2021-07-23 8:16 ` [v2 5/8] iio: adc: aspeed: Add func to set sampling rate Billy Tsai 2021-07-23 15:37 ` Jonathan Cameron 2021-07-23 8:16 ` [v2 6/8] iio: adc: aspeed: Add compensation phase Billy Tsai 2021-07-23 15:44 ` Jonathan Cameron 2021-07-23 8:16 ` [v2 7/8] iio: adc: aspeed: Fix the calculate error of clock Billy Tsai 2021-07-23 8:16 ` [v2 8/8] iio: adc: aspeed: Support battery sensing Billy Tsai 2021-07-23 15:56 ` Jonathan Cameron 2021-07-26 6:54 ` Billy Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E650AFD8-FFD1-4D87-87B0-42D20D9C3BB4@aspeedtech.com \ --to=billy_tsai@aspeedtech.com \ --cc=BMC-SW@aspeedtech.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=andrew@aj.id.au \ --cc=devicetree@vger.kernel.org \ --cc=jic23@kernel.org \ --cc=joel@jms.id.au \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ --subject='Re: [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).