From: Nick Terrell <terrelln@fb.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: David Sterba <dsterba@suse.cz>,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@kernel.org>,
Nick Terrell <nickrterrell@gmail.com>,
"squashfs-devel@lists.sourceforge.net"
<squashfs-devel@lists.sourceforge.net>,
Christoph Hellwig <hch@infradead.org>, Yann Collet <cyan@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
Petr Malat <oss@malat.biz>, "Chris Mason" <clm@fb.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>, "Niket Agarwal" <niketa@fb.com>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
"Johannes Weiner" <jweiner@fb.com>
Subject: Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6
Date: Fri, 18 Dec 2020 18:57:29 +0000 [thread overview]
Message-ID: <EEFB7148-86B7-4761-BAB2-D35F29614A3E@fb.com> (raw)
In-Reply-To: <20201217012337.GA24705@qmqm.qmqm.pl>
> On Dec 16, 2020, at 5:23 PM, Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
>
> On Wed, Dec 16, 2020 at 10:07:38PM +0000, Nick Terrell wrote:
> [...]
>> It is very large. If it helps, in the commit message I’ve provided this link [0],
>> which provides the diff between upstream zstd as-is and the imported zstd,
>> which has been modified by the automated tooling to work in the kernel.
>> [0] https://github.com/terrelln/linux/commit/ac2ee65dcb7318afe426ad08f6a844faf3aebb41
>
> I looks like you could remove a bit more dead code by noting __GNUC__ >= 4
> (gcc-4.9 is currently the oldest supported [1]).
Yeah, that would certainly be possible. My goal was to remove the most egregiously
irrelevant code from the kernel, in addition to unused functions which would generate
-Wframe-larger-than compiler warnings. My tooling doesn’t have the logic to reason
about >= relationships yet. If it isn’t too hard to add, I may go ahead and do that,
otherwise I will leave it for future work. I view that as a “nice to have” instead of a
hard requirement, though let me know if you disagree.
Best,
Nick
> [1] Documentation/process/changes.rst
>
> Best Regards
> Michał Mirosław
next prev parent reply other threads:[~2020-12-18 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 20:51 [PATCH v7 0/3] Update to zstd-1.4.6 Nick Terrell
2020-12-03 20:51 ` [PATCH v7 1/3] lib: zstd: Add kernel-specific API Nick Terrell
2020-12-03 20:51 ` [PATCH v7 2/3] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2020-12-03 20:51 ` [PATCH v7 3/3] lib: zstd: Upgrade to latest upstream zstd version 1.4.6 Nick Terrell
2020-12-15 20:58 ` [PATCH v7 0/3] Update to zstd-1.4.6 Nick Terrell
2020-12-16 0:00 ` [f2fs-dev] " Eric Biggers
2020-12-16 0:48 ` Nick Terrell
2020-12-16 0:58 ` Herbert Xu
2020-12-16 1:12 ` Nick Terrell
2020-12-16 18:50 ` David Sterba
2020-12-16 22:07 ` Nick Terrell
2020-12-17 1:23 ` Michał Mirosław
2020-12-18 18:57 ` Nick Terrell [this message]
2021-02-27 9:33 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EEFB7148-86B7-4761-BAB2-D35F29614A3E@fb.com \
--to=terrelln@fb.com \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=cyan@fb.com \
--cc=dsterba@suse.cz \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=jweiner@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nickrterrell@gmail.com \
--cc=niketa@fb.com \
--cc=oss@malat.biz \
--cc=squashfs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).