linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Nick Terrell" <terrelln@fb.com>,
	"Eric Biggers" <ebiggers@kernel.org>,
	"Nick Terrell" <nickrterrell@gmail.com>,
	"squashfs-devel@lists.sourceforge.net"
	<squashfs-devel@lists.sourceforge.net>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Yann Collet" <cyan@fb.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>,
	"Petr Malat" <oss@malat.biz>, "Chris Mason" <clm@fb.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"Kernel Team" <Kernel-team@fb.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Niket Agarwal" <niketa@fb.com>,
	"Btrfs BTRFS" <linux-btrfs@vger.kernel.org>,
	"Johannes Weiner" <jweiner@fb.com>
Subject: Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6
Date: Wed, 16 Dec 2020 19:50:52 +0100	[thread overview]
Message-ID: <20201216185052.GL6430@twin.jikos.cz> (raw)
In-Reply-To: <20201216005806.GA26841@gondor.apana.org.au>

On Wed, Dec 16, 2020 at 11:58:07AM +1100, Herbert Xu wrote:
> On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote:
> >
> > Thanks for the advice! The first zstd patches went through Herbert’s tree, which is
> > why I’ve sent them this way.
> 
> Sorry, but I'm not touch these patches as Christoph's objections
> don't seem to have been addressed.

I have objections to the current patchset as well, the build bot has
found that some of the function frames are overly large (up to 3800
bytes) [1], besides the original complaint that the patch 3/3 is 1.5MiB.

[1] https://lore.kernel.org/lkml/20201204140314.GS6430@twin.jikos.cz/

  parent reply	other threads:[~2020-12-16 18:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 20:51 [PATCH v7 0/3] Update to zstd-1.4.6 Nick Terrell
2020-12-03 20:51 ` [PATCH v7 1/3] lib: zstd: Add kernel-specific API Nick Terrell
2020-12-03 20:51 ` [PATCH v7 2/3] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2020-12-03 20:51 ` [PATCH v7 3/3] lib: zstd: Upgrade to latest upstream zstd version 1.4.6 Nick Terrell
2020-12-15 20:58 ` [PATCH v7 0/3] Update to zstd-1.4.6 Nick Terrell
2020-12-16  0:00   ` [f2fs-dev] " Eric Biggers
2020-12-16  0:48     ` Nick Terrell
2020-12-16  0:58       ` Herbert Xu
2020-12-16  1:12         ` Nick Terrell
2020-12-16 18:50         ` David Sterba [this message]
2020-12-16 22:07           ` Nick Terrell
2020-12-17  1:23             ` Michał Mirosław
2020-12-18 18:57               ` Nick Terrell
2021-02-27  9:33 ` Oleksandr Natalenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216185052.GL6430@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=Kernel-team@fb.com \
    --cc=clm@fb.com \
    --cc=cyan@fb.com \
    --cc=ebiggers@kernel.org \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jweiner@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=nickrterrell@gmail.com \
    --cc=niketa@fb.com \
    --cc=oss@malat.biz \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).