* [PATCH] qla2xxx: silence two GCC warnings
@ 2012-09-30 11:07 Paul Bolle
2012-09-30 21:21 ` Rolf Eike Beer
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2012-09-30 11:07 UTC (permalink / raw)
To: Andrew Vasquez, linux-driver, James E.J. Bottomley
Cc: linux-scsi, linux-kernel
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’:
drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above array bounds [-Warray-bounds]
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_register’:
drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is above array bounds [-Warray-bounds]
It seems that the sequence of a strcpy followed by a strlen confuses GCC
when it is keeping track of array bounds here. (It is not clear to me
which array triggers this warning and by how much GCC thinks the
subscript is above its bounds. Neither is it clear to me why comparable
code in these two functions doesn't trigger this warning.)
The easiest way to silence these warnings is to hardcode the length of
these two strings in the code here. The length used here is the length
of the string, including its NUL terminator, rounded up to the next
multiple of four.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) I noticed this warning while building v3.6-rc7 on current Fedora
17, using Fedora's default config.
1) Compile tested only.
drivers/scsi/qla2xxx/qla_gs.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 05260d2..a3ef5d0 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -1326,10 +1326,8 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
eiter = (struct ct_fdmi_hba_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_HBA_MANUFACTURER);
strcpy(eiter->a.manufacturer, "QLogic Corporation");
- alen = strlen(eiter->a.manufacturer);
- alen += (alen & 3) ? (4 - (alen & 3)) : 4;
- eiter->len = cpu_to_be16(4 + alen);
- size += 4 + alen;
+ eiter->len = cpu_to_be16(4 + 20);
+ size += 4 + 20;
ql_dbg(ql_dbg_disc, vha, 0x2026,
"Manufacturer = %s.\n", eiter->a.manufacturer);
@@ -1647,10 +1645,8 @@ qla2x00_fdmi_rpa(scsi_qla_host_t *vha)
eiter = (struct ct_fdmi_port_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_PORT_OS_DEVICE_NAME);
strcpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME);
- alen = strlen(eiter->a.os_dev_name);
- alen += (alen & 3) ? (4 - (alen & 3)) : 4;
- eiter->len = cpu_to_be16(4 + alen);
- size += 4 + alen;
+ eiter->len = cpu_to_be16(4 + 8);
+ size += 4 + 8;
ql_dbg(ql_dbg_disc, vha, 0x204b,
"OS_Device_Name=%s.\n", eiter->a.os_dev_name);
--
1.7.11.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] qla2xxx: silence two GCC warnings
2012-09-30 11:07 [PATCH] qla2xxx: silence two GCC warnings Paul Bolle
@ 2012-09-30 21:21 ` Rolf Eike Beer
2012-10-02 7:42 ` [PATCH v2] " Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Rolf Eike Beer @ 2012-09-30 21:21 UTC (permalink / raw)
To: Paul Bolle, linux-scsi; +Cc: Andrew Vasquez, linux-driver, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
Am Sonntag 30 September 2012, 13:07:54 schrieb Paul Bolle:
> Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
> warnings:
> drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’:
> drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above
> array bounds [-Warray-bounds] drivers/scsi/qla2xxx/qla_gs.c: In function
> ‘qla2x00_fdmi_register’: drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning:
> array subscript is above array bounds [-Warray-bounds]
>
> It seems that the sequence of a strcpy followed by a strlen confuses GCC
> when it is keeping track of array bounds here. (It is not clear to me
> which array triggers this warning and by how much GCC thinks the
> subscript is above its bounds. Neither is it clear to me why comparable
> code in these two functions doesn't trigger this warning.)
>
> The easiest way to silence these warnings is to hardcode the length of
> these two strings in the code here. The length used here is the length
> of the string, including its NUL terminator, rounded up to the next
> multiple of four.
This adds some magic values, which is asking for trouble once someone changes
the manufacturer string or something. What about something like this:
const char *qlogic = "QLogic Corporation";
strcpy(eiter->a.manufacturer, qlogic);
alen += round_up(strlen(qlogic), 4);
...
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] qla2xxx: silence two GCC warnings
2012-09-30 21:21 ` Rolf Eike Beer
@ 2012-10-02 7:42 ` Paul Bolle
2012-10-04 17:42 ` Saurav Kashyap
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2012-10-02 7:42 UTC (permalink / raw)
To: Andrew Vasquez, linux-driver, James E.J. Bottomley, Rolf Eike Beer
Cc: linux-scsi, linux-kernel
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’:
drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above array bounds [-Warray-bounds]
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_register’:
drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is above array bounds [-Warray-bounds]
It seems that the sequence of a strcpy followed by a strlen confuses GCC
when it is keeping track of array bounds here. (It is not clear to me
which array triggers this warning and by how much GCC thinks the
subscript is above its bounds. Neither is it clear to me why comparable
code in these two functions doesn't trigger this warning.)
An easy way to silence these warnings is to use preprocessor macros
here, as that apparently gives GCC enough information to keep track of
array bounds.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Rolf suggested to not use magic constants, to make sure things keep
working when these strings change in the future. A trivial solution is
to use preprocessor macros. I needed to add one for the manufacturer
string.
1) Still only compile tested.
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_gs.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index 39007f5..8895038 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -37,6 +37,7 @@
#include "qla_nx.h"
#define QLA2XXX_DRIVER_NAME "qla2xxx"
#define QLA2XXX_APIDEV "ql2xapidev"
+#define QLA2XXX_MANUFACTURER "QLogic Corporation"
/*
* We have MAILBOX_REGISTER_COUNT sized arrays in a few places,
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 05260d2..1714035 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -1325,8 +1325,8 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
/* Manufacturer. */
eiter = (struct ct_fdmi_hba_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_HBA_MANUFACTURER);
- strcpy(eiter->a.manufacturer, "QLogic Corporation");
- alen = strlen(eiter->a.manufacturer);
+ strcpy(eiter->a.manufacturer, QLA2XXX_MANUFACTURER);
+ alen = strlen(QLA2XXX_MANUFACTURER);
alen += (alen & 3) ? (4 - (alen & 3)) : 4;
eiter->len = cpu_to_be16(4 + alen);
size += 4 + alen;
@@ -1647,7 +1647,7 @@ qla2x00_fdmi_rpa(scsi_qla_host_t *vha)
eiter = (struct ct_fdmi_port_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_PORT_OS_DEVICE_NAME);
strcpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME);
- alen = strlen(eiter->a.os_dev_name);
+ alen = strlen(QLA2XXX_DRIVER_NAME);
alen += (alen & 3) ? (4 - (alen & 3)) : 4;
eiter->len = cpu_to_be16(4 + alen);
size += 4 + alen;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] qla2xxx: silence two GCC warnings
2012-10-02 7:42 ` [PATCH v2] " Paul Bolle
@ 2012-10-04 17:42 ` Saurav Kashyap
2012-10-05 12:23 ` [PATCH v3] " Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Saurav Kashyap @ 2012-10-04 17:42 UTC (permalink / raw)
To: Paul Bolle, Andrew Vasquez, Dept-Eng Linux Driver,
James E.J. Bottomley, Rolf Eike Beer
Cc: linux-scsi, linux-kernel
>Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
>warnings:
> drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
> drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
>above array bounds [-Warray-bounds]
> drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_register¹:
> drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is
>above array bounds [-Warray-bounds]
>
>It seems that the sequence of a strcpy followed by a strlen confuses GCC
>when it is keeping track of array bounds here. (It is not clear to me
>which array triggers this warning and by how much GCC thinks the
>subscript is above its bounds. Neither is it clear to me why comparable
>code in these two functions doesn't trigger this warning.)
>
>An easy way to silence these warnings is to use preprocessor macros
>here, as that apparently gives GCC enough information to keep track of
>array bounds.
>
>Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>---
>0) Rolf suggested to not use magic constants, to make sure things keep
>working when these strings change in the future. A trivial solution is
>to use preprocessor macros. I needed to add one for the manufacturer
>string.
>
>1) Still only compile tested.
>
> drivers/scsi/qla2xxx/qla_def.h | 1 +
> drivers/scsi/qla2xxx/qla_gs.c | 6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_def.h
>b/drivers/scsi/qla2xxx/qla_def.h
>index 39007f5..8895038 100644
>--- a/drivers/scsi/qla2xxx/qla_def.h
>+++ b/drivers/scsi/qla2xxx/qla_def.h
>@@ -37,6 +37,7 @@
> #include "qla_nx.h"
> #define QLA2XXX_DRIVER_NAME "qla2xxx"
> #define QLA2XXX_APIDEV "ql2xapidev"
>+#define QLA2XXX_MANUFACTURER "QLogic Corporation"
>
> /*
> * We have MAILBOX_REGISTER_COUNT sized arrays in a few places,
>diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
>index 05260d2..1714035 100644
>--- a/drivers/scsi/qla2xxx/qla_gs.c
>+++ b/drivers/scsi/qla2xxx/qla_gs.c
>@@ -1325,8 +1325,8 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
> /* Manufacturer. */
> eiter = (struct ct_fdmi_hba_attr *) (entries + size);
> eiter->type = __constant_cpu_to_be16(FDMI_HBA_MANUFACTURER);
>- strcpy(eiter->a.manufacturer, "QLogic Corporation");
>- alen = strlen(eiter->a.manufacturer);
>+ strcpy(eiter->a.manufacturer, QLA2XXX_MANUFACTURER);
>+ alen = strlen(QLA2XXX_MANUFACTURER);
Hi Paul,
It looks fine except one small thing. Instead of strcpy, strncpy will be
better option something like this
+ alen = strlen(QLA2XXX_MANUFACTURER);
+ strncpy(eiter->a.manufacturer, QLA2XXX_MANUFACTURER, alen);
Thanks,
~Saurav
> alen += (alen & 3) ? (4 - (alen & 3)) : 4;
> eiter->len = cpu_to_be16(4 + alen);
> size += 4 + alen;
>@@ -1647,7 +1647,7 @@ qla2x00_fdmi_rpa(scsi_qla_host_t *vha)
> eiter = (struct ct_fdmi_port_attr *) (entries + size);
> eiter->type = __constant_cpu_to_be16(FDMI_PORT_OS_DEVICE_NAME);
> strcpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME);
>- alen = strlen(eiter->a.os_dev_name);
>+ alen = strlen(QLA2XXX_DRIVER_NAME);
> alen += (alen & 3) ? (4 - (alen & 3)) : 4;
> eiter->len = cpu_to_be16(4 + alen);
> size += 4 + alen;
>--
>1.7.11.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] qla2xxx: silence two GCC warnings
2012-10-04 17:42 ` Saurav Kashyap
@ 2012-10-05 12:23 ` Paul Bolle
2012-10-08 16:15 ` Saurav Kashyap
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2012-10-05 12:23 UTC (permalink / raw)
To: Andrew Vasquez, James E.J. Bottomley, linux-driver,
Rolf Eike Beer, Saurav Kashyap
Cc: linux-scsi, linux-kernel
Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
warnings:
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_rhba’:
drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is above array bounds [-Warray-bounds]
drivers/scsi/qla2xxx/qla_gs.c: In function ‘qla2x00_fdmi_register’:
drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is above array bounds [-Warray-bounds]
It seems that the sequence of a strcpy followed by a strlen confuses GCC
when it is keeping track of array bounds here. (It is not clear to me
which array triggers this warning and by how much GCC thinks the
subscript is above its bounds. Neither is it clear to me why comparable
code in these two functions doesn't trigger this warning.)
An easy way to silence these warnings is to use preprocessor macros and
strncpy, as that apparently gives GCC enough information to keep track
of array bounds.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Updated for Saurav's request to use strncpy().
1) Still only compile tested.
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_gs.c | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index 39007f5..8895038 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -37,6 +37,7 @@
#include "qla_nx.h"
#define QLA2XXX_DRIVER_NAME "qla2xxx"
#define QLA2XXX_APIDEV "ql2xapidev"
+#define QLA2XXX_MANUFACTURER "QLogic Corporation"
/*
* We have MAILBOX_REGISTER_COUNT sized arrays in a few places,
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 05260d2..824cbcf 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -1325,8 +1325,8 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
/* Manufacturer. */
eiter = (struct ct_fdmi_hba_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_HBA_MANUFACTURER);
- strcpy(eiter->a.manufacturer, "QLogic Corporation");
- alen = strlen(eiter->a.manufacturer);
+ alen = strlen(QLA2XXX_MANUFACTURER);
+ strncpy(eiter->a.manufacturer, QLA2XXX_MANUFACTURER, alen + 1);
alen += (alen & 3) ? (4 - (alen & 3)) : 4;
eiter->len = cpu_to_be16(4 + alen);
size += 4 + alen;
@@ -1646,8 +1646,8 @@ qla2x00_fdmi_rpa(scsi_qla_host_t *vha)
/* OS device name. */
eiter = (struct ct_fdmi_port_attr *) (entries + size);
eiter->type = __constant_cpu_to_be16(FDMI_PORT_OS_DEVICE_NAME);
- strcpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME);
- alen = strlen(eiter->a.os_dev_name);
+ alen = strlen(QLA2XXX_DRIVER_NAME);
+ strncpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME, alen + 1);
alen += (alen & 3) ? (4 - (alen & 3)) : 4;
eiter->len = cpu_to_be16(4 + alen);
size += 4 + alen;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3] qla2xxx: silence two GCC warnings
2012-10-05 12:23 ` [PATCH v3] " Paul Bolle
@ 2012-10-08 16:15 ` Saurav Kashyap
2013-01-29 9:57 ` Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Saurav Kashyap @ 2012-10-08 16:15 UTC (permalink / raw)
To: Paul Bolle, Andrew Vasquez, James E.J. Bottomley,
Dept-Eng Linux Driver, Rolf Eike Beer
Cc: linux-scsi, linux-kernel
Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Thanks,
~Saurav
>Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
>warnings:
> drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
> drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
>above array bounds [-Warray-bounds]
> drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_register¹:
> drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is
>above array bounds [-Warray-bounds]
>
>It seems that the sequence of a strcpy followed by a strlen confuses GCC
>when it is keeping track of array bounds here. (It is not clear to me
>which array triggers this warning and by how much GCC thinks the
>subscript is above its bounds. Neither is it clear to me why comparable
>code in these two functions doesn't trigger this warning.)
>
>An easy way to silence these warnings is to use preprocessor macros and
>strncpy, as that apparently gives GCC enough information to keep track
>of array bounds.
>
>Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>---
>0) Updated for Saurav's request to use strncpy().
>
>1) Still only compile tested.
>
> drivers/scsi/qla2xxx/qla_def.h | 1 +
> drivers/scsi/qla2xxx/qla_gs.c | 8 ++++----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_def.h
>b/drivers/scsi/qla2xxx/qla_def.h
>index 39007f5..8895038 100644
>--- a/drivers/scsi/qla2xxx/qla_def.h
>+++ b/drivers/scsi/qla2xxx/qla_def.h
>@@ -37,6 +37,7 @@
> #include "qla_nx.h"
> #define QLA2XXX_DRIVER_NAME "qla2xxx"
> #define QLA2XXX_APIDEV "ql2xapidev"
>+#define QLA2XXX_MANUFACTURER "QLogic Corporation"
>
> /*
> * We have MAILBOX_REGISTER_COUNT sized arrays in a few places,
>diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
>index 05260d2..824cbcf 100644
>--- a/drivers/scsi/qla2xxx/qla_gs.c
>+++ b/drivers/scsi/qla2xxx/qla_gs.c
>@@ -1325,8 +1325,8 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
> /* Manufacturer. */
> eiter = (struct ct_fdmi_hba_attr *) (entries + size);
> eiter->type = __constant_cpu_to_be16(FDMI_HBA_MANUFACTURER);
>- strcpy(eiter->a.manufacturer, "QLogic Corporation");
>- alen = strlen(eiter->a.manufacturer);
>+ alen = strlen(QLA2XXX_MANUFACTURER);
>+ strncpy(eiter->a.manufacturer, QLA2XXX_MANUFACTURER, alen + 1);
> alen += (alen & 3) ? (4 - (alen & 3)) : 4;
> eiter->len = cpu_to_be16(4 + alen);
> size += 4 + alen;
>@@ -1646,8 +1646,8 @@ qla2x00_fdmi_rpa(scsi_qla_host_t *vha)
> /* OS device name. */
> eiter = (struct ct_fdmi_port_attr *) (entries + size);
> eiter->type = __constant_cpu_to_be16(FDMI_PORT_OS_DEVICE_NAME);
>- strcpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME);
>- alen = strlen(eiter->a.os_dev_name);
>+ alen = strlen(QLA2XXX_DRIVER_NAME);
>+ strncpy(eiter->a.os_dev_name, QLA2XXX_DRIVER_NAME, alen + 1);
> alen += (alen & 3) ? (4 - (alen & 3)) : 4;
> eiter->len = cpu_to_be16(4 + alen);
> size += 4 + alen;
>--
>1.7.11.4
>
>
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3] qla2xxx: silence two GCC warnings
2012-10-08 16:15 ` Saurav Kashyap
@ 2013-01-29 9:57 ` Paul Bolle
2013-01-30 8:07 ` Saurav Kashyap
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2013-01-29 9:57 UTC (permalink / raw)
To: Saurav Kashyap
Cc: Andrew Vasquez, James E.J. Bottomley, Dept-Eng Linux Driver,
Rolf Eike Beer, linux-scsi, linux-kernel
On Mon, 2012-10-08 at 11:15 -0500, Saurav Kashyap wrote:
> Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
>
> Thanks,
> ~Saurav
>
> >Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
> >warnings:
> > drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
> > drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
> >above array bounds [-Warray-bounds]
> > drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_register¹:
> > drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is
> >above array bounds [-Warray-bounds]
This patch was originally posted to silence two GCC warnings while
building v3.6-rc7. Basically identical warnings can still be seen while
building v3.8-rc5. What's the status of this patch?
Paul Bolle
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3] qla2xxx: silence two GCC warnings
2013-01-29 9:57 ` Paul Bolle
@ 2013-01-30 8:07 ` Saurav Kashyap
2013-01-30 8:14 ` Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Saurav Kashyap @ 2013-01-30 8:07 UTC (permalink / raw)
To: Paul Bolle
Cc: Andrew Vasquez, James E.J. Bottomley, Dept-Eng Linux Driver,
Rolf Eike Beer, linux-scsi, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1738 bytes --]
>On Mon, 2012-10-08 at 11:15 -0500, Saurav Kashyap wrote:
>> Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
>>
>> Thanks,
>> ~Saurav
>>
>> >Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC
>> >warnings:
>> > drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:
>> > drivers/scsi/qla2xxx/qla_gs.c:1339:7: warning: array subscript is
>> >above array bounds [-Warray-bounds]
>> > drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_register¹:
>> > drivers/scsi/qla2xxx/qla_gs.c:1663:15: warning: array subscript is
>> >above array bounds [-Warray-bounds]
>
>This patch was originally posted to silence two GCC warnings while
>building v3.6-rc7. Basically identical warnings can still be seen while
>building v3.8-rc5. What's the status of this patch?
Hi Paul,
I am submitting some correction patches today and this patch will be part
of the scsi-misc submission after that set.
Thanks,
~Saurav
>
>
>Paul Bolle
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
________________________________
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-01-30 8:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-30 11:07 [PATCH] qla2xxx: silence two GCC warnings Paul Bolle
2012-09-30 21:21 ` Rolf Eike Beer
2012-10-02 7:42 ` [PATCH v2] " Paul Bolle
2012-10-04 17:42 ` Saurav Kashyap
2012-10-05 12:23 ` [PATCH v3] " Paul Bolle
2012-10-08 16:15 ` Saurav Kashyap
2013-01-29 9:57 ` Paul Bolle
2013-01-30 8:07 ` Saurav Kashyap
2013-01-30 8:14 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).