* [PATCH] efi: Fix debugobjects warning on efi_rts_work
@ 2018-10-23 14:18 Waiman Long
2018-10-23 16:43 ` Prakhya, Sai Praneeth
0 siblings, 1 reply; 3+ messages in thread
From: Waiman Long @ 2018-10-23 14:18 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-efi, linux-kernel, Sai Praneeth, Waiman Long
The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi
page fault handler") converted efi_rts_work from an auto variable to a
global variable. However, when submitting the work, INIT_WORK_ONSTACK()
was still used causing the following complaint from debugobjects:
ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760,
but annotated.
Change the macro to just INIT_WORK() to eliminate the warning.
Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler")
Signed-off-by: Waiman Long <longman@redhat.com>
---
drivers/firmware/efi/runtime-wrappers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c
index a19d845..8903b9c 100644
--- a/drivers/firmware/efi/runtime-wrappers.c
+++ b/drivers/firmware/efi/runtime-wrappers.c
@@ -67,7 +67,7 @@
} \
\
init_completion(&efi_rts_work.efi_rts_comp); \
- INIT_WORK_ONSTACK(&efi_rts_work.work, efi_call_rts); \
+ INIT_WORK(&efi_rts_work.work, efi_call_rts); \
efi_rts_work.arg1 = _arg1; \
efi_rts_work.arg2 = _arg2; \
efi_rts_work.arg3 = _arg3; \
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] efi: Fix debugobjects warning on efi_rts_work
2018-10-23 14:18 [PATCH] efi: Fix debugobjects warning on efi_rts_work Waiman Long
@ 2018-10-23 16:43 ` Prakhya, Sai Praneeth
2018-11-05 13:01 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Prakhya, Sai Praneeth @ 2018-10-23 16:43 UTC (permalink / raw)
To: Waiman Long, Ard Biesheuvel; +Cc: linux-efi, linux-kernel
> -----Original Message-----
> From: Waiman Long [mailto:longman@redhat.com]
> Sent: Tuesday, October 23, 2018 7:18 AM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; Prakhya, Sai
> Praneeth <sai.praneeth.prakhya@intel.com>; Waiman Long
> <longman@redhat.com>
> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
>
> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
> handler") converted efi_rts_work from an auto variable to a global variable.
> However, when submitting the work, INIT_WORK_ONSTACK() was still used
> causing the following complaint from debugobjects:
>
> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
> annotated.
>
> Change the macro to just INIT_WORK() to eliminate the warning.
>
> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
> handler")
Thanks for fixing this :)
Looks good to me.
Regards,
Sai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] efi: Fix debugobjects warning on efi_rts_work
2018-10-23 16:43 ` Prakhya, Sai Praneeth
@ 2018-11-05 13:01 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-11-05 13:01 UTC (permalink / raw)
To: Prakhya, Sai Praneeth; +Cc: Waiman Long, linux-efi, linux-kernel
On 23 October 2018 at 18:43, Prakhya, Sai Praneeth
<sai.praneeth.prakhya@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: Waiman Long [mailto:longman@redhat.com]
>> Sent: Tuesday, October 23, 2018 7:18 AM
>> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; Prakhya, Sai
>> Praneeth <sai.praneeth.prakhya@intel.com>; Waiman Long
>> <longman@redhat.com>
>> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
>>
>> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler") converted efi_rts_work from an auto variable to a global variable.
>> However, when submitting the work, INIT_WORK_ONSTACK() was still used
>> causing the following complaint from debugobjects:
>>
>> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
>> annotated.
>>
>> Change the macro to just INIT_WORK() to eliminate the warning.
>>
>> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler")
>
> Thanks for fixing this :)
> Looks good to me.
>
> Regards,
> Sai
Thanks
Queued in efi/urgent (with Sai's ack)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-05 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 14:18 [PATCH] efi: Fix debugobjects warning on efi_rts_work Waiman Long
2018-10-23 16:43 ` Prakhya, Sai Praneeth
2018-11-05 13:01 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).