linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] hwmon: (nct6883) Support NCT6686D
@ 2021-03-04 10:44 Jiqi Li
  2021-03-08  8:08 ` 回复: " Jiqi JQ9 Li
  2021-03-11 21:50 ` Guenter Roeck
  0 siblings, 2 replies; 4+ messages in thread
From: Jiqi Li @ 2021-03-04 10:44 UTC (permalink / raw)
  To: jdelvare, linux, linux-hwmon, linux-kernel; +Cc: markpearson, Jiqi Li

Add support for NCT6686D chip used in the Lenovo P620.

Signed-off-by: Jiqi Li <lijq9@lenovo.com>
Reviewed-by: Mark Pearson <markpearson@lenovo.com>
---
Changes in v2: Corrected typo from NCT6886D to NCT6686D
---
 drivers/hwmon/nct6683.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index a23047a3bfe2..256e8d62f858 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * nct6683 - Driver for the hardware monitoring functionality of
- *	     Nuvoton NCT6683D/NCT6687D eSIO
+ *	     Nuvoton NCT6683D/NCT6686D/NCT6687D eSIO
  *
  * Copyright (C) 2013  Guenter Roeck <linux@roeck-us.net>
  *
@@ -12,6 +12,7 @@
  *
  * Chip        #vin    #fan    #pwm    #temp  chip ID
  * nct6683d     21(1)   16      8       32(1) 0xc730
+ * nct6686d     21(1)   16      8       32(1) 0xd440
  * nct6687d     21(1)   16      8       32(1) 0xd590
  *
  * Notes:
@@ -33,7 +34,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
-enum kinds { nct6683, nct6687 };
+enum kinds { nct6683, nct6686, nct6687 };
 
 static bool force;
 module_param(force, bool, 0);
@@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
 
 static const char * const nct6683_device_names[] = {
 	"nct6683",
+	"nct6686",
 	"nct6687",
 };
 
 static const char * const nct6683_chip_names[] = {
 	"NCT6683D",
+	"NCT6686D",
 	"NCT6687D",
 };
 
@@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
 
 #define SIO_NCT6681_ID		0xb270	/* for later */
 #define SIO_NCT6683_ID		0xc730
+#define SIO_NCT6686_ID		0xd440
 #define SIO_NCT6687_ID		0xd590
 #define SIO_ID_MASK		0xFFF0
 
@@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
 	case SIO_NCT6683_ID:
 		sio_data->kind = nct6683;
 		break;
+	case SIO_NCT6686_ID:
+		sio_data->kind = nct6686;
+		break;
 	case SIO_NCT6687_ID:
 		sio_data->kind = nct6687;
 		break;
-- 
2.18.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* 回复: [PATCH v2] hwmon: (nct6883) Support NCT6686D
  2021-03-04 10:44 [PATCH v2] hwmon: (nct6883) Support NCT6686D Jiqi Li
@ 2021-03-08  8:08 ` Jiqi JQ9 Li
  2021-03-11 21:50 ` Guenter Roeck
  1 sibling, 0 replies; 4+ messages in thread
From: Jiqi JQ9 Li @ 2021-03-08  8:08 UTC (permalink / raw)
  To: Guenter Roeck, jdelvare, linux-hwmon, linux-kernel; +Cc: Mark RH Pearson

Hi Guenter,

Could you please take a look this version? Thanks.

Regards,
Jiqi.

-----邮件原件-----
发件人: Jiqi JQ9 Li <lijq9@lenovo.com> 
发送时间: 2021年3月4日 18:44
收件人: jdelvare@suse.com; linux@roeck-us.net; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: Mark RH Pearson <markpearson@lenovo.com>; Jiqi JQ9 Li <lijq9@lenovo.com>
主题: [PATCH v2] hwmon: (nct6883) Support NCT6686D

Add support for NCT6686D chip used in the Lenovo P620.

Signed-off-by: Jiqi Li <lijq9@lenovo.com>
Reviewed-by: Mark Pearson <markpearson@lenovo.com>
---
Changes in v2: Corrected typo from NCT6886D to NCT6686D
---
 drivers/hwmon/nct6683.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index a23047a3bfe2..256e8d62f858 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * nct6683 - Driver for the hardware monitoring functionality of
- *	     Nuvoton NCT6683D/NCT6687D eSIO
+ *	     Nuvoton NCT6683D/NCT6686D/NCT6687D eSIO
  *
  * Copyright (C) 2013  Guenter Roeck <linux@roeck-us.net>
  *
@@ -12,6 +12,7 @@
  *
  * Chip        #vin    #fan    #pwm    #temp  chip ID
  * nct6683d     21(1)   16      8       32(1) 0xc730
+ * nct6686d     21(1)   16      8       32(1) 0xd440
  * nct6687d     21(1)   16      8       32(1) 0xd590
  *
  * Notes:
@@ -33,7 +34,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
-enum kinds { nct6683, nct6687 };
+enum kinds { nct6683, nct6686, nct6687 };
 
 static bool force;
 module_param(force, bool, 0);
@@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
 
 static const char * const nct6683_device_names[] = {
 	"nct6683",
+	"nct6686",
 	"nct6687",
 };
 
 static const char * const nct6683_chip_names[] = {
 	"NCT6683D",
+	"NCT6686D",
 	"NCT6687D",
 };
 
@@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
 
 #define SIO_NCT6681_ID		0xb270	/* for later */
 #define SIO_NCT6683_ID		0xc730
+#define SIO_NCT6686_ID		0xd440
 #define SIO_NCT6687_ID		0xd590
 #define SIO_ID_MASK		0xFFF0
 
@@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
 	case SIO_NCT6683_ID:
 		sio_data->kind = nct6683;
 		break;
+	case SIO_NCT6686_ID:
+		sio_data->kind = nct6686;
+		break;
 	case SIO_NCT6687_ID:
 		sio_data->kind = nct6687;
 		break;
--
2.18.2


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwmon: (nct6883) Support NCT6686D
  2021-03-04 10:44 [PATCH v2] hwmon: (nct6883) Support NCT6686D Jiqi Li
  2021-03-08  8:08 ` 回复: " Jiqi JQ9 Li
@ 2021-03-11 21:50 ` Guenter Roeck
  2021-03-12  3:16   ` 回复: [External] " Jiqi JQ9 Li
  1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2021-03-11 21:50 UTC (permalink / raw)
  To: Jiqi Li; +Cc: jdelvare, linux-hwmon, linux-kernel, markpearson

On Thu, Mar 04, 2021 at 06:44:21PM +0800, Jiqi Li wrote:
> Add support for NCT6686D chip used in the Lenovo P620.
> 
> Signed-off-by: Jiqi Li <lijq9@lenovo.com>
> Reviewed-by: Mark Pearson <markpearson@lenovo.com>
> ---
> Changes in v2: Corrected typo from NCT6886D to NCT6686D

Not entirely; the subject is still partially wrong.
No need to resend, though, I'll fix then while applying it.

Guenter

> ---
>  drivers/hwmon/nct6683.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index a23047a3bfe2..256e8d62f858 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -1,7 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
>   * nct6683 - Driver for the hardware monitoring functionality of
> - *	     Nuvoton NCT6683D/NCT6687D eSIO
> + *	     Nuvoton NCT6683D/NCT6686D/NCT6687D eSIO
>   *
>   * Copyright (C) 2013  Guenter Roeck <linux@roeck-us.net>
>   *
> @@ -12,6 +12,7 @@
>   *
>   * Chip        #vin    #fan    #pwm    #temp  chip ID
>   * nct6683d     21(1)   16      8       32(1) 0xc730
> + * nct6686d     21(1)   16      8       32(1) 0xd440
>   * nct6687d     21(1)   16      8       32(1) 0xd590
>   *
>   * Notes:
> @@ -33,7 +34,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  
> -enum kinds { nct6683, nct6687 };
> +enum kinds { nct6683, nct6686, nct6687 };
>  
>  static bool force;
>  module_param(force, bool, 0);
> @@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
>  
>  static const char * const nct6683_device_names[] = {
>  	"nct6683",
> +	"nct6686",
>  	"nct6687",
>  };
>  
>  static const char * const nct6683_chip_names[] = {
>  	"NCT6683D",
> +	"NCT6686D",
>  	"NCT6687D",
>  };
>  
> @@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
>  
>  #define SIO_NCT6681_ID		0xb270	/* for later */
>  #define SIO_NCT6683_ID		0xc730
> +#define SIO_NCT6686_ID		0xd440
>  #define SIO_NCT6687_ID		0xd590
>  #define SIO_ID_MASK		0xFFF0
>  
> @@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
>  	case SIO_NCT6683_ID:
>  		sio_data->kind = nct6683;
>  		break;
> +	case SIO_NCT6686_ID:
> +		sio_data->kind = nct6686;
> +		break;
>  	case SIO_NCT6687_ID:
>  		sio_data->kind = nct6687;
>  		break;

^ permalink raw reply	[flat|nested] 4+ messages in thread
* 回复: [External]  Re: [PATCH v2] hwmon: (nct6883) Support NCT6686D
  2021-03-11 21:50 ` Guenter Roeck
@ 2021-03-12  3:16   ` Jiqi JQ9 Li
  0 siblings, 0 replies; 4+ messages in thread
From: Jiqi JQ9 Li @ 2021-03-12  3:16 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: jdelvare, linux-hwmon, linux-kernel, Mark RH Pearson

Got it. Thanks for your understanding. 

Regards,
Jiqi.

-----邮件原件-----
发件人: Guenter Roeck <groeck7@gmail.com> 代表 Guenter Roeck
发送时间: 2021年3月12日 5:51
收件人: Jiqi JQ9 Li <lijq9@lenovo.com>
抄送: jdelvare@suse.com; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org; Mark RH Pearson <markpearson@lenovo.com>
主题: [External] Re: [PATCH v2] hwmon: (nct6883) Support NCT6686D

On Thu, Mar 04, 2021 at 06:44:21PM +0800, Jiqi Li wrote:
> Add support for NCT6686D chip used in the Lenovo P620.
> 
> Signed-off-by: Jiqi Li <lijq9@lenovo.com>
> Reviewed-by: Mark Pearson <markpearson@lenovo.com>
> ---
> Changes in v2: Corrected typo from NCT6886D to NCT6686D

Not entirely; the subject is still partially wrong.
No need to resend, though, I'll fix then while applying it.

Guenter

> ---
>  drivers/hwmon/nct6683.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index 
> a23047a3bfe2..256e8d62f858 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -1,7 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
>   * nct6683 - Driver for the hardware monitoring functionality of
> - *	     Nuvoton NCT6683D/NCT6687D eSIO
> + *	     Nuvoton NCT6683D/NCT6686D/NCT6687D eSIO
>   *
>   * Copyright (C) 2013  Guenter Roeck <linux@roeck-us.net>
>   *
> @@ -12,6 +12,7 @@
>   *
>   * Chip        #vin    #fan    #pwm    #temp  chip ID
>   * nct6683d     21(1)   16      8       32(1) 0xc730
> + * nct6686d     21(1)   16      8       32(1) 0xd440
>   * nct6687d     21(1)   16      8       32(1) 0xd590
>   *
>   * Notes:
> @@ -33,7 +34,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  
> -enum kinds { nct6683, nct6687 };
> +enum kinds { nct6683, nct6686, nct6687 };
>  
>  static bool force;
>  module_param(force, bool, 0);
> @@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable 
> support for unknown vendors");
>  
>  static const char * const nct6683_device_names[] = {
>  	"nct6683",
> +	"nct6686",
>  	"nct6687",
>  };
>  
>  static const char * const nct6683_chip_names[] = {
>  	"NCT6683D",
> +	"NCT6686D",
>  	"NCT6687D",
>  };
>  
> @@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
>  
>  #define SIO_NCT6681_ID		0xb270	/* for later */
>  #define SIO_NCT6683_ID		0xc730
> +#define SIO_NCT6686_ID		0xd440
>  #define SIO_NCT6687_ID		0xd590
>  #define SIO_ID_MASK		0xFFF0
>  
> @@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
>  	case SIO_NCT6683_ID:
>  		sio_data->kind = nct6683;
>  		break;
> +	case SIO_NCT6686_ID:
> +		sio_data->kind = nct6686;
> +		break;
>  	case SIO_NCT6687_ID:
>  		sio_data->kind = nct6687;
>  		break;

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-12  3:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 10:44 [PATCH v2] hwmon: (nct6883) Support NCT6686D Jiqi Li
2021-03-08  8:08 ` 回复: " Jiqi JQ9 Li
2021-03-11 21:50 ` Guenter Roeck
2021-03-12  3:16   ` 回复: [External] " Jiqi JQ9 Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).