* [PATCH] usb: gadget: Remove unnecessary print function dev_err()
@ 2022-06-16 9:04 Jiapeng Chong
2022-06-16 10:16 ` Neal Liu
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-06-16 9:04 UTC (permalink / raw)
To: neal_liu
Cc: balbi, gregkh, joel, andrew, sumit.semwal, christian.koenig,
linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
linux-media, dri-devel, linaro-mm-sig, Jiapeng Chong
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
This was found by coccicheck:
./drivers/usb/gadget/udc/aspeed_udc.c:1546:2-9: line 1546 is redundant because platform_get_irq() already prints an error.
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/usb/gadget/udc/aspeed_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 1fc15228ff15..2c3dc80d6b8c 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1543,7 +1543,6 @@ static int ast_udc_probe(struct platform_device *pdev)
/* Find interrupt and install handler */
udc->irq = platform_get_irq(pdev, 0);
if (udc->irq < 0) {
- dev_err(&pdev->dev, "Failed to get interrupt\n");
rc = udc->irq;
goto err;
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] usb: gadget: Remove unnecessary print function dev_err()
2022-06-16 9:04 [PATCH] usb: gadget: Remove unnecessary print function dev_err() Jiapeng Chong
@ 2022-06-16 10:16 ` Neal Liu
0 siblings, 0 replies; 2+ messages in thread
From: Neal Liu @ 2022-06-16 10:16 UTC (permalink / raw)
To: Jiapeng Chong
Cc: balbi, gregkh, joel, andrew, sumit.semwal, christian.koenig,
linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
linux-media, dri-devel, linaro-mm-sig
> The print function dev_err() is redundant because platform_get_irq() already
> prints an error.
>
> This was found by coccicheck:
>
> ./drivers/usb/gadget/udc/aspeed_udc.c:1546:2-9: line 1546 is redundant
> because platform_get_irq() already prints an error.
>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Neal Liu <neal_liu@aspeedtech.com>
> ---
> drivers/usb/gadget/udc/aspeed_udc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/aspeed_udc.c
> b/drivers/usb/gadget/udc/aspeed_udc.c
> index 1fc15228ff15..2c3dc80d6b8c 100644
> --- a/drivers/usb/gadget/udc/aspeed_udc.c
> +++ b/drivers/usb/gadget/udc/aspeed_udc.c
> @@ -1543,7 +1543,6 @@ static int ast_udc_probe(struct platform_device
> *pdev)
> /* Find interrupt and install handler */
> udc->irq = platform_get_irq(pdev, 0);
> if (udc->irq < 0) {
> - dev_err(&pdev->dev, "Failed to get interrupt\n");
> rc = udc->irq;
> goto err;
> }
> --
> 2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-16 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 9:04 [PATCH] usb: gadget: Remove unnecessary print function dev_err() Jiapeng Chong
2022-06-16 10:16 ` Neal Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).