[PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[Yonglin Tan]

From: ylintan <yonglin.tan@outlook.com>

    This patch add VendorID/DeviceID definitions for EM120 FCCL project.
    It has the same configration as Quectel EM160R-GL and EM120R-GL.

    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
---
 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 8416267..0a6469c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
+		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
-- 
2.7.4

Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[Greg KH]

On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@outlook.com>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
>     Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>     Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

Ok, please stop and take a minute and go through the basic "how do I
write a kernel patch" tutorial on kernelnewbies.org.

You are submitting a patch that has a number of obvious things wrong
with it:
	- invalid from: line that does not match the signed-off-by line
	- made up out of thin air "reviewed-by:" lines from people who
	  have OBVIOUSLY NOT REVIEWED THIS PATCH!
	- indented changelog text in an odd format
	- extra spaces in the subject line
	- no versioning in the subject line, or below the --- line as
	  the documentation requires

Please take some time off, and come back next week with this all fixed
up AFTER you have gone through the kernelnewbies tutorial AND you have
read all of the Documentation/process/submitting-patches.rst file.

thanks,

greg k-h

回复: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[谭 永林]

Dear Greg,

Thanks for your advice. I will try to learn the tutorial. 

-----邮件原件-----
发件人: Greg KH <gregkh@linuxfoundation.org> 
发送时间: 2022年5月13日 15:10
收件人: Yonglin Tan <yonglin.tan@outlook.com>
抄送: mani@kernel.org; quic_hemantk@quicinc.com; loic.poulain@linaro.org; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@outlook.com>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
>     Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>     Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

Ok, please stop and take a minute and go through the basic "how do I
write a kernel patch" tutorial on kernelnewbies.org.

You are submitting a patch that has a number of obvious things wrong
with it:
	- invalid from: line that does not match the signed-off-by line
	- made up out of thin air "reviewed-by:" lines from people who
	  have OBVIOUSLY NOT REVIEWED THIS PATCH!
	- indented changelog text in an odd format
	- extra spaces in the subject line
	- no versioning in the subject line, or below the --- line as
	  the documentation requires

Please take some time off, and come back next week with this all fixed
up AFTER you have gone through the kernelnewbies tutorial AND you have
read all of the Documentation/process/submitting-patches.rst file.

thanks,

greg k-h

Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[Manivannan Sadhasivam]

On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@outlook.com>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
>     Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>     Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>

On top of what Greg said, you don't need to CC Greg for MHI patches. I will
review and apply the patches to MHI tree and submit a cumulative PR to Greg.

Let's give some air to him ;)

Thanks,
Mani

> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

回复: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[谭 永林]

Dear Mani,

Got it, thank you very much. 

Best regards.

-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@kernel.org> 
发送时间: 2022年5月13日 16:43
收件人: Yonglin Tan <yonglin.tan@outlook.com>
抄送: mani@kernel.org; quic_hemantk@quicinc.com; gregkh@linuxfoundation.org; loic.poulain@linaro.org; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@outlook.com>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
>     Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>     Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>

On top of what Greg said, you don't need to CC Greg for MHI patches. I will review and apply the patches to MHI tree and submit a cumulative PR to Greg.

Let's give some air to him ;)

Thanks,
Mani

> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c 
> b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
> 
> 

--
மணிவண்ணன் சதாசிவம்

回复: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[谭 永林]

Dear Greg,

I'm so sorry to bother you so many times. I just removed the signed-off-by line and please check it again, 

-----邮件原件-----
发件人: Greg KH <gregkh@linuxfoundation.org> 
发送时间: 2022年5月13日 14:05
收件人: Yonglin Tan <yonglin.tan@outlook.com>
抄送: mani@kernel.org; quic_hemantk@quicinc.com; loic.poulain@linaro.org; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

On Fri, May 13, 2022 at 01:59:11PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@outlook.com>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
>     Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I signed off on this commit?
Please NEVER add these lines from someone else.  THat is a legal statement you are making there, and I do not remember making it.

>     Link: https://lore.kernel.org/all/YnzRcFy1zwhdSP5D@kroah.com/

That points to a response from me, not the original commit.

Something went really wrong with this submission, please try again.

greg k-h