From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: "Jan Dąbroś" <jsd@semihalf.com>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Cc: Grzegorz Bernacki <gjb@semihalf.com>,
"Thomas, Rijo-john" <Rijo-john.Thomas@amd.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"Allen, John" <John.Allen@amd.com>,
"Singh, Brijesh" <Brijesh.Singh@amd.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH 3/6] crypto: ccp: Move some PSP mailbox bit definitions into common header
Date: Tue, 14 Feb 2023 22:05:22 +0000 [thread overview]
Message-ID: <MN0PR12MB61017A594AF2CCD1D75EC798E2A29@MN0PR12MB6101.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAOtMz3PuzpcrqQb-L9kzY1be4xwhp72fqNqSWnRvAE0Nd4d3qQ@mail.gmail.com>
[Public]
> -----Original Message-----
> From: Jan Dąbroś <jsd@semihalf.com>
> Sent: Tuesday, February 14, 2023 03:04
> To: Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: Grzegorz Bernacki <gjb@semihalf.com>; Thomas, Rijo-john <Rijo-
> john.Thomas@amd.com>; Lendacky, Thomas
> <Thomas.Lendacky@amd.com>; herbert@gondor.apana.org.au; Allen, John
> <John.Allen@amd.com>; Singh, Brijesh <Brijesh.Singh@amd.com>; Jarkko
> Nikula <jarkko.nikula@linux.intel.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Mika Westerberg
> <mika.westerberg@linux.intel.com>; linux-i2c@vger.kernel.org; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller
> <davem@davemloft.net>
> Subject: Re: [PATCH 3/6] crypto: ccp: Move some PSP mailbox bit definitions
> into common header
>
> (...)
> > @@ -99,7 +93,7 @@ static int psp_check_mbox_recovery(struct psp_mbox
> __iomem *mbox)
> >
> > tmp = readl(&mbox->cmd_fields);
> >
> > - return FIELD_GET(PSP_MBOX_FIELDS_RECOVERY, tmp);
> > + return FIELD_GET(PSP_CMDRESP_RECOVERY, tmp);
> > }
> >
> > static int psp_wait_cmd(struct psp_mbox __iomem *mbox)
> > @@ -107,7 +101,7 @@ static int psp_wait_cmd(struct psp_mbox __iomem
> *mbox)
> > u32 tmp, expected;
> >
> > /* Expect mbox_cmd to be cleared and ready bit to be set by PSP */
> > - expected = FIELD_PREP(PSP_MBOX_FIELDS_READY, 1);
> > + expected = FIELD_PREP(PSP_CMDRESP_RESP, 1);
>
> What's the meaning of "PSP_CMDRESP_RESP"? I see that this new macro
> name is currently used by other drivers, but in my opinion "READY" is
> more descriptive. (It is also aligned to the comment above this line.)
It should indicate that the PSP has responded. I think both terms work
to describe what's going on.
Tom - What's your preference?
I'll either adjust all the drivers to use READY or fix the comment for v2.
next prev parent reply other threads:[~2023-02-14 22:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 22:38 [PATCH 0/6] Export platform features from ccp driver Mario Limonciello
2023-02-09 22:38 ` [PATCH 1/6] crypto: ccp: Drop TEE support for IRQ handler Mario Limonciello
2023-02-09 22:38 ` [PATCH 2/6] crypto: ccp: Add a header for multiple drivers to use `__psp_pa` Mario Limonciello
2023-02-14 8:40 ` Jan Dąbroś
2023-02-15 11:13 ` Jarkko Nikula
2023-02-15 11:13 ` Sumit Garg
2023-02-09 22:38 ` [PATCH 3/6] crypto: ccp: Move some PSP mailbox bit definitions into common header Mario Limonciello
2023-02-14 9:04 ` Jan Dąbroś
2023-02-14 22:05 ` Limonciello, Mario [this message]
2023-02-16 14:23 ` Tom Lendacky
2023-02-09 22:38 ` [PATCH 4/6] crypto: ccp: Add support for an interface for platform features Mario Limonciello
2023-02-09 22:38 ` [PATCH 5/6] crypto: ccp: Enable platform access interface on client PSP parts Mario Limonciello
2023-02-09 22:38 ` [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-02-10 10:43 ` Andy Shevchenko
2023-02-16 13:27 ` Jarkko Nikula
2023-02-16 13:29 ` Mario Limonciello
2023-02-16 14:56 ` Andy Shevchenko
2023-02-16 20:55 ` Limonciello, Mario
2023-02-16 20:59 ` Andy Shevchenko
2023-02-16 21:01 ` Limonciello, Mario
2023-02-16 21:16 ` Andy Shevchenko
2023-02-16 21:27 ` Limonciello, Mario
2023-02-17 11:05 ` Andy Shevchenko
2023-02-17 11:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB61017A594AF2CCD1D75EC798E2A29@MN0PR12MB6101.namprd12.prod.outlook.com \
--to=mario.limonciello@amd.com \
--cc=Brijesh.Singh@amd.com \
--cc=John.Allen@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=gjb@semihalf.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).