From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Bernacki" <gjb@semihalf.com>,
"Thomas Rijo-john" <Rijo-john.Thomas@amd.com>,
"Lendacky Thomas" <Thomas.Lendacky@amd.com>,
herbert@gondor.apana.org.au,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication
Date: Fri, 10 Feb 2023 12:43:22 +0200 [thread overview]
Message-ID: <Y+YfyiERB80bHE1Y@smile.fi.intel.com> (raw)
In-Reply-To: <20230209223811.4993-7-mario.limonciello@amd.com>
On Thu, Feb 09, 2023 at 04:38:08PM -0600, Mario Limonciello wrote:
> Currently the PSP semaphore communication base address is discovered
> by using an MSR that is not architecturally guaranteed for future
> platforms. Also the mailbox that is utilized for communication with
> the PSP may have other consumers in the kernel, so it's better to
> make all communication go through a single driver.
...
> #if IS_ENABLED(CONFIG_I2C_DESIGNWARE_AMDPSP)
> int i2c_dw_amdpsp_probe_lock_support(struct dw_i2c_dev *dev);
> -void i2c_dw_amdpsp_remove_lock_support(struct dw_i2c_dev *dev);
> #endif
...
> #ifdef CONFIG_I2C_DESIGNWARE_AMDPSP
> {
> .probe = i2c_dw_amdpsp_probe_lock_support,
> - .remove = i2c_dw_amdpsp_remove_lock_support,
> },
> #endif
Personally I found better to have empty stub for the sake of symmetry of API.
But at the end it's not my decision, just felt that I have to express this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-10 10:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 22:38 [PATCH 0/6] Export platform features from ccp driver Mario Limonciello
2023-02-09 22:38 ` [PATCH 1/6] crypto: ccp: Drop TEE support for IRQ handler Mario Limonciello
2023-02-09 22:38 ` [PATCH 2/6] crypto: ccp: Add a header for multiple drivers to use `__psp_pa` Mario Limonciello
2023-02-14 8:40 ` Jan Dąbroś
2023-02-15 11:13 ` Jarkko Nikula
2023-02-15 11:13 ` Sumit Garg
2023-02-09 22:38 ` [PATCH 3/6] crypto: ccp: Move some PSP mailbox bit definitions into common header Mario Limonciello
2023-02-14 9:04 ` Jan Dąbroś
2023-02-14 22:05 ` Limonciello, Mario
2023-02-16 14:23 ` Tom Lendacky
2023-02-09 22:38 ` [PATCH 4/6] crypto: ccp: Add support for an interface for platform features Mario Limonciello
2023-02-09 22:38 ` [PATCH 5/6] crypto: ccp: Enable platform access interface on client PSP parts Mario Limonciello
2023-02-09 22:38 ` [PATCH 6/6] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-02-10 10:43 ` Andy Shevchenko [this message]
2023-02-16 13:27 ` Jarkko Nikula
2023-02-16 13:29 ` Mario Limonciello
2023-02-16 14:56 ` Andy Shevchenko
2023-02-16 20:55 ` Limonciello, Mario
2023-02-16 20:59 ` Andy Shevchenko
2023-02-16 21:01 ` Limonciello, Mario
2023-02-16 21:16 ` Andy Shevchenko
2023-02-16 21:27 ` Limonciello, Mario
2023-02-17 11:05 ` Andy Shevchenko
2023-02-17 11:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+YfyiERB80bHE1Y@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=gjb@semihalf.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).