From: Avri Altman <Avri.Altman@wdc.com>
To: Can Guo <cang@codeaurora.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"saravanak@google.com" <saravanak@google.com>,
"salyzyn@google.com" <salyzyn@google.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bean Huo <beanhuo@micron.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 3/7] scsi: ufs: Fix up auto hibern8 enablement
Date: Thu, 14 Nov 2019 09:23:08 +0000 [thread overview]
Message-ID: <MN2PR04MB69913B9DBCEE72322A741F14FC710@MN2PR04MB6991.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1573627552-12615-4-git-send-email-cang@codeaurora.org>
>
>
> Fix up possible unclocked register access to auto hibern8 register in resume path
> and through sysfs entry. Meanwhile, enable auto hibern8 only after device is
> fully initialized in probe path.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
Acked-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufs-sysfs.c | 17 +++++++++++------
> drivers/scsi/ufs/ufshcd.c | 12 ++++++------
> 2 files changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c index
> 969a36b..6c2f19e 100644
> --- a/drivers/scsi/ufs/ufs-sysfs.c
> +++ b/drivers/scsi/ufs/ufs-sysfs.c
> @@ -126,13 +126,18 @@ static void ufshcd_auto_hibern8_update(struct
> ufs_hba *hba, u32 ahit)
> return;
>
> spin_lock_irqsave(hba->host->host_lock, flags);
> - if (hba->ahit == ahit)
> - goto out_unlock;
> - hba->ahit = ahit;
> - if (!pm_runtime_suspended(hba->dev))
> - ufshcd_writel(hba, hba->ahit, REG_AUTO_HIBERNATE_IDLE_TIMER);
> -out_unlock:
> + if (hba->ahit != ahit)
> + hba->ahit = ahit;
> spin_unlock_irqrestore(hba->host->host_lock, flags);
> + if (!pm_runtime_suspended(hba->dev)) {
> + pm_runtime_get_sync(hba->dev);
> + ufshcd_hold(hba, false);
> + spin_lock_irqsave(hba->host->host_lock, flags);
> + ufshcd_writel(hba, hba->ahit, REG_AUTO_HIBERNATE_IDLE_TIMER);
> + spin_unlock_irqrestore(hba->host->host_lock, flags);
Call ufshcd_auto_hibern8_enable instead of open coding?
> + ufshcd_release(hba);
> + pm_runtime_put(hba->dev);
> + }
> }
>
> /* Convert Auto-Hibernate Idle Timer register value to microseconds */ diff --git
> a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 525f8e6..f12f5a7
> 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6892,9 +6892,6 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
> /* UniPro link is active now */
> ufshcd_set_link_active(hba);
>
> - /* Enable Auto-Hibernate if configured */
> - ufshcd_auto_hibern8_enable(hba);
> -
> ret = ufshcd_verify_dev_init(hba);
> if (ret)
> goto out;
> @@ -6945,6 +6942,9 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
> /* set the state as operational after switching to desired gear */
> hba->ufshcd_state = UFSHCD_STATE_OPERATIONAL;
>
> + /* Enable Auto-Hibernate if configured */
> + ufshcd_auto_hibern8_enable(hba);
> +
> /*
> * If we are in error handling context or in power management callbacks
> * context, no need to scan the host @@ -7962,12 +7962,12 @@ static int
> ufshcd_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> if (hba->clk_scaling.is_allowed)
> ufshcd_resume_clkscaling(hba);
>
> - /* Schedule clock gating in case of no access to UFS device yet */
> - ufshcd_release(hba);
> -
> /* Enable Auto-Hibernate if configured */
> ufshcd_auto_hibern8_enable(hba);
>
> + /* Schedule clock gating in case of no access to UFS device yet */
> + ufshcd_release(hba);
> +
> goto out;
>
> set_old_link_state:
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-11-14 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573627552-12615-1-git-send-email-cang@codeaurora.org>
2019-11-13 6:45 ` [PATCH v4 1/7] scsi: ufs: Add device reset in link recovery path Can Guo
2019-11-13 6:45 ` [PATCH v4 2/7] scsi: ufs-qcom: Add reset control support for host controller Can Guo
2019-11-14 9:03 ` Avri Altman
2019-11-15 1:25 ` Can Guo
2019-11-13 6:45 ` [PATCH v4 3/7] scsi: ufs: Fix up auto hibern8 enablement Can Guo
2019-11-14 9:23 ` Avri Altman [this message]
2019-11-15 3:33 ` Can Guo
2019-11-13 6:45 ` [PATCH v4 4/7] scsi: ufs: Fix register dump caused sleep in atomic context Can Guo
2019-11-13 6:45 ` [PATCH v4 5/7] scsi: ufs: Fix irq return code Can Guo
2019-11-14 10:43 ` Avri Altman
2019-11-13 6:45 ` [PATCH v4 6/7] scsi: ufs: Abort gating if clock on request is pending Can Guo
2019-11-14 10:46 ` Avri Altman
2019-11-13 6:45 ` [PATCH v4 7/7] scsi: ufs: Fix error handing during hibern8 enter Can Guo
2019-11-14 11:06 ` Avri Altman
2019-11-15 1:33 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR04MB69913B9DBCEE72322A741F14FC710@MN2PR04MB6991.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).