From: Avri Altman <Avri.Altman@wdc.com>
To: Can Guo <cang@codeaurora.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"saravanak@google.com" <saravanak@google.com>,
"salyzyn@google.com" <salyzyn@google.com>
Cc: Andy Gross <agross@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 2/7] scsi: ufs-qcom: Add reset control support for host controller
Date: Thu, 14 Nov 2019 09:03:13 +0000 [thread overview]
Message-ID: <MN2PR04MB69918A580EC558ECF3FB2748FC710@MN2PR04MB6991.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1573627552-12615-3-git-send-email-cang@codeaurora.org>
Hi,
>
>
> Add reset control for host controller so that host controller can be reset as
> required in its power up sequence.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> + ret = reset_control_assert(host->core_reset);
> + if (ret) {
> + dev_err(hba->dev, "%s: core_reset assert failed, err = %d\n",
> + __func__, ret);
> + goto out;
> + }
> +
> + /*
> + * The hardware requirement for delay between assert/deassert
> + * is at least 3-4 sleep clock (32.7KHz) cycles, which comes to
> + * ~125us (4/32768). To be on the safe side add 200us delay.
> + */
> + usleep_range(200, 210);
Aren't you sleeping anyway in your reset_control_ops?
> +
> + ret = reset_control_deassert(host->core_reset);
> + if (ret)
> + dev_err(hba->dev, "%s: core_reset deassert failed, err = %d\n",
> + __func__, ret);
> +
> + usleep_range(1000, 1100);
ditto
next prev parent reply other threads:[~2019-11-14 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573627552-12615-1-git-send-email-cang@codeaurora.org>
2019-11-13 6:45 ` [PATCH v4 1/7] scsi: ufs: Add device reset in link recovery path Can Guo
2019-11-13 6:45 ` [PATCH v4 2/7] scsi: ufs-qcom: Add reset control support for host controller Can Guo
2019-11-14 9:03 ` Avri Altman [this message]
2019-11-15 1:25 ` Can Guo
2019-11-13 6:45 ` [PATCH v4 3/7] scsi: ufs: Fix up auto hibern8 enablement Can Guo
2019-11-14 9:23 ` Avri Altman
2019-11-15 3:33 ` Can Guo
2019-11-13 6:45 ` [PATCH v4 4/7] scsi: ufs: Fix register dump caused sleep in atomic context Can Guo
2019-11-13 6:45 ` [PATCH v4 5/7] scsi: ufs: Fix irq return code Can Guo
2019-11-14 10:43 ` Avri Altman
2019-11-13 6:45 ` [PATCH v4 6/7] scsi: ufs: Abort gating if clock on request is pending Can Guo
2019-11-14 10:46 ` Avri Altman
2019-11-13 6:45 ` [PATCH v4 7/7] scsi: ufs: Fix error handing during hibern8 enter Can Guo
2019-11-14 11:06 ` Avri Altman
2019-11-15 1:33 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR04MB69918A580EC558ECF3FB2748FC710@MN2PR04MB6991.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).