From: Thomas Hellstrom <thellstrom@vmware.com>
To: "Dave Hansen" <dave.hansen@intel.com>,
"Thomas Hellström (VMware)" <thomas_os@shipmail.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Pv-drivers <Pv-drivers@vmware.com>,
Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
"x86@kernel.org" <x86@kernel.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Christian König" <christian.koenig@amd.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page encryption bit
Date: Tue, 1 Oct 2019 05:54:22 +0000 [thread overview]
Message-ID: <MN2PR05MB61416C02E95D28652B432BB7A19D0@MN2PR05MB6141.namprd05.prod.outlook.com> (raw)
In-Reply-To: d893ef47-443e-0759-8f1e-d496a4ad3dfd@intel.com
Hi,
On 9/18/19 7:57 PM, Dave Hansen wrote:
> On 9/17/19 6:01 AM, Thomas Hellström (VMware) wrote:
>> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
>> index b5e49e6bac63..8267dd426b15 100644
>> --- a/arch/x86/include/asm/pgtable_types.h
>> +++ b/arch/x86/include/asm/pgtable_types.h
>> @@ -123,7 +123,7 @@
>> */
>> #define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | \
>> _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY | \
>> - _PAGE_SOFT_DIRTY | _PAGE_DEVMAP)
>> + _PAGE_SOFT_DIRTY | _PAGE_DEVMAP | _PAGE_ENC)
>> #define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE)
> My only nit with what remains is that it expands the infestation of
> things that look like a simple macro but are not.
>
> I'm debating whether we want to go fix that now, though.
>
Any chance for an ack on this? It's really a small change that, as we've
found out, fixes an existing problem.
Thanks,
Thomas
next prev parent reply other threads:[~2019-10-01 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 13:01 [PATCH v3 0/2] Fix SEV user-space mapping of unencrypted coherent memory Thomas Hellström (VMware)
2019-09-17 13:01 ` [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page encryption bit Thomas Hellström (VMware)
2019-09-18 17:57 ` Dave Hansen
2019-10-01 5:54 ` Thomas Hellstrom [this message]
2019-10-01 16:07 ` Dave Hansen
2019-09-17 13:01 ` [PATCH v3 2/2] dma-mapping: Fix dma_pgprot() for unencrypted coherent pages Thomas Hellström (VMware)
2019-09-18 13:39 ` [PATCH v3 0/2] Fix SEV user-space mapping of unencrypted coherent memory Christoph Hellwig
2020-03-04 11:45 [PATCH v4 " Thomas Hellström (VMware)
2020-03-04 11:45 ` [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page encryption bit Thomas Hellström (VMware)
2020-03-16 19:43 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR05MB61416C02E95D28652B432BB7A19D0@MN2PR05MB6141.namprd05.prod.outlook.com \
--to=thellstrom@vmware.com \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=Pv-drivers@vmware.com \
--cc=bp@alien8.de \
--cc=christian.koenig@amd.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=thomas_os@shipmail.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).