* [PATCH -next] qed: Make ll2_cbs static
@ 2020-04-23 7:27 Zou Wei
2020-04-23 7:44 ` [EXT] " Michal Kalderon
2020-04-23 22:54 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-23 7:27 UTC (permalink / raw)
To: aelior, GR-everest-linux-l2, davem; +Cc: netdev, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 037e597..4afd857 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -2331,7 +2331,7 @@ static void qed_ll2_register_cb_ops(struct qed_dev *cdev,
cdev->ll2->cb_cookie = cookie;
}
-struct qed_ll2_cbs ll2_cbs = {
+static struct qed_ll2_cbs ll2_cbs = {
.rx_comp_cb = &qed_ll2b_complete_rx_packet,
.rx_release_cb = &qed_ll2b_release_rx_packet,
.tx_comp_cb = &qed_ll2b_complete_tx_packet,
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH -next] qed: Make ll2_cbs static
2020-04-23 7:27 [PATCH -next] qed: Make ll2_cbs static Zou Wei
@ 2020-04-23 7:44 ` Michal Kalderon
2020-04-23 22:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michal Kalderon @ 2020-04-23 7:44 UTC (permalink / raw)
To: Zou Wei, Ariel Elior, GR-everest-linux-l2, davem; +Cc: netdev, linux-kernel
> From: Zou Wei <zou_wei@huawei.com>
> Sent: Thursday, April 23, 2020 10:28 AM
>
> ----------------------------------------------------------------------
> Fix the following sparse warning:
>
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> index 037e597..4afd857 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> @@ -2331,7 +2331,7 @@ static void qed_ll2_register_cb_ops(struct qed_dev
> *cdev,
> cdev->ll2->cb_cookie = cookie;
> }
>
> -struct qed_ll2_cbs ll2_cbs = {
> +static struct qed_ll2_cbs ll2_cbs = {
> .rx_comp_cb = &qed_ll2b_complete_rx_packet,
> .rx_release_cb = &qed_ll2b_release_rx_packet,
> .tx_comp_cb = &qed_ll2b_complete_tx_packet,
> --
> 2.6.2
Thanks,
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] qed: Make ll2_cbs static
2020-04-23 7:27 [PATCH -next] qed: Make ll2_cbs static Zou Wei
2020-04-23 7:44 ` [EXT] " Michal Kalderon
@ 2020-04-23 22:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-23 22:54 UTC (permalink / raw)
To: zou_wei; +Cc: aelior, GR-everest-linux-l2, netdev, linux-kernel
From: Zou Wei <zou_wei@huawei.com>
Date: Thu, 23 Apr 2020 15:27:40 +0800
> Fix the following sparse warning:
>
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_cbs'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-23 22:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 7:27 [PATCH -next] qed: Make ll2_cbs static Zou Wei
2020-04-23 7:44 ` [EXT] " Michal Kalderon
2020-04-23 22:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).