* [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c
@ 2019-10-09 15:49 Randy Dunlap
2019-10-17 16:16 ` Pascal Van Leeuwen
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-10-09 15:49 UTC (permalink / raw)
To: LKML, Linux Crypto Mailing List; +Cc: Antoine Tenart, Herbert Xu, David Miller
From: Randy Dunlap <rdunlap@infradead.org>
safexcel_hash.c (CRYPTO_DEV_SAFEXCEL) needs to select CRYPTO_SM3.
Fixes this build error:
safexcel_hash.c:(.text+0x1b17): undefined reference to `sm3_zero_message_hash'
Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20191009.orig/drivers/crypto/Kconfig
+++ linux-next-20191009/drivers/crypto/Kconfig
@@ -751,6 +751,7 @@ config CRYPTO_DEV_SAFEXCEL
select CRYPTO_SHA512
select CRYPTO_CHACHA20POLY1305
select CRYPTO_SHA3
+ select CRYPTO_SM3
help
This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic
engines designed by Inside Secure. It currently accelerates DES, 3DES and
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c
2019-10-09 15:49 [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c Randy Dunlap
@ 2019-10-17 16:16 ` Pascal Van Leeuwen
0 siblings, 0 replies; 2+ messages in thread
From: Pascal Van Leeuwen @ 2019-10-17 16:16 UTC (permalink / raw)
To: Randy Dunlap, LKML, Linux Crypto Mailing List
Cc: Antoine Tenart, Herbert Xu, David Miller
> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of
> Randy Dunlap
> Sent: Wednesday, October 9, 2019 5:50 PM
> To: LKML <linux-kernel@vger.kernel.org>; Linux Crypto Mailing List <linux-
> crypto@vger.kernel.org>
> Cc: Antoine Tenart <antoine.tenart@free-electrons.com>; Herbert Xu
> <herbert@gondor.apana.org.au>; David Miller <davem@davemloft.net>
> Subject: [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> safexcel_hash.c (CRYPTO_DEV_SAFEXCEL) needs to select CRYPTO_SM3.
>
> Fixes this build error:
>
> safexcel_hash.c:(.text+0x1b17): undefined reference to `sm3_zero_message_hash'
>
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20191009.orig/drivers/crypto/Kconfig
> +++ linux-next-20191009/drivers/crypto/Kconfig
> @@ -751,6 +751,7 @@ config CRYPTO_DEV_SAFEXCEL
> select CRYPTO_SHA512
> select CRYPTO_CHACHA20POLY1305
> select CRYPTO_SHA3
> + select CRYPTO_SM3
> help
> This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic
> engines designed by Inside Secure. It currently accelerates DES, 3DES and
>
I'm spinning a patch to fix this without having to
actually build in the SM3 module. So NACK on this patch.
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-17 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 15:49 [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c Randy Dunlap
2019-10-17 16:16 ` Pascal Van Leeuwen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).