From: "Moger, Babu" <Babu.Moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>
Cc: "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"paulmck@kernel.org" <paulmck@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"damien.lemoal@opensource.wdc.com"
<damien.lemoal@opensource.wdc.com>,
"songmuchun@bytedance.com" <songmuchun@bytedance.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
"pawan.kumar.gupta@linux.intel.com"
<pawan.kumar.gupta@linux.intel.com>,
"jmattson@google.com" <jmattson@google.com>,
"daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
"Das1, Sandipan" <Sandipan.Das@amd.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bagasdotme@gmail.com" <bagasdotme@gmail.com>,
"eranian@google.com" <eranian@google.com>
Subject: RE: [PATCH v8 02/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA
Date: Wed, 23 Nov 2022 15:13:14 +0000 [thread overview]
Message-ID: <MW3PR12MB45536E741C80000FCF96EE72950C9@MW3PR12MB4553.namprd12.prod.outlook.com> (raw)
In-Reply-To: <9ecad0af-c801-1638-c658-6823e4ddf483@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]
[AMD Official Use Only - General]
Hi Reinette,
> -----Original Message-----
> From: Reinette Chatre <reinette.chatre@intel.com>
> Sent: Tuesday, November 22, 2022 6:05 PM
> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
> hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
> quic_neeraju@quicinc.com; rdunlap@infradead.org;
> damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
> peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
> chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
> bagasdotme@gmail.com; eranian@google.com
> Subject: Re: [PATCH v8 02/13] x86/resctrl: Add a new resource type
> RDT_RESOURCE_SMBA
>
> Hi Babu,
>
> On 11/4/2022 1:00 PM, Babu Moger wrote:
> > Add a new resource type RDT_RESOURCE_SMBA to handle the QoS
> > enforcement policies on the external slow memory.
> >
> > Signed-off-by: Babu Moger <babu.moger@amd.com>
> > Reviewed-by: Ingo Molnar <mingo@kernel.org>
> > ---
> > arch/x86/kernel/cpu/resctrl/core.c | 12 ++++++++++++
> > arch/x86/kernel/cpu/resctrl/internal.h | 1 +
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/arch/x86/kernel/cpu/resctrl/core.c
> > b/arch/x86/kernel/cpu/resctrl/core.c
> > index 03cfbf0fe000..4b970e7192e8 100644
> > --- a/arch/x86/kernel/cpu/resctrl/core.c
> > +++ b/arch/x86/kernel/cpu/resctrl/core.c
> > @@ -100,6 +100,18 @@ struct rdt_hw_resource rdt_resources_all[] = {
> > .fflags = RFTYPE_RES_MB,
> > },
> > },
> > + [RDT_RESOURCE_SMBA] =
> > + {
> > + .r_resctrl = {
> > + .rid = RDT_RESOURCE_SMBA,
> > + .name = "SMBA",
> > + .cache_level = 3,
> > + .domains =
> domain_init(RDT_RESOURCE_SMBA),
> > + .parse_ctrlval = parse_bw,
> > + .format_str = "%d=%*u",
> > + .fflags = RFTYPE_RES_MB,
> > + },
> > + },
> > };
> >
>
> Looking ahead at patch #5, I think that the initialization of msr_base and
> msr_update (in rdt_init_res_defs_amd()) can be moved here also.
Sure. Will do.
Thanks
Babu
>
> > /*
> > diff --git a/arch/x86/kernel/cpu/resctrl/internal.h
> > b/arch/x86/kernel/cpu/resctrl/internal.h
> > index 5f7128686cfd..43d9f6f5a931 100644
> > --- a/arch/x86/kernel/cpu/resctrl/internal.h
> > +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> > @@ -419,6 +419,7 @@ enum resctrl_res_level {
> > RDT_RESOURCE_L3,
> > RDT_RESOURCE_L2,
> > RDT_RESOURCE_MBA,
> > + RDT_RESOURCE_SMBA,
> >
> > /* Must be the last */
> > RDT_NUM_RESOURCES,
> >
> >
>
> Reinette
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 18380 bytes --]
next prev parent reply other threads:[~2022-11-23 15:13 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 19:59 [PATCH v8 00/13] Support for AMD QoS new features Babu Moger
2022-11-04 19:59 ` [PATCH v8 01/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2022-11-23 18:21 ` Yu, Fenghua
2022-11-23 23:09 ` Moger, Babu
2022-11-04 20:00 ` [PATCH v8 02/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2022-11-23 0:04 ` Reinette Chatre
2022-11-23 15:13 ` Moger, Babu [this message]
2022-11-04 20:00 ` [PATCH v8 03/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2022-11-23 0:09 ` Reinette Chatre
2022-11-23 15:16 ` Moger, Babu
2022-11-23 18:17 ` Yu, Fenghua
2022-11-23 23:06 ` Moger, Babu
2022-11-04 20:00 ` [PATCH v8 04/13] x86/resctrl: Include new features in command line options Babu Moger
2022-11-23 18:26 ` Yu, Fenghua
2022-11-23 23:10 ` Moger, Babu
2022-11-04 20:00 ` [PATCH v8 05/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2022-11-23 0:12 ` Reinette Chatre
2022-11-23 15:17 ` Moger, Babu
2022-11-30 18:43 ` Moger, Babu
2022-11-30 20:07 ` Reinette Chatre
2022-11-30 20:40 ` Moger, Babu
2022-12-01 0:35 ` Reinette Chatre
2022-12-01 13:56 ` Moger, Babu
2022-11-04 20:00 ` [PATCH v8 06/13] x86/resctrl: Remove the init attribute for rdt_cpu_has() Babu Moger
2022-11-23 0:13 ` Reinette Chatre
2022-11-23 17:48 ` Moger, Babu
2022-11-04 20:00 ` [PATCH v8 07/13] x86/resctrl: Introduce data structure to support monitor configuration Babu Moger
2022-11-23 0:14 ` Reinette Chatre
2022-11-23 18:23 ` Moger, Babu
2022-11-23 19:05 ` Reinette Chatre
2022-11-23 21:46 ` Moger, Babu
2022-11-04 20:00 ` [PATCH v8 08/13] x86/resctrl: Add sysfs interface to read mbm_total_bytes_config Babu Moger
2022-11-23 0:19 ` Reinette Chatre
2022-11-23 18:35 ` Moger, Babu
2022-11-23 22:27 ` Reinette Chatre
2022-11-23 22:55 ` Moger, Babu
2022-11-04 20:01 ` [PATCH v8 09/13] x86/resctrl: Add sysfs interface to read mbm_local_bytes_config Babu Moger
2022-11-04 20:01 ` [PATCH v8 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes_config Babu Moger
2022-11-07 10:21 ` Peter Newman
2022-11-07 18:50 ` Moger, Babu
2022-11-07 19:00 ` Moger, Babu
2022-11-22 23:43 ` Reinette Chatre
2022-11-23 21:44 ` Moger, Babu
2022-11-23 22:22 ` Reinette Chatre
2022-11-28 16:01 ` Moger, Babu
2022-11-23 0:22 ` Reinette Chatre
2022-11-23 22:44 ` Moger, Babu
2022-12-07 17:20 ` James Morse
2022-12-07 17:24 ` James Morse
2022-12-08 0:02 ` Moger, Babu
2022-12-13 17:55 ` James Morse
2022-12-13 23:46 ` Moger, Babu
2022-11-04 20:01 ` [PATCH v8 11/13] x86/resctrl: Add sysfs interface to write mbm_local_bytes_config Babu Moger
2022-11-04 20:01 ` [PATCH v8 12/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2022-11-04 20:01 ` [PATCH v8 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2022-11-23 0:26 ` Reinette Chatre
2022-11-23 23:02 ` Moger, Babu
2022-11-15 20:50 ` [PATCH v8 00/13] Support for AMD QoS " Moger, Babu
2022-11-15 21:07 ` Reinette Chatre
2022-11-15 21:34 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR12MB45536E741C80000FCF96EE72950C9@MW3PR12MB4553.namprd12.prod.outlook.com \
--to=babu.moger@amd.com \
--cc=Sandipan.Das@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).