* Possible bug in sc16is7xx UART driver
@ 2023-01-23 18:52 Wall, Stephen
0 siblings, 0 replies; only message in thread
From: Wall, Stephen @ 2023-01-23 18:52 UTC (permalink / raw)
To: linux-kernel
I believe there is a bug in the startup function of the sc16is7xx driver code. I've forked the repo and made changes with a descriptive comment here: https://github.com/torvalds/linux/commit/7a9c8f240efa4d3d49ab5b52ac1cfbe79a701acb
To summarize here, the data sheet for the part says that the MCR register can only be accessed when LCR[0] is cleared, and the function was attempting to access it with LCR set to 0xbf.
Note that I am not currently using linux, and don't have hardware to test this on. I found it as a result of searching for code to compare with a local driver implementation on FreeBSD running on custom hardware.
Please CC me as I get failures when trying to subscribe to the list.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-23 18:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 18:52 Possible bug in sc16is7xx UART driver Wall, Stephen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).