* [PATCH v2] MIPS: generic: Use __initconst for const init data
@ 2019-10-08 16:15 Tiezhu Yang
2019-10-08 17:55 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2019-10-08 16:15 UTC (permalink / raw)
To: paul.burton, ralf, jhogan; +Cc: linux-mips, linux-kernel
Fix the following checkpatch errors:
$ ./scripts/checkpatch.pl --no-tree -f arch/mips/generic/init.c
ERROR: Use of const init definition must use __initconst
#23: FILE: arch/mips/generic/init.c:23:
+static __initdata const void *fdt;
ERROR: Use of const init definition must use __initconst
#24: FILE: arch/mips/generic/init.c:24:
+static __initdata const struct mips_machine *mach;
ERROR: Use of const init definition must use __initconst
#25: FILE: arch/mips/generic/init.c:25:
+static __initdata const void *mach_match_data;
Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
v2: update the commit message and use the 'Fixes:' tag
arch/mips/generic/init.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/mips/generic/init.c b/arch/mips/generic/init.c
index d5b8c47..1de215b 100644
--- a/arch/mips/generic/init.c
+++ b/arch/mips/generic/init.c
@@ -20,9 +20,9 @@
#include <asm/smp-ops.h>
#include <asm/time.h>
-static __initdata const void *fdt;
-static __initdata const struct mips_machine *mach;
-static __initdata const void *mach_match_data;
+static __initconst const void *fdt;
+static __initconst const struct mips_machine *mach;
+static __initconst const void *mach_match_data;
void __init prom_init(void)
{
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] MIPS: generic: Use __initconst for const init data
2019-10-08 16:15 [PATCH v2] MIPS: generic: Use __initconst for const init data Tiezhu Yang
@ 2019-10-08 17:55 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-10-08 17:55 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Paul Burton, ralf, jhogan, linux-mips, linux-kernel, linux-mips
Hello,
Tiezhu Yang wrote:
> Fix the following checkpatch errors:
>
> $ ./scripts/checkpatch.pl --no-tree -f arch/mips/generic/init.c
> ERROR: Use of const init definition must use __initconst
> #23: FILE: arch/mips/generic/init.c:23:
> +static __initdata const void *fdt;
>
> ERROR: Use of const init definition must use __initconst
> #24: FILE: arch/mips/generic/init.c:24:
> +static __initdata const struct mips_machine *mach;
>
> ERROR: Use of const init definition must use __initconst
> #25: FILE: arch/mips/generic/init.c:25:
> +static __initdata const void *mach_match_data;
Applied to mips-next.
> commit a14bf1dc494a
> https://git.kernel.org/mips/c/a14bf1dc494a
>
> Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Signed-off-by: Paul Burton <paul.burton@mips.com>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 16:15 [PATCH v2] MIPS: generic: Use __initconst for const init data Tiezhu Yang
2019-10-08 17:55 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).