Re: [PATCH 3/5] ACPI: battery: Allow battery hooks to be registered multiple times.

From: "Barnabás Pőcze" <pobrn@protonmail.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: hdegoede@redhat.com, markgross@kernel.org, rafael@kernel.org,
	lenb@kernel.org, hmh@hmh.eng.br, matan@svgalib.org,
	corentin.chary@gmail.com, jeremy@system76.com,
	productdev@system76.com, platform-driver-x86@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ACPI: battery: Allow battery hooks to be registered multiple times.
Date: Mon, 19 Sep 2022 17:42:21 +0000	[thread overview]
Message-ID: <NPN9qozoyFasUKS8WoJ8ZBuQcrF0-7SfN4Kky2xzCEvKpanHWJIPvNLBEMbGRIDV8gwyjh4xjQgucgItcCpqz4VwaawwjAFhjwOQE_6Tggs=@protonmail.com> (raw)
In-Reply-To: <155062a9-8d1a-e771-1bee-35580b1b2b73@gmx.de>

Hi

2022. szeptember 12., hétfő 19:29 keltezéssel, Armin Wolf <W_Armin@gmx.de> írta:

> Am 12.09.22 um 18:42 schrieb Barnabás Pőcze:
> 
> > Hi
> > 
> > 2022. szeptember 12., hétfő 14:53 keltezéssel, Armin Wolf írta:
> > 
> > > Registering multiple instances of a battery hook is beneficial
> > > for drivers which can be instantiated multiple times. Until now,
> > > this would mean that such a driver would have to implement some
> > > logic to manage battery hooks.
> > > 
> > > Extend the battery hook handling instead.
> > > I think this is already possible by embedding the acpi_battery_hook
> > > object inside the driver's device specific data object, no?
> > 
> > Regards,
> > Barnabás Pőcze
> 
> Yes, it indeed is. However afaik it is not possible to pass instance-specific
> data to such an embedded battery hook. It could be possible by passing the
> battery hook as an argument to add_battery()/remove_battery() and using container_of(),
> but in my opinion this would be too much of a quick hack.

Good point about the instance-specific data. However, regarding the second point,
I am with Hans. I do not really think it is that big of a hack. It is inheritance.

Regards,
Barnabás Pőcze