From: Sven Schuchmann <schuchmann@schleissheimer.de>
To: Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Cc: Woojung Huh <woojung.huh@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available
Date: Sat, 27 Nov 2021 10:36:53 +0000 [thread overview]
Message-ID: <PA4P190MB1390D5F29BEAF13BC3B25097D9649@PA4P190MB1390.EURP190.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20211126113440.5463ff74@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hello Jakub,
> Von: Jakub Kicinski <kuba@kernel.org>
> Gesendet: Freitag, 26. November 2021 20:35
> An: Andrew Lunn <andrew@lunn.ch>; Sven Schuchmann <schuchmann@schleissheimer.de>
> Cc: Woojung Huh <woojung.huh@microchip.com>; UNGLinuxDriver@microchip.com; David S. Miller
> <davem@davemloft.net>; netdev@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Betreff: Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if
> no IRQ is available
>
> On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote:
> > On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote:
> > > On most systems request for IRQ 0 will fail, phylib will print an error message
> > > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
> > > is available.
> > >
> > > Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
>
> right?
Seems right, will send a v2
Sven
prev parent reply other threads:[~2021-11-27 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 15:20 [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available Sven Schuchmann
[not found] ` <YaED/p7O0iYQF6bW@lunn.ch>
2021-11-26 19:34 ` Jakub Kicinski
2021-11-27 10:36 ` Sven Schuchmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4P190MB1390D5F29BEAF13BC3B25097D9649@PA4P190MB1390.EURP190.PROD.OUTLOOK.COM \
--to=schuchmann@schleissheimer.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).