[PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

[PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

[Sven Schuchmann]

On most systems request for IRQ 0 will fail, phylib will print an error message
and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
is available.

Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
---
 drivers/net/usb/lan78xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 2bfb59ae0eaf..185e08c1af31 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2398,7 +2398,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
 	if (dev->domain_data.phyirq > 0)
 		phydev->irq = dev->domain_data.phyirq;
 	else
-		phydev->irq = 0;
+		phydev->irq = PHY_POLL;
 	netdev_dbg(dev->net, "phydev->irq = %d\n", phydev->irq);
 
 	/* set to AUTOMDIX */
-- 
2.17.1

Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

[Jakub Kicinski]

On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote:
> On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote:
> > On most systems request for IRQ 0 will fail, phylib will print an error message
> > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
> > is available.
> > 
> > Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>  
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")

right?

AW: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

[Sven Schuchmann]

Hello Jakub,

> Von: Jakub Kicinski <kuba@kernel.org>
> Gesendet: Freitag, 26. November 2021 20:35
> An: Andrew Lunn <andrew@lunn.ch>; Sven Schuchmann <schuchmann@schleissheimer.de>
> Cc: Woojung Huh <woojung.huh@microchip.com>; UNGLinuxDriver@microchip.com; David S. Miller
> <davem@davemloft.net>; netdev@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Betreff: Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if
> no IRQ is available
> 
> On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote:
> > On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote:
> > > On most systems request for IRQ 0 will fail, phylib will print an error message
> > > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
> > > is available.
> > >
> > > Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
> Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
> 
> right?

Seems right, will send a v2

Sven