* [PATCH v2 1/6] staging: octeon: clean up the octeon ethernet driver
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
@ 2023-08-27 23:25 ` Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 2/6] " Oliver Crumrine
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: Oliver Crumrine @ 2023-08-27 23:25 UTC (permalink / raw)
To: gregkh, colin.i.king, sumitraartsy, u.kleine-koenig, geert
Cc: Oliver Crumrine, linux-kernel, linux-staging
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
v2: Actually send the patch set correctly
drivers/staging/octeon/octeon-stubs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 3e7b92cd2e35..9f269626b862 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -213,12 +213,12 @@ enum cvmx_fau_op_size {
CVMX_FAU_OP_SIZE_64 = 3
};
-typedef enum {
+enum cvmx_spi_mode {
CVMX_SPI_MODE_UNKNOWN = 0,
CVMX_SPI_MODE_TX_HALFPLEX = 1,
CVMX_SPI_MODE_RX_HALFPLEX = 2,
CVMX_SPI_MODE_DUPLEX = 3
-} cvmx_spi_mode_t;
+};
typedef enum {
CVMX_HELPER_INTERFACE_MODE_DISABLED,
@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
}
static inline int cvmx_spi_restart_interface(int interface,
- cvmx_spi_mode_t mode, int timeout)
+ enum cvmx_spi_mode mode, int timeout)
{
return 0;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/6] staging: octeon: clean up the octeon ethernet driver
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
2023-08-27 23:25 ` [PATCH v2 1/6] staging: octeon: clean up the octeon ethernet driver Oliver Crumrine
@ 2023-08-27 23:25 ` Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 3/6] " Oliver Crumrine
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: Oliver Crumrine @ 2023-08-27 23:25 UTC (permalink / raw)
To: gregkh, colin.i.king, sumitraartsy, u.kleine-koenig, geert
Cc: Oliver Crumrine, linux-kernel, linux-staging
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
v2: Actually send the patch set properly
drivers/staging/octeon/ethernet.c | 2 +-
drivers/staging/octeon/octeon-stubs.h | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 9eee28f2940c..023b107e077a 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -798,7 +798,7 @@ static int cvm_oct_probe(struct platform_device *pdev)
num_interfaces = cvmx_helper_get_number_of_interfaces();
for (interface = 0; interface < num_interfaces; interface++) {
- cvmx_helper_interface_mode_t imode =
+ enum cvmx_helper_interface_mode imode =
cvmx_helper_interface_get_mode(interface);
int num_ports = cvmx_helper_ports_on_interface(interface);
int port;
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 9f269626b862..0b0c609a771c 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -220,7 +220,7 @@ enum cvmx_spi_mode {
CVMX_SPI_MODE_DUPLEX = 3
};
-typedef enum {
+enum cvmx_helper_interface_mode {
CVMX_HELPER_INTERFACE_MODE_DISABLED,
CVMX_HELPER_INTERFACE_MODE_RGMII,
CVMX_HELPER_INTERFACE_MODE_GMII,
@@ -231,7 +231,7 @@ typedef enum {
CVMX_HELPER_INTERFACE_MODE_PICMG,
CVMX_HELPER_INTERFACE_MODE_NPI,
CVMX_HELPER_INTERFACE_MODE_LOOP,
-} cvmx_helper_interface_mode_t;
+};
typedef enum {
CVMX_POW_WAIT = 1,
@@ -1265,8 +1265,8 @@ static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t clear,
cvmx_pko_port_status_t *status)
{ }
-static inline cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(int
- interface)
+static inline enum cvmx_helper_interface_mode cvmx_helper_interface_get_mode(int
+ interface)
{
return 0;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/6] staging: octeon: clean up the octeon ethernet driver
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
2023-08-27 23:25 ` [PATCH v2 1/6] staging: octeon: clean up the octeon ethernet driver Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 2/6] " Oliver Crumrine
@ 2023-08-27 23:25 ` Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 4/6] " Oliver Crumrine
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: Oliver Crumrine @ 2023-08-27 23:25 UTC (permalink / raw)
To: gregkh, colin.i.king, sumitraartsy, u.kleine-koenig, geert
Cc: Oliver Crumrine, linux-kernel, linux-staging
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
v2: Actually send the patch set properly
drivers/staging/octeon/octeon-stubs.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 0b0c609a771c..4470c985dc5d 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -233,10 +233,10 @@ enum cvmx_helper_interface_mode {
CVMX_HELPER_INTERFACE_MODE_LOOP,
};
-typedef enum {
+enum cvmx_pow_wait {
CVMX_POW_WAIT = 1,
CVMX_POW_NO_WAIT = 0,
-} cvmx_pow_wait_t;
+};
typedef enum {
CVMX_PKO_LOCK_NONE = 0,
@@ -1342,11 +1342,11 @@ static inline unsigned int cvmx_get_core_num(void)
}
static inline void cvmx_pow_work_request_async_nocheck(int scr_addr,
- cvmx_pow_wait_t wait)
+ enum cvmx_pow_wait wait)
{ }
static inline void cvmx_pow_work_request_async(int scr_addr,
- cvmx_pow_wait_t wait)
+ enum cvmx_pow_wait wait)
{ }
static inline struct cvmx_wqe *cvmx_pow_work_response_async(int scr_addr)
@@ -1356,7 +1356,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_response_async(int scr_addr)
return wqe;
}
-static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
+static inline struct cvmx_wqe *cvmx_pow_work_request_sync(enum cvmx_pow_wait wait)
{
return (void *)(unsigned long)wait;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/6] staging: octeon: clean up the octeon ethernet driver
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
` (2 preceding siblings ...)
2023-08-27 23:25 ` [PATCH v2 3/6] " Oliver Crumrine
@ 2023-08-27 23:25 ` Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 5/6] " Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 6/6] " Oliver Crumrine
5 siblings, 0 replies; 6+ messages in thread
From: Oliver Crumrine @ 2023-08-27 23:25 UTC (permalink / raw)
To: gregkh, colin.i.king, sumitraartsy, u.kleine-koenig, geert
Cc: Oliver Crumrine, linux-kernel, linux-staging
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
v2: Actually send the patch set properly
drivers/staging/octeon/octeon-stubs.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 4470c985dc5d..2cdbcbd8a97b 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -238,11 +238,11 @@ enum cvmx_pow_wait {
CVMX_POW_NO_WAIT = 0,
};
-typedef enum {
+enum cvmx_pko_lock {
CVMX_PKO_LOCK_NONE = 0,
CVMX_PKO_LOCK_ATOMIC_TAG = 1,
CVMX_PKO_LOCK_CMD_QUEUE = 2,
-} cvmx_pko_lock_t;
+};
typedef enum {
CVMX_PKO_SUCCESS,
@@ -1381,12 +1381,12 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interfac
}
static inline void cvmx_pko_send_packet_prepare(uint64_t port, uint64_t queue,
- cvmx_pko_lock_t use_locking)
+ enum cvmx_pko_lock use_locking)
{ }
static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(uint64_t port,
uint64_t queue, union cvmx_pko_command_word0 pko_command,
- union cvmx_buf_ptr packet, cvmx_pko_lock_t use_locking)
+ union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
{
return 0;
}
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 5/6] staging: octeon: clean up the octeon ethernet driver
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
` (3 preceding siblings ...)
2023-08-27 23:25 ` [PATCH v2 4/6] " Oliver Crumrine
@ 2023-08-27 23:25 ` Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 6/6] " Oliver Crumrine
5 siblings, 0 replies; 6+ messages in thread
From: Oliver Crumrine @ 2023-08-27 23:25 UTC (permalink / raw)
To: gregkh, colin.i.king, sumitraartsy, u.kleine-koenig, geert
Cc: Oliver Crumrine, linux-kernel, linux-staging
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
v2: Actually send the patch set properly
drivers/staging/octeon/octeon-stubs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 2cdbcbd8a97b..b9852994882b 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -244,7 +244,7 @@ enum cvmx_pko_lock {
CVMX_PKO_LOCK_CMD_QUEUE = 2,
};
-typedef enum {
+enum cvmx_pko_status {
CVMX_PKO_SUCCESS,
CVMX_PKO_INVALID_PORT,
CVMX_PKO_INVALID_QUEUE,
@@ -252,7 +252,7 @@ typedef enum {
CVMX_PKO_NO_MEMORY,
CVMX_PKO_PORT_ALREADY_SETUP,
CVMX_PKO_CMD_QUEUE_INIT_ERROR
-} cvmx_pko_status_t;
+};
enum cvmx_pow_tag_type {
CVMX_POW_TAG_TYPE_ORDERED = 0L,
@@ -1384,7 +1384,7 @@ static inline void cvmx_pko_send_packet_prepare(uint64_t port, uint64_t queue,
enum cvmx_pko_lock use_locking)
{ }
-static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(uint64_t port,
+static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(uint64_t port,
uint64_t queue, union cvmx_pko_command_word0 pko_command,
union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
{
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 6/6] staging: octeon: clean up the octeon ethernet driver
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
` (4 preceding siblings ...)
2023-08-27 23:25 ` [PATCH v2 5/6] " Oliver Crumrine
@ 2023-08-27 23:25 ` Oliver Crumrine
5 siblings, 0 replies; 6+ messages in thread
From: Oliver Crumrine @ 2023-08-27 23:25 UTC (permalink / raw)
To: gregkh, colin.i.king, sumitraartsy, u.kleine-koenig, geert
Cc: Oliver Crumrine, linux-kernel, linux-staging
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@hotmail.com>
---
v2: Actually send the patch set properly
drivers/staging/octeon/ethernet.c | 2 +-
drivers/staging/octeon/octeon-stubs.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 023b107e077a..f01cdfa3275a 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -201,7 +201,7 @@ EXPORT_SYMBOL(cvm_oct_free_work);
*/
static struct net_device_stats *cvm_oct_common_get_stats(struct net_device *dev)
{
- cvmx_pip_port_status_t rx_status;
+ struct cvmx_pip_port_status_t rx_status;
cvmx_pko_port_status_t tx_status;
struct octeon_ethernet *priv = netdev_priv(dev);
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index b9852994882b..8befdcee6ee9 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -384,7 +384,7 @@ union cvmx_ipd_sub_port_qos_cnt {
} s;
};
-typedef struct {
+struct cvmx_pip_port_status {
uint32_t dropped_octets;
uint32_t dropped_packets;
uint32_t pci_raw_packets;
@@ -407,7 +407,7 @@ typedef struct {
uint32_t inb_packets;
uint64_t inb_octets;
uint16_t inb_errors;
-} cvmx_pip_port_status_t;
+};
typedef struct {
uint32_t packets;
@@ -1258,7 +1258,7 @@ static inline int octeon_is_simulation(void)
}
static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t clear,
- cvmx_pip_port_status_t *status)
+ struct cvmx_pip_port_status_t *status)
{ }
static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t clear,
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-27 23:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1693177830.git.ozlinux@hotmail.com>
2023-08-27 23:25 ` [PATCH v2 1/6] staging: octeon: clean up the octeon ethernet driver Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 2/6] " Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 3/6] " Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 4/6] " Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 5/6] " Oliver Crumrine
2023-08-27 23:25 ` [PATCH v2 6/6] " Oliver Crumrine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).