* [PATCH] inode.c cleanup
@ 2001-09-14 18:27 Alexander Viro
0 siblings, 0 replies; only message in thread
From: Alexander Viro @ 2001-09-14 18:27 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Alan Cox, linux-kernel
Obvious cleanup: superblocks leave the list before they
can get ->s_dev equal to 0 and they do it under sb_lock, so test
in the chunk below is bogus.
Please apply (it goes both for Linus' tree and -ac).
diff -urN S10-pre9/fs/inode.c S10-pre9-inode/fs/inode.c
--- S10-pre9/fs/inode.c Fri Sep 14 12:58:45 2001
+++ S10-pre9-inode/fs/inode.c Fri Sep 14 14:00:38 2001
@@ -405,8 +405,6 @@
spin_lock(&sb_lock);
sb = sb_entry(super_blocks.next);
for (; sb != sb_entry(&super_blocks); sb = sb_entry(sb->s_list.next)) {
- if (!sb->s_dev)
- continue;
spin_unlock(&sb_lock);
if (!try_to_sync_unused_list(&sb->s_dirty))
return;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-09-14 18:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-14 18:27 [PATCH] inode.c cleanup Alexander Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).