* Odd code in sd_init()
@ 2002-05-04 6:35 Alexander Viro
0 siblings, 0 replies; only message in thread
From: Alexander Viro @ 2002-05-04 6:35 UTC (permalink / raw)
To: Jens Axboe; +Cc: Linus Torvalds, linux-kernel
sd_init() contains the following loop:
for (k = 0; k < N_USED_SD_MAJORS; k++) {
request_queue_t *q = blk_get_queue(mk_kdev(SD_MAJOR(k), 0));
blk_queue_hardsect_size(q, 512);
}
... which is a damn interesting thing to do, seeing that it's called when
we do scsi_register_device(&sd_template) and before we get any chance to
set ->queue, so we actually end up setting sector size for hell knows
what (well, for default queues of our majors - i.e. stuff that won't be
used).
Either I'm missing something, or that code is bogus. Jens, Linus?
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-05-04 6:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-04 6:35 Odd code in sd_init() Alexander Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).