* Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()
[not found] <200304202224.h3KMOE4q003663@hera.kernel.org>
@ 2003-04-22 9:46 ` Geert Uytterhoeven
2003-04-23 7:12 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2003-04-22 9:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Development
On Sun, 20 Apr 2003, Linux Kernel Mailing List wrote:
> ChangeSet 1.1124.1.25, 2003/04/20 14:28:32-07:00, akpm@digeo.com
>
> [PATCH] use __GFP_REPEAT in pmd_alloc_one()
>
> Convert all pmd_alloc_one() implementations to use __GFP_REPEAT
If this change was bogus (cfr. Davem's checkin):
> diff -Nru a/arch/sparc/mm/sun4c.c b/arch/sparc/mm/sun4c.c
> --- a/arch/sparc/mm/sun4c.c Sun Apr 20 15:24:17 2003
> +++ b/arch/sparc/mm/sun4c.c Sun Apr 20 15:24:17 2003
> @@ -2194,7 +2194,7 @@
> BTFIXUPSET_CALL(pte_alloc_one_kernel, sun4c_pte_alloc_one_kernel, BTFIXUPCALL_NORM);
> BTFIXUPSET_CALL(pte_alloc_one, sun4c_pte_alloc_one, BTFIXUPCALL_NORM);
> BTFIXUPSET_CALL(free_pmd_fast, sun4c_free_pmd_fast, BTFIXUPCALL_NOP);
> - BTFIXUPSET_CALL(pmd_alloc_one, sun4c_pmd_alloc_one, BTFIXUPCALL_RETO0);
> + BTFIXUPSET_CALL(pmd_alloc_one, sun4c_lpmd_alloc_one, BTFIXUPCALL_RETO0);
> BTFIXUPSET_CALL(free_pgd_fast, sun4c_free_pgd_fast, BTFIXUPCALL_NORM);
> BTFIXUPSET_CALL(get_pgd_fast, sun4c_get_pgd_fast, BTFIXUPCALL_NORM);
Then this one is bogus, too:
> diff -Nru a/include/asm-m68k/sun3_pgalloc.h b/include/asm-m68k/sun3_pgalloc.h
> --- a/include/asm-m68k/sun3_pgalloc.h Sun Apr 20 15:24:17 2003
> +++ b/include/asm-m68k/sun3_pgalloc.h Sun Apr 20 15:24:17 2003
> @@ -18,7 +18,7 @@
>
> extern const char bad_pmd_string[];
>
> -#define pmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); })
> +#define lpmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); })
>
>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()
2003-04-22 9:46 ` [PATCH] use __GFP_REPEAT in pmd_alloc_one() Geert Uytterhoeven
@ 2003-04-23 7:12 ` David S. Miller
2003-04-23 7:20 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2003-04-23 7:12 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Andrew Morton, Linux Kernel Development
On Tue, 2003-04-22 at 02:46, Geert Uytterhoeven wrote:
> If this change was bogus (cfr. Davem's checkin):
...
> Then this one is bogus, too:
I don't think so, I believe Andrew was just trying to trap cases he
didn't understand.
--
David S. Miller <davem@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()
2003-04-23 7:12 ` David S. Miller
@ 2003-04-23 7:20 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2003-04-23 7:20 UTC (permalink / raw)
To: David S. Miller; +Cc: geert, linux-kernel
"David S. Miller" <davem@redhat.com> wrote:
>
> On Tue, 2003-04-22 at 02:46, Geert Uytterhoeven wrote:
> > If this change was bogus (cfr. Davem's checkin):
> ...
> > Then this one is bogus, too:
>
> I don't think so, I believe Andrew was just trying to trap cases he
> didn't understand.
No, it was just a flip of the singers. I typed `l' instead of control-l.
It was late. Sorry 'bout that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-04-23 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200304202224.h3KMOE4q003663@hera.kernel.org>
2003-04-22 9:46 ` [PATCH] use __GFP_REPEAT in pmd_alloc_one() Geert Uytterhoeven
2003-04-23 7:12 ` David S. Miller
2003-04-23 7:20 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).