From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: Fix IDE initialization when we don't probe for interrupts.
Date: Thu, 17 Jul 2003 17:32:38 +0200 (MEST) [thread overview]
Message-ID: <Pine.GSO.4.21.0307171730020.10372-100000@vervain.sonytel.be> (raw)
In-Reply-To: <1057793279.7137.0.camel@dhcp22.swansea.linux.org.uk>
On 10 Jul 2003, Alan Cox wrote:
> On Mer, 2003-07-09 at 23:08, Jeff Garzik wrote:
> > > + * Disable device irq if we don't need to
> > > + * probe for it. Otherwise we'll get spurious
> > > + * interrupts during the identify-phase that
> > > + * the irq handler isn't expecting.
> > > + */
> > > + hwif->OUTB(drive->ctl|2, IDE_CONTROL_REG);
> >
> >
> > Yeah, my driver does probing with interrupts disabled, too.
> > I'm curious where interrupts are re-enabled, though?
>
> In the command write. BTW note that there are a few devices
> out there that dont honour the nIEN stuff.
Indeed. E.g. some old Western Digital Caviars.
I remember these giving me a bad time on Amiga. Apparently the problem didn't
show up on PC, since (in those days) IDE didn't share its interrupt with some
other device, unlike on Amiga.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2003-07-17 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200307092110.h69LAlgG027527@hera.kernel.org>
2003-07-09 22:08 ` Fix IDE initialization when we don't probe for interrupts Jeff Garzik
2003-07-09 22:25 ` Linus Torvalds
2003-07-09 22:51 ` Bartlomiej Zolnierkiewicz
2003-07-09 22:52 ` Jeff Garzik
2003-07-17 15:36 ` Geert Uytterhoeven
2003-07-09 23:28 ` Alan Cox
2003-07-17 15:32 ` Geert Uytterhoeven [this message]
2003-07-17 15:58 John Bradford
2003-07-17 15:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0307171730020.10372-100000@vervain.sonytel.be \
--to=geert@linux-m68k.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).