* [PATCH] M68k wd33c93 locking
@ 2003-07-26 14:51 Geert Uytterhoeven
2003-07-28 8:49 ` Jan-Benedict Glaw
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2003-07-26 14:51 UTC (permalink / raw)
To: Linus Torvalds, Alan Cox
Cc: Ralf Baechle, Linux Kernel Development, Geert Uytterhoeven
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
M68k wd33c93: host_lock is a pointer to a spinlock, not a spinlock (from Ralf
Bächle)
--- linux-2.6.x/drivers/scsi/a2091.c Fri May 9 10:21:34 2003
+++ linux-m68k-2.6.x/drivers/scsi/a2091.c Fri Jun 6 13:33:13 2003
@@ -43,9 +43,9 @@
continue;
if (status & ISTR_INTS) {
- spin_lock_irqsave(&instance->host_lock, flags);
+ spin_lock_irqsave(instance->host_lock, flags);
wd33c93_intr (instance);
- spin_unlock_irqrestore(&instance->host_lock, flags);
+ spin_unlock_irqrestore(instance->host_lock, flags);
handled = 1;
}
}
--- linux-2.6.x/drivers/scsi/a3000.c Fri May 9 10:21:34 2003
+++ linux-m68k-2.6.x/drivers/scsi/a3000.c Fri Jun 6 13:33:13 2003
@@ -36,9 +36,9 @@
return IRQ_NONE;
if (status & ISTR_INTS)
{
- spin_lock_irqsave(&a3000_host->host_lock, flags);
+ spin_lock_irqsave(a3000_host->host_lock, flags);
wd33c93_intr (a3000_host);
- spin_unlock_irqrestore(&a3000_host->host_lock, flags);
+ spin_unlock_irqrestore(a3000_host->host_lock, flags);
return IRQ_HANDLED;
}
printk("Non-serviced A3000 SCSI-interrupt? ISTR = %02x\n", status);
--- linux-2.6.x/drivers/scsi/gvp11.c Fri May 9 10:21:34 2003
+++ linux-m68k-2.6.x/drivers/scsi/gvp11.c Fri Jun 6 13:33:18 2003
@@ -42,9 +42,9 @@
if (!(status & GVP11_DMAC_INT_PENDING))
continue;
- spin_lock_irqsave(&instance->host_lock, flags);
+ spin_lock_irqsave(instance->host_lock, flags);
wd33c93_intr (instance);
- spin_unlock_irqrestore(&instance->host_lock, flags);
+ spin_unlock_irqrestore(instance->host_lock, flags);
handled = 1;
}
return IRQ_RETVAL(handled);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] M68k wd33c93 locking
2003-07-26 14:51 [PATCH] M68k wd33c93 locking Geert Uytterhoeven
@ 2003-07-28 8:49 ` Jan-Benedict Glaw
2003-07-30 20:59 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Jan-Benedict Glaw @ 2003-07-28 8:49 UTC (permalink / raw)
To: Linux Kernel Development
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
On Sat, 2003-07-26 16:51:29 +0200, Geert Uytterhoeven <geert@linux-m68k.org>
wrote in message <200307261451.h6QEpT9s002280@callisto.of.borg>:
> M68k wd33c93: host_lock is a pointer to a spinlock, not a spinlock (from Ralf
> Bächle)
> --- linux-2.6.x/drivers/scsi/a3000.c Fri May 9 10:21:34 2003
> +++ linux-m68k-2.6.x/drivers/scsi/a3000.c Fri Jun 6 13:33:13 2003
> @@ -36,9 +36,9 @@
> return IRQ_NONE;
> if (status & ISTR_INTS)
> {
> - spin_lock_irqsave(&a3000_host->host_lock, flags);
> + spin_lock_irqsave(a3000_host->host_lock, flags);
> wd33c93_intr (a3000_host);
> - spin_unlock_irqrestore(&a3000_host->host_lock, flags);
> + spin_unlock_irqrestore(a3000_host->host_lock, flags);
> return IRQ_HANDLED;
> }
> printk("Non-serviced A3000 SCSI-interrupt? ISTR = %02x\n", status);
Is this the fix to A3000 SCSI? Hmmm... I'd give my box another try these
days:)
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak!
ret = do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] M68k wd33c93 locking
2003-07-28 8:49 ` Jan-Benedict Glaw
@ 2003-07-30 20:59 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2003-07-30 20:59 UTC (permalink / raw)
To: Jan-Benedict Glaw; +Cc: Linux Kernel Development
On Mon, 28 Jul 2003, Jan-Benedict Glaw wrote:
> On Sat, 2003-07-26 16:51:29 +0200, Geert Uytterhoeven <geert@linux-m68k.org>
> wrote in message <200307261451.h6QEpT9s002280@callisto.of.borg>:
> > M68k wd33c93: host_lock is a pointer to a spinlock, not a spinlock (from Ralf
> > Bächle)
>
> > --- linux-2.6.x/drivers/scsi/a3000.c Fri May 9 10:21:34 2003
> > +++ linux-m68k-2.6.x/drivers/scsi/a3000.c Fri Jun 6 13:33:13 2003
> > @@ -36,9 +36,9 @@
> > return IRQ_NONE;
> > if (status & ISTR_INTS)
> > {
> > - spin_lock_irqsave(&a3000_host->host_lock, flags);
> > + spin_lock_irqsave(a3000_host->host_lock, flags);
> > wd33c93_intr (a3000_host);
> > - spin_unlock_irqrestore(&a3000_host->host_lock, flags);
> > + spin_unlock_irqrestore(a3000_host->host_lock, flags);
> > return IRQ_HANDLED;
> > }
> > printk("Non-serviced A3000 SCSI-interrupt? ISTR = %02x\n", status);
>
> Is this the fix to A3000 SCSI? Hmmm... I'd give my box another try these
> days:)
If you're `A3000' means `Amiga 3000': yes, probably.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-07-30 20:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-26 14:51 [PATCH] M68k wd33c93 locking Geert Uytterhoeven
2003-07-28 8:49 ` Jan-Benedict Glaw
2003-07-30 20:59 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).