* [PATCH 167] Kill unused variables in the net code
@ 2005-01-07 21:11 Geert Uytterhoeven
2005-01-07 21:38 ` linux-os
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2005-01-07 21:11 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Linux Kernel Development, linux-net, Geert Uytterhoeven
2.4.28-rc2 introduced a warning in the net code on non-SMP:
net/core/neighbour.c:1809: warning: unused variable `tbl'
The following patch fixes this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--- linux-2.4.29-rc1/include/linux/spinlock.h 2004-04-27 17:22:10.000000000 +0200
+++ linux-m68k-2.4.29-rc1/include/linux/spinlock.h 2005-01-07 21:51:28.000000000 +0100
@@ -147,7 +147,7 @@
#define rwlock_init(lock) do { } while(0)
#define read_lock(lock) (void)(lock) /* Not "unused variable". */
-#define read_unlock(lock) do { } while(0)
+#define read_unlock(lock) (void)(lock) /* Not "unused variable". */
#define write_lock(lock) (void)(lock) /* Not "unused variable". */
#define write_unlock(lock) do { } while(0)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 167] Kill unused variables in the net code
2005-01-07 21:11 [PATCH 167] Kill unused variables in the net code Geert Uytterhoeven
@ 2005-01-07 21:38 ` linux-os
2005-01-07 22:20 ` Geert Uytterhoeven
2005-01-07 22:56 ` Sam Ravnborg
0 siblings, 2 replies; 4+ messages in thread
From: linux-os @ 2005-01-07 21:38 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Marcelo Tosatti, Linux Kernel Development, linux-net
On Fri, 7 Jan 2005, Geert Uytterhoeven wrote:
> 2.4.28-rc2 introduced a warning in the net code on non-SMP:
>
> net/core/neighbour.c:1809: warning: unused variable `tbl'
>
> The following patch fixes this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> --- linux-2.4.29-rc1/include/linux/spinlock.h 2004-04-27 17:22:10.000000000 +0200
> +++ linux-m68k-2.4.29-rc1/include/linux/spinlock.h 2005-01-07 21:51:28.000000000 +0100
> @@ -147,7 +147,7 @@
>
> #define rwlock_init(lock) do { } while(0)
> #define read_lock(lock) (void)(lock) /* Not "unused variable". */
> -#define read_unlock(lock) do { } while(0)
> +#define read_unlock(lock) (void)(lock) /* Not "unused variable". */
> #define write_lock(lock) (void)(lock) /* Not "unused variable". */
> #define write_unlock(lock) do { } while(0)
>
>
> Gr{oetje,eeting}s,
>
> Geert
But don't all you need to do is:
#define read_unlock(x)
Cheers,
Dick Johnson
Penguin : Linux version 2.6.10 on an i686 machine (5537.79 BogoMips).
Notice : All mail here is now cached for review by Dictator Bush.
98.36% of all statistics are fiction.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 167] Kill unused variables in the net code
2005-01-07 21:38 ` linux-os
@ 2005-01-07 22:20 ` Geert Uytterhoeven
2005-01-07 22:56 ` Sam Ravnborg
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2005-01-07 22:20 UTC (permalink / raw)
To: linux-os; +Cc: Marcelo Tosatti, Linux Kernel Development, linux-net
On Fri, 7 Jan 2005, linux-os wrote:
> On Fri, 7 Jan 2005, Geert Uytterhoeven wrote:
> > 2.4.28-rc2 introduced a warning in the net code on non-SMP:
> >
> > net/core/neighbour.c:1809: warning: unused variable `tbl'
> >
> > The following patch fixes this.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > --- linux-2.4.29-rc1/include/linux/spinlock.h 2004-04-27 17:22:10.000000000
> > +0200
> > +++ linux-m68k-2.4.29-rc1/include/linux/spinlock.h 2005-01-07
> > 21:51:28.000000000 +0100
> > @@ -147,7 +147,7 @@
> >
> > #define rwlock_init(lock) do { } while(0)
> > #define read_lock(lock) (void)(lock) /* Not "unused variable". */
> > -#define read_unlock(lock) do { } while(0)
> > +#define read_unlock(lock) (void)(lock) /* Not "unused variable". */
> > #define write_lock(lock) (void)(lock) /* Not "unused variable". */
> > #define write_unlock(lock) do { } while(0)
> But don't all you need to do is:
>
> #define read_unlock(x)
No, since the `x' may refer to a variable that's further unused (cfr.
net/core/neighbour.c:1809).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 167] Kill unused variables in the net code
2005-01-07 21:38 ` linux-os
2005-01-07 22:20 ` Geert Uytterhoeven
@ 2005-01-07 22:56 ` Sam Ravnborg
1 sibling, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2005-01-07 22:56 UTC (permalink / raw)
To: linux-os
Cc: Geert Uytterhoeven, Marcelo Tosatti, Linux Kernel Development, linux-net
On Fri, Jan 07, 2005 at 04:38:36PM -0500, linux-os wrote:
> >-#define read_unlock(lock) do { } while(0)
> >+#define read_unlock(lock) (void)(lock) /* Not "unused variable". */
>
> But don't all you need to do is:
>
> #define read_unlock(x)
Then tbl will still be unused - and compiler will emit warning.
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-01-07 22:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-07 21:11 [PATCH 167] Kill unused variables in the net code Geert Uytterhoeven
2005-01-07 21:38 ` linux-os
2005-01-07 22:20 ` Geert Uytterhoeven
2005-01-07 22:56 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).