* PATCH - compile fix for 3c509.c in 2.4.3-pre3
@ 2001-03-13 1:18 Neil Brown
2001-03-13 1:47 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Neil Brown @ 2001-03-13 1:18 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
Linus,
in 2.4.3-pre3, drivers/net/3c509.c will not compile ifdef CONFIG_ISAPNP.
The following patches fixes the error. I suspect that 3c515.c has
the same problem, but I didn't need to fix that to get my kernel to
build... so I didn't.
NeilBrown
--- ./drivers/net/3c509.c 2001/03/12 00:39:58 1.1
+++ ./drivers/net/3c509.c 2001/03/12 01:31:13 1.2
@@ -327,7 +327,7 @@
irq = idev->irq_resource[0].start;
if (el3_debug > 3)
printk ("ISAPnP reports %s at i/o 0x%x, irq %d\n",
- el3_isapnp_adapters[i].name, ioaddr, irq);
+ (char *)el3_isapnp_adapters[i].driver_data, ioaddr, irq);
EL3WINDOW(0);
for (j = 0; j < 3; j++)
el3_isapnp_phys_addr[pnp_cards][j] =
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH - compile fix for 3c509.c in 2.4.3-pre3
2001-03-13 1:18 PATCH - compile fix for 3c509.c in 2.4.3-pre3 Neil Brown
@ 2001-03-13 1:47 ` Jeff Garzik
[not found] ` <15021.36013.606715.731130@notabene.cse.unsw.edu.au>
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2001-03-13 1:47 UTC (permalink / raw)
To: Neil Brown; +Cc: Linus Torvalds, linux-kernel
On Tue, 13 Mar 2001, Neil Brown wrote:
> in 2.4.3-pre3, drivers/net/3c509.c will not compile ifdef CONFIG_ISAPNP.
>
> The following patches fixes the error. I suspect that 3c515.c has
> the same problem, but I didn't need to fix that to get my kernel to
> build... so I didn't.
3c509 and 3c515 fixes already sent to him, twice no less :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Modular versus non-modular ISAPNP (was Re: PATCH - compile fix for 3c509.c in 2.4.3-pre3)
[not found] ` <15021.36013.606715.731130@notabene.cse.unsw.edu.au>
@ 2001-03-13 3:02 ` Jeff Garzik
2001-03-13 4:03 ` Modular versus non-modular ISAPNP Ion Badulescu
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2001-03-13 3:02 UTC (permalink / raw)
To: Neil Brown; +Cc: Linux Knernel Mailing List
Neil Brown wrote:
> On Monday March 12, jgarzik@mandrakesoft.com wrote:
> > On Tue, 13 Mar 2001, Neil Brown wrote:
> > > in 2.4.3-pre3, drivers/net/3c509.c will not compile ifdef CONFIG_ISAPNP.
> > >
> > > The following patches fixes the error. I suspect that 3c515.c has
> > > the same problem, but I didn't need to fix that to get my kernel to
> > > build... so I didn't.
> > 3c509 and 3c515 fixes already sent to him, twice no less :)
> Drat... I didn't remember seeing it go by on linux-kernel, but maybe I
> didn't pay enough attention.... next time I'll wait till the same
> problem appears in two pre releases before patching...
(re cc'd to lkml...)
My fault on that one, I didn't send it to lkml...
BTW if you noticed, this problem was undetected initially due to
differences between CONFIG_ISAPNP and CONFIG_ISAPNP_MODULE in the
source.
It is highly recommended to always compile with CONFIG_ISAPNP=y due to
these differences. If you grep around for CONFIG_ISAPNP versus
CONFIG_ISAPNP_MODULE, you'll see that many drivers are woefully
unprepared for isapnp support compiled as a module.
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full mooon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Modular versus non-modular ISAPNP
2001-03-13 3:02 ` Modular versus non-modular ISAPNP (was Re: PATCH - compile fix for 3c509.c in 2.4.3-pre3) Jeff Garzik
@ 2001-03-13 4:03 ` Ion Badulescu
2001-03-13 10:03 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Ion Badulescu @ 2001-03-13 4:03 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux Knernel Mailing List
On Mon, 12 Mar 2001 22:02:12 -0500, Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> It is highly recommended to always compile with CONFIG_ISAPNP=y due to
> these differences. If you grep around for CONFIG_ISAPNP versus
> CONFIG_ISAPNP_MODULE, you'll see that many drivers are woefully
> unprepared for isapnp support compiled as a module.
Another entry for the Kernel Janitor's List, perhaps?
Ion
--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Modular versus non-modular ISAPNP
2001-03-13 4:03 ` Modular versus non-modular ISAPNP Ion Badulescu
@ 2001-03-13 10:03 ` Jeff Garzik
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2001-03-13 10:03 UTC (permalink / raw)
To: Ion Badulescu; +Cc: Linux Knernel Mailing List, Arnaldo Carvalho de Melo
Ion Badulescu wrote:
>
> On Mon, 12 Mar 2001 22:02:12 -0500, Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
>
> > It is highly recommended to always compile with CONFIG_ISAPNP=y due to
> > these differences. If you grep around for CONFIG_ISAPNP versus
> > CONFIG_ISAPNP_MODULE, you'll see that many drivers are woefully
> > unprepared for isapnp support compiled as a module.
>
> Another entry for the Kernel Janitor's List, perhaps?
Yep.. grep for CONFIG_ISAPNP, look at the code, and evaluate it to make
sure that isapnp works for that drivers regardless of whether
CONFIG_ISAPNP -or- CONFIG_ISAPNP_MODULE is defined.
Jeff
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full mooon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2001-03-13 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-13 1:18 PATCH - compile fix for 3c509.c in 2.4.3-pre3 Neil Brown
2001-03-13 1:47 ` Jeff Garzik
[not found] ` <15021.36013.606715.731130@notabene.cse.unsw.edu.au>
2001-03-13 3:02 ` Modular versus non-modular ISAPNP (was Re: PATCH - compile fix for 3c509.c in 2.4.3-pre3) Jeff Garzik
2001-03-13 4:03 ` Modular versus non-modular ISAPNP Ion Badulescu
2001-03-13 10:03 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).