[PATCH] vga16fb.c, length should be 65536

[PATCH] vga16fb.c, length should be 65536

[Tobias Diedrich]

Martin Mares agreed too, so I'm forwarding this :-)
Please apply

----- Forwarded message from Tobias Diedrich <ranma@gmx.at> -----

Message-ID: <20010829011707.A1984@router.ranmachan.dyndns.org>
User-Agent: Mutt/1.3.20i
Date: Wed, 29 Aug 2001 01:17:07 +0200
From: Tobias Diedrich <ranma@gmx.at>
To: Martin Mares <mj@suse.cz>
Cc: linux-video@atrey.karlin.mff.cuni.cz
Subject: [PATCH] vga16fb.c, length should be 65536
Content-Type: text/plain; charset=us-ascii

I noticed that the vga16 framebuffer driver returns a smem_len of
65535. Shouldn't that be 65536 ? (Realmode Segment A000-AFFF)

I already wrote about this to Ben Pfaff <pfaffen@msu.edu>, who is listed
at the top of this file, some time ago, to which he ansered
"I think you're right.". 

I recently looked at the source of a newer tree again to check wether he
did forward it, but appearently he did not. After looking at the
MAINTAINERS File again I found you being listed for "SVGA HANDLING",
so I'm sending this to you.

Should I forward this to Linus & linux-kernel ?

--- linux-2.4.8-ac11/drivers/video/vga16fb.c.orig	Wed Aug 29 01:04:04 2001
+++ linux-2.4.8-ac11/drivers/video/vga16fb.c	Wed Aug 29 01:04:12 2001
@@ -33,7 +33,7 @@
 #define dac_val	(0x3c9)
 
 #define VGA_FB_PHYS 0xA0000
-#define VGA_FB_PHYS_LEN 65535
+#define VGA_FB_PHYS_LEN 65536
 
 /* --------------------------------------------------------------------- */
 
-- 
Tobias							     PGP-Key: 0x9AC7E0BC

Re: [PATCH] vga16fb.c, length should be 65536

[Hugh Dickins]

On Wed, 29 Aug 2001, Tobias Diedrich wrote:
> 
> I noticed that the vga16 framebuffer driver returns a smem_len of
> 65535. Shouldn't that be 65536 ? (Realmode Segment A000-AFFF)
> 
> I already wrote about this to Ben Pfaff <pfaffen@msu.edu>, ...

Are you sure that shouldn't be Ben Pfb00?

Hugh