* Re: [OOPS] 8139too
@ 2001-03-14 20:41 Manfred Spraul
2001-03-15 9:24 ` Philipp Matthias Hahn
0 siblings, 1 reply; 4+ messages in thread
From: Manfred Spraul @ 2001-03-14 20:41 UTC (permalink / raw)
To: pmhahn; +Cc: linux-kernel
> Hello LKML!
> i686 2.4.2 UP+kdb+lm_sensors+pcmcia
> after APM laptop suspend to disk
> 8139too is build-in, not pcmcia
> I often get hangups after suspend-to-disk if I'm connected to a
hub/switch.
> This is the first oops I've actually seen and copied it by hand:
I remember a similar bug report.
Was the nic connected or not?
It seems that rtl8139_resume() unconditionally enables the nic, even if
it wasn't open()'ed. Then an interrupt arrives and crashes because some
memory structures were not allocated.
--
Manfred
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OOPS] 8139too
2001-03-14 20:41 [OOPS] 8139too Manfred Spraul
@ 2001-03-15 9:24 ` Philipp Matthias Hahn
2001-03-16 13:04 ` [PATCH] " Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Matthias Hahn @ 2001-03-15 9:24 UTC (permalink / raw)
To: Manfred Spraul; +Cc: Linux Kernel Mailing List
On Wed, 14 Mar 2001, Manfred Spraul wrote:
> > after APM laptop suspend to disk
> > 8139too is build-in, not pcmcia
> > I often get hangups after suspend-to-disk if I'm connected to a
> > hub/switch.
> > This is the first oops I've actually seen and copied it by hand:
> Was the nic connected or not?
The network was pluged in, but eth0 was not yet ifconfig'ed up.
> It seems that rtl8139_resume() unconditionally enables the nic, even if
> it wasn't open()'ed. Then an interrupt arrives and crashes because some
> memory structures were not allocated.
Will take a look myself after my exams.
BYtE
Philipp
--
/ / (_)__ __ ____ __ Philipp Hahn
/ /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Re: [OOPS] 8139too
2001-03-15 9:24 ` Philipp Matthias Hahn
@ 2001-03-16 13:04 ` Jeff Garzik
2001-03-23 9:54 ` Philipp Matthias Hahn
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2001-03-16 13:04 UTC (permalink / raw)
To: pmhahn; +Cc: Manfred Spraul, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
> i686 2.4.2 UP+kdb+lm_sensors+pcmcia
> after APM laptop suspend to disk
> 8139too is build-in, not pcmcia
> I often get hangups after suspend-to-disk if I'm connected to a hub/switch.
> This is the first oops I've actually seen and copied it by hand:
Philipp,
Does the attached patch solve the problem?
Modifying the interrupt handler may not be necessary, but it's there
just in case. (that's the first chunk of the patch)
Regards,
Jeff
--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full mooon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.
[-- Attachment #2: 8139too.patch --]
[-- Type: text/plain, Size: 1239 bytes --]
Index: drivers/net/8139too.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/drivers/net/8139too.c,v
retrieving revision 1.1.1.29.10.1
diff -u -r1.1.1.29.10.1 8139too.c
--- drivers/net/8139too.c 2001/03/13 05:12:53 1.1.1.29.10.1
+++ drivers/net/8139too.c 2001/03/16 13:01:08
@@ -2028,10 +2028,12 @@
rtl8139_weird_interrupt (dev, tp, ioaddr,
status, link_changed);
- if (status & (RxOK | RxUnderrun | RxOverflow | RxFIFOOver)) /* Rx interrupt */
+ if (netif_running (dev) &&
+ status & (RxOK | RxUnderrun | RxOverflow | RxFIFOOver)) /* Rx interrupt */
rtl8139_rx_interrupt (dev, tp, ioaddr);
- if (status & (TxOK | TxErr)) {
+ if (netif_running (dev) &&
+ status & (TxOK | TxErr)) {
spin_lock (&tp->lock);
rtl8139_tx_interrupt (dev, tp, ioaddr);
spin_unlock (&tp->lock);
@@ -2262,6 +2264,9 @@
void *ioaddr = tp->mmio_addr;
unsigned long flags;
+ if (!netif_running (dev))
+ return;
+
netif_device_detach (dev);
spin_lock_irqsave (&tp->lock, flags);
@@ -2282,6 +2287,8 @@
{
struct net_device *dev = pci_get_drvdata (pdev);
+ if (!netif_running (dev))
+ return;
netif_device_attach (dev);
rtl8139_hw_start (dev);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Re: [OOPS] 8139too
2001-03-16 13:04 ` [PATCH] " Jeff Garzik
@ 2001-03-23 9:54 ` Philipp Matthias Hahn
0 siblings, 0 replies; 4+ messages in thread
From: Philipp Matthias Hahn @ 2001-03-23 9:54 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Manfred Spraul, Linux Kernel Mailing List
On Fri, 16 Mar 2001, Jeff Garzik wrote:
> Does the attached patch solve the problem?
I didn't have a crash so far, so until now it look's okay. I would like to
say "you fixed it", but that's the problem with bugs: You can prove, there
are no bugs.
I will tell you as soon as possible if it should happen again, which I
hope wont.
Many thanks for your work.
BYtE
Philipp
--
/ / (_)__ __ ____ __ Philipp Hahn
/ /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-03-23 10:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-14 20:41 [OOPS] 8139too Manfred Spraul
2001-03-15 9:24 ` Philipp Matthias Hahn
2001-03-16 13:04 ` [PATCH] " Jeff Garzik
2001-03-23 9:54 ` Philipp Matthias Hahn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).