From: Ben LaHaise <bcrl@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: <torvalds@transmeta.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blkgetsize64 ioctl
Date: Wed, 29 Aug 2001 20:16:34 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.33.0108292009440.28439-100000@toomuch.toronto.redhat.com> (raw)
In-Reply-To: <20010829.170315.28787631.davem@redhat.com>
On Wed, 29 Aug 2001, David S. Miller wrote:
> Any problems with using "u64" or some other more strictly portable
> type? "long long" and other non-fixed sized types cause grief for
> many dual-API platforms.
That's entirely doable; I used long long because the existing API used
long. In fact, thinking about it a bit more, it would be better to not
add the ioctl as _IO(0x12,109), but instead use 110 and reserve 108 and
109 as braindamage ioctl writeoff (except documented, unlike the current
silent usage of ioctls by ia64). I hate ioctls and binary
incompatibilities. Here's the modified patch (incompatible with
e2fsprogs 1.23, but not conflicting with ia64: ioctls that write to disk
are b0rken).
-ben
diff -urN /md0/kernels/2.4/v2.4.10-pre2/include/linux/fs.h work-v2.4.10-pre2/include/linux/fs.h
--- /md0/kernels/2.4/v2.4.10-pre2/include/linux/fs.h Wed Aug 29 18:28:50 2001
+++ work-v2.4.10-pre2/include/linux/fs.h Wed Aug 29 20:14:58 2001
@@ -166,7 +166,7 @@
#define BLKROSET _IO(0x12,93) /* set device read-only (0 = read-write) */
#define BLKROGET _IO(0x12,94) /* get read-only status (0 = read_write) */
#define BLKRRPART _IO(0x12,95) /* re-read partition table */
-#define BLKGETSIZE _IO(0x12,96) /* return device size */
+#define BLKGETSIZE _IO(0x12,96) /* return device size (long *arg) */
#define BLKFLSBUF _IO(0x12,97) /* flush buffer cache */
#define BLKRASET _IO(0x12,98) /* Set read ahead for block device */
#define BLKRAGET _IO(0x12,99) /* get current read ahead setting */
@@ -182,6 +182,8 @@
/* This was here just to show that the number is taken -
probably all these _IO(0x12,*) ioctls should be moved to blkpg.h. */
#endif
+/* _IO(0x12,108) and _IO(0x12,109) are reserved for binary compatibility */
+#define BLKGETSIZE64 _IO(0x12,110) /* return device size (u64 *arg) */
#define BMAP_IOCTL 1 /* obsolete - kept for compatibility */
next prev parent reply other threads:[~2001-08-30 0:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-29 22:45 [PATCH] blkgetsize64 ioctl Ben LaHaise
2001-08-30 0:03 ` David S. Miller
2001-08-30 0:16 ` Ben LaHaise [this message]
2001-08-30 11:57 Andries.Brouwer
2001-08-30 16:11 Michael E Brown
2001-08-30 16:25 ` Ben LaHaise
2001-08-30 16:44 ` Michael E Brown
2001-08-30 16:47 ` Ben LaHaise
2001-08-30 17:02 ` Michael E Brown
2001-08-30 17:12 ` Ben LaHaise
2001-08-30 17:34 ` Michael E Brown
2001-08-30 18:51 ` Theodore Tso
2001-08-30 19:03 ` Alan Cox
2001-08-30 19:10 ` Michael E Brown
2001-08-30 19:18 ` Alan Cox
2001-08-31 1:15 Andries.Brouwer
2001-08-31 1:23 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0108292009440.28439-100000@toomuch.toronto.redhat.com \
--to=bcrl@redhat.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).