From: Michael E Brown <michael_e_brown@dell.com>
To: Ben LaHaise <bcrl@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blkgetsize64 ioctl
Date: Thu, 30 Aug 2001 12:02:13 -0500 (CDT) [thread overview]
Message-ID: <Pine.LNX.4.33.0108301150460.1213-100000@blap.linuxdev.us.dell.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0108301247130.12593-100000@toomuch.toronto.redhat.com>
And your response to the rest of the points I raised would be?
I'm sorry about e2fsprogs. If I had known a bit better (this was my first
kernel patch), I would have added a magic number to the struct you pass
in, and that would have prevented this little bit of braindamage.
--
Michael
On Thu, 30 Aug 2001, Ben LaHaise wrote:
> On Thu, 30 Aug 2001, Michael E Brown wrote:
>
> > And your last point about risking unexpected disk-io due to an incorrect
> > IOCTL, I would say that is a pretty unlikely in practice. First, I do
> > parameter checking on what was passed to the IOCTL, and if things don't
> > match, no io is done. Second, how likely is it that you a) call ioctl with
> > a (disk) block device, b) pass the wrong ioctl, c) pass along enough data
> > to pass the checks in the ioctl, and d) pass along a valid pointer to 512
> > bytes of data to overwrite something?
>
> e2fsprogs-1.23 on x86 does this.
>
> -ben
>
>
--
Michael Brown
Linux OS Development
Dell Computer Corp
If each of us have one object, and we exchange them,
then each of us still has one object.
If each of us have one idea, and we exchange them,
then each of us now has two ideas.
next prev parent reply other threads:[~2001-08-30 17:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-30 16:11 [PATCH] blkgetsize64 ioctl Michael E Brown
2001-08-30 16:25 ` Ben LaHaise
2001-08-30 16:44 ` Michael E Brown
2001-08-30 16:47 ` Ben LaHaise
2001-08-30 17:02 ` Michael E Brown [this message]
2001-08-30 17:12 ` Ben LaHaise
2001-08-30 17:34 ` Michael E Brown
2001-08-30 18:51 ` Theodore Tso
2001-08-30 19:03 ` Alan Cox
2001-08-30 19:10 ` Michael E Brown
2001-08-30 19:18 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2001-08-31 1:15 Andries.Brouwer
2001-08-31 1:23 ` Alan Cox
2001-08-30 11:57 Andries.Brouwer
2001-08-29 22:45 Ben LaHaise
2001-08-30 0:03 ` David S. Miller
2001-08-30 0:16 ` Ben LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0108301150460.1213-100000@blap.linuxdev.us.dell.com \
--to=michael_e_brown@dell.com \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).