still ati fb errors with 2.5.31, thought patch applied

still ati fb errors with 2.5.31, thought patch applied

[Clemens 'Gullevek' Schwaighofer]

Hello Linux,
it's 09:04 on 28.08.2002 

aty128fb.c: In function `aty128_pci_register':
aty128fb.c:1730: too many arguments to function `aty128find_ROM'
aty128fb.c:1736: warning: passing arg 1 of `aty128_get_pllinfo' from incompatible pointer type
aty128fb.c:1749: structure has no member named `mtrr'
aty128fb.c:1750: structure has no member named `vram_size'
aty128fb.c:1751: structure has no member named `mtrr'
aty128fb.c: At top level:
aty128fb.c:1402: warning: `aty128fb_rasterimg' defined but not used
make[3]: *** [aty128fb.o] Error 1
make[3]: Leaving directory `/usr/src/kernel/2.5.32/linux-2.5.32/drivers/video'
make[2]: *** [video] Error 2
make[2]: Leaving directory `/usr/src/kernel/2.5.32/linux-2.5.32/drivers'
make[1]: *** [drivers] Error 2
make[1]: Leaving directory `/usr/src/kernel/2.5.32/linux-2.5.32'
make: *** [bzImage] Error 2

gcc 3.2

I have applied the atifb patch postet earlier (19th august by Paul
Mackerras), but still get this error ...

Best regards, Clemens
-- 
_________/\_____________________              ^_^             ()~()
Clemens 'Gullevek' Schwaighofer \_______ @_@       ^_~       //@ @\\
ICQ#: 9646646        I AM FROM AUSTRIA! \______________ °_° //\ ~ /\\
http://www.animeundmanga.at | http://www.gullevek.org  \_____________

Re: still ati fb errors with 2.5.31, thought patch applied

[James Simmons]

> aty128fb.c: In function `aty128_pci_register':
> aty128fb.c:1730: too many arguments to function `aty128find_ROM'
> aty128fb.c:1736: warning: passing arg 1 of `aty128_get_pllinfo' from incompatible pointer type
> aty128fb.c:1749: structure has no member named `mtrr'
> aty128fb.c:1750: structure has no member named `vram_size'
> aty128fb.c:1751: structure has no member named `mtrr'
> aty128fb.c: At top level:
> aty128fb.c:1402: warning: `aty128fb_rasterimg' defined but not used
> make[3]: *** [aty128fb.o] Error 1
> make[3]: Leaving directory `/usr/src/kernel/2.5.32/linux-2.5.32/drivers/video'
> make[2]: *** [video] Error 2
> make[2]: Leaving directory `/usr/src/kernel/2.5.32/linux-2.5.32/drivers'
> make[1]: *** [drivers] Error 2
> make[1]: Leaving directory `/usr/src/kernel/2.5.32/linux-2.5.32'
> make: *** [bzImage] Error 2

This driver has not been ported to the new api.

> I have applied the atifb patch postet earlier (19th august by Paul
> Mackerras), but still get this error ...

The next set of changes for the fbdev layer includes a bunch of fixes
including ones for atifb.

MS: (n) 1. A debilitating and surprisingly widespread affliction that
renders the sufferer barely able to perform the simplest task. 2. A disease.

James Simmons  [jsimmons@users.sf.net] 	                ____/|
fbdev/console/gfx developer                             \ o.O|
http://www.linux-fbdev.org                               =(_)=
http://linuxgfx.sourceforge.net                            U
http://linuxconsole.sourceforge.net

Re: still ati fb errors with 2.5.31, thought patch applied

[Paul Mackerras]

James Simmons writes:

> > aty128fb.c: In function `aty128_pci_register':
> > aty128fb.c:1730: too many arguments to function `aty128find_ROM'
> > aty128fb.c:1736: warning: passing arg 1 of `aty128_get_pllinfo' from incompatible pointer type
> > aty128fb.c:1749: structure has no member named `mtrr'
> > aty128fb.c:1750: structure has no member named `vram_size'
> > aty128fb.c:1751: structure has no member named `mtrr'
> > aty128fb.c: At top level:
> > aty128fb.c:1402: warning: `aty128fb_rasterimg' defined but not used

> This driver has not been ported to the new api.

I sent you a patch to convert aty128fb.c to the new API, and I posted
a message to lkml saying that it was available at:

ftp://ftp.samba.org/pub/paulus/aty128.patch

It's about 112kB uncompressed, so I didn't include it in the mail to
lkml, but I'll send it to anyone who asks.

Paul.

Re: still ati fb errors with 2.5.31, thought patch applied

[Paul Mackerras]

I wrote:

> > This driver has not been ported to the new api.
> 
> I sent you a patch to convert aty128fb.c to the new API, and I posted
> a message to lkml saying that it was available at:

But of course those error messages were *with* my patch.  I just
cross-compiled a kernel for i386 and got the same errors.  Here is a
patch to go on top of my other patch which should fix things, though I
haven't tried running it on an x86 box yet.

Paul.

diff -urN pmac-ptep/drivers/video/Makefile pmac-2.5/drivers/video/Makefile
--- pmac-ptep/drivers/video/Makefile	Fri Aug 16 09:08:34 2002
+++ pmac-2.5/drivers/video/Makefile	Thu Aug 29 08:26:47 2002
@@ -44,7 +44,7 @@
 obj-$(CONFIG_FB_APOLLO)           += dnfb.o cfbfillrect.o cfbimgblt.o
 obj-$(CONFIG_FB_Q40)              += q40fb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_ATARI)            += atafb.o
-obj-$(CONFIG_FB_ATY128)           += aty128fb.o
+obj-$(CONFIG_FB_ATY128)           += aty128fb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_RADEON)		  += radeonfb.o
 obj-$(CONFIG_FB_NEOMAGIC)         += neofb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_IGA)              += igafb.o
diff -urN pmac-ptep/drivers/video/aty128fb.c pmac-2.5/drivers/video/aty128fb.c
--- pmac-ptep/drivers/video/aty128fb.c	Mon Aug 19 21:02:30 2002
+++ pmac-2.5/drivers/video/aty128fb.c	Thu Aug 29 08:22:13 2002
@@ -360,7 +360,9 @@
 static int aty128fb_blank(int blank, struct fb_info *fb);
 static int aty128fb_ioctl(struct inode *inode, struct file *file, u_int cmd,
 			  u_long arg, int con, struct fb_info *info);
+#if 0
 static int aty128fb_rasterimg(struct fb_info *info, int start);
+#endif
 
     /*
      *  Interface to the low level console driver
@@ -1397,6 +1399,7 @@
 	aty_st_le32(PALETTE_DATA, (red<<16)|(green<<8)|blue);
 }
 
+#if 0
 static int
 aty128fb_rasterimg(struct fb_info *info, int start)
 {
@@ -1407,7 +1410,7 @@
 
 	return 0;
 }
-
+#endif
 
 int __init
 aty128fb_setup(char *options)
@@ -1727,13 +1730,13 @@
 	}
 
 #if !defined(CONFIG_PPC) && !defined(__sparc__)
-	if (!(bios_seg = aty128find_ROM(info)))
+	if (!(bios_seg = aty128find_ROM()))
 		printk(KERN_INFO "aty128fb: Rage128 BIOS not located. "
 					"Guessing...\n");
 	else {
 		printk(KERN_INFO "aty128fb: Rage128 BIOS located at "
 				"segment %4.4X\n", (unsigned int)bios_seg);
-		aty128_get_pllinfo(info, bios_seg);
+		aty128_get_pllinfo(par, bios_seg);
 	}
 #endif
 	aty128_timings(par);
@@ -1746,9 +1749,9 @@
 
 #ifdef CONFIG_MTRR
 	if (mtrr) {
-		info->mtrr.vram = mtrr_add(info->fix.smem_start,
-				info->vram_size, MTRR_TYPE_WRCOMB, 1);
-		info->mtrr.vram_valid = 1;
+		par->mtrr.vram = mtrr_add(info->fix.smem_start,
+				par->vram_size, MTRR_TYPE_WRCOMB, 1);
+		par->mtrr.vram_valid = 1;
 		/* let there be speed */
 		printk(KERN_INFO "aty128fb: Rage128 MTRR set to ON\n");
 	}

Re: still ati fb errors with 2.5.31, thought patch applied

[Clemens 'Gullevek' Schwaighofer]

Hello Paul, 

Thursday, August 29, 2002, 12:33:07 AM, Paul Mackerras wrote,
and I answered on Freitag, 30. August 2002, 16:10:29 with this ...

I can confirm too, that this kernel boots, with the fb patches
applied, but now the font color is blue now.

best regards, Clemens
-- 
_________/\_____________________              ^_^             ()~()
Clemens 'Gullevek' Schwaighofer \_______ @_@       ^_~       //@ @\\
ICQ#: 9646646        I AM FROM AUSTRIA! \______________ °_° //\ ~ /\\
http://www.animeundmanga.at | http://www.gullevek.org  \_____________