asm/io_apic.h is missing in drivers/pci/quirks.c with kernel 2.5.50

asm/io_apic.h is missing in drivers/pci/quirks.c with kernel 2.5.50

[venom]

in file drivers/pci/quirks.c of linux kernel 2.5.50

#include <asm/io_apic.h>

is missing.


this include is necessary to avoid this error
in compilation time:

rivers/pci/quirks.c: In function `quirk_ioapic_rmw':
drivers/pci/quirks.c:354: `sis_apic_bug' undeclared (first use in this
function)
drivers/pci/quirks.c:354: (Each undeclared identifier is reported only
once
drivers/pci/quirks.c:354: for each function it appears in.)
make[2]: *** [drivers/pci/quirks.o] Error 1
make[1]: *** [drivers/pci] Error 2
make: *** [drivers] Error 2

Re: asm/io_apic.h is missing in drivers/pci/quirks.c with kernel 2.5.50

[Pete Zaitcev]

> in file drivers/pci/quirks.c of linux kernel 2.5.50
> 
> #include <asm/io_apic.h>
> 
> is missing.

What about architectures which do not have the said header,
because they have no apics? I do not think this is a good idea.

-- Pete

Re: asm/io_apic.h is missing in drivers/pci/quirks.c with kernel 2.5.50

[Justin Pryzby]

Alan's patch:

+ extern int sis_apic_bug;

will work; however, adding #include <asm/io_apic.h> will cause the
following on 2.5.50:

include/asm/mpspec.h:203: error: `NR_CPUS' undeclared here (not in a
function)
include/asm/io_apic.h:51: error: `MAX_IO_APICS' undeclared here (not in
a function)
include/asm/fixmap.h:49: error: `FIX_IO_APIC_BASE_0' used prior to
declaration.

Just wanted to be sure people applied the right patch.

Justin