* Re: [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo
[not found] ` <13yZr-2nX-23@gated-at.bofh.it>
@ 2003-12-18 15:40 ` Ronny V. Vindenes
2003-12-18 19:21 ` Mike Fedyk
0 siblings, 1 reply; 5+ messages in thread
From: Ronny V. Vindenes @ 2003-12-18 15:40 UTC (permalink / raw)
To: Mike Fedyk; +Cc: linux-kernel
Mike Fedyk <mfedyk@matchmail.com> writes:
> On Thu, Dec 11, 2003 at 03:05:11PM -0800, Mike Fedyk wrote:
> > On Thu, Dec 11, 2003 at 05:42:46PM -0500, Rik van Riel wrote:
> > > On Thu, 11 Dec 2003, Mike Fedyk wrote:
> > >
> > > > Inact_dirty: 21516 kB
> > > > Inact_laundry: 65612 kB
> > > > Inact_clean: 19812 kB
> > > >
> > > > These three are seperate lists in rmap, and are equal to "Inactive:" in
> > > > the -aa vm.
> > >
> > > I should add an Inactive: list to -rmap that sums up all
> > > 3, to make it a bit easier on programs parsing /proc.
> > >
> >
> > ISTR, asking for this a while ago ;)
> >
> > Yes, please do add that Inactive: line to rmap. :)
>
> How's this patch?
>
> --- proc_misc.c.orig 2003-12-16 17:03:45.000000000 -0800
> +++ proc_misc.c 2003-12-16 17:04:28.000000000 -0800
> @@ -189,6 +189,7 @@
> "Active: %8u kB\n"
> "ActiveAnon: %8u kB\n"
> "ActiveCache: %8u kB\n"
> + "Inactive: %8u kB\n"
> "Inact_dirty: %8u kB\n"
> "Inact_laundry:%8u kB\n"
> "Inact_clean: %8u kB\n"
> @@ -208,6 +209,8 @@
> K(nr_active_anon_pages()) + K(nr_active_cache_pages()),
> K(nr_active_anon_pages()),
> K(nr_active_cache_pages()),
> + K(nr_inactive_dirty_pages()) + K(nr_inactive_dirty_pages())
^^^^^
Shouldn't that be nr_inactive_clean_pages() ? now it's 2*dirty + laundry
> + + K(nr_inactive_laundry_pages()),
> K(nr_inactive_dirty_pages()),
> K(nr_inactive_laundry_pages()),
> K(nr_inactive_clean_pages()),
> -
--
Ronny V. Vindenes <s864@ii.uib.no>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo
2003-12-18 15:40 ` [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo Ronny V. Vindenes
@ 2003-12-18 19:21 ` Mike Fedyk
2003-12-18 19:53 ` Rik van Riel
0 siblings, 1 reply; 5+ messages in thread
From: Mike Fedyk @ 2003-12-18 19:21 UTC (permalink / raw)
To: Ronny V. Vindenes; +Cc: linux-kernel, Rik van Riel
On Thu, Dec 18, 2003 at 04:40:12PM +0100, Ronny V. Vindenes wrote:
> Mike Fedyk <mfedyk@matchmail.com> writes:
> > + K(nr_inactive_dirty_pages()) + K(nr_inactive_dirty_pages())
> ^^^^^
> Shouldn't that be nr_inactive_clean_pages() ? now it's 2*dirty + laundry
>
Yes, good catch. Thanks
> > + + K(nr_inactive_laundry_pages()),
How's this?
--- proc_misc.c.orig 2003-12-16 17:03:45.000000000 -0800
+++ proc_misc.c 2003-12-16 17:04:28.000000000 -0800
@@ -189,6 +189,7 @@
"Active: %8u kB\n"
"ActiveAnon: %8u kB\n"
"ActiveCache: %8u kB\n"
+ "Inactive: %8u kB\n"
"Inact_dirty: %8u kB\n"
"Inact_laundry:%8u kB\n"
"Inact_clean: %8u kB\n"
@@ -208,6 +209,8 @@
K(nr_active_anon_pages()) + K(nr_active_cache_pages()),
K(nr_active_anon_pages()),
K(nr_active_cache_pages()),
+ K(nr_inactive_dirty_pages()) + K(nr_inactive_laundry_pages())
+ + K(nr_inactive_clean_pages()),
K(nr_inactive_dirty_pages()),
K(nr_inactive_laundry_pages()),
K(nr_inactive_clean_pages()),
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo
2003-12-18 19:21 ` Mike Fedyk
@ 2003-12-18 19:53 ` Rik van Riel
0 siblings, 0 replies; 5+ messages in thread
From: Rik van Riel @ 2003-12-18 19:53 UTC (permalink / raw)
To: Mike Fedyk; +Cc: Ronny V. Vindenes, linux-kernel
On Thu, 18 Dec 2003, Mike Fedyk wrote:
> How's this?
Even better than the last one ;)
Good catch, Ronny!
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo
2003-12-17 1:12 ` [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: " Mike Fedyk
@ 2003-12-17 3:59 ` Rik van Riel
0 siblings, 0 replies; 5+ messages in thread
From: Rik van Riel @ 2003-12-17 3:59 UTC (permalink / raw)
To: Mike Fedyk; +Cc: linux-kernel
On Tue, 16 Dec 2003, Mike Fedyk wrote:
> How's this patch?
Looks great. Thanks.
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo
2003-12-11 23:05 ` Mike Fedyk
@ 2003-12-17 1:12 ` Mike Fedyk
2003-12-17 3:59 ` Rik van Riel
0 siblings, 1 reply; 5+ messages in thread
From: Mike Fedyk @ 2003-12-17 1:12 UTC (permalink / raw)
To: Rik van Riel; +Cc: linux-kernel
On Thu, Dec 11, 2003 at 03:05:11PM -0800, Mike Fedyk wrote:
> On Thu, Dec 11, 2003 at 05:42:46PM -0500, Rik van Riel wrote:
> > On Thu, 11 Dec 2003, Mike Fedyk wrote:
> >
> > > Inact_dirty: 21516 kB
> > > Inact_laundry: 65612 kB
> > > Inact_clean: 19812 kB
> > >
> > > These three are seperate lists in rmap, and are equal to "Inactive:" in
> > > the -aa vm.
> >
> > I should add an Inactive: list to -rmap that sums up all
> > 3, to make it a bit easier on programs parsing /proc.
> >
>
> ISTR, asking for this a while ago ;)
>
> Yes, please do add that Inactive: line to rmap. :)
How's this patch?
--- proc_misc.c.orig 2003-12-16 17:03:45.000000000 -0800
+++ proc_misc.c 2003-12-16 17:04:28.000000000 -0800
@@ -189,6 +189,7 @@
"Active: %8u kB\n"
"ActiveAnon: %8u kB\n"
"ActiveCache: %8u kB\n"
+ "Inactive: %8u kB\n"
"Inact_dirty: %8u kB\n"
"Inact_laundry:%8u kB\n"
"Inact_clean: %8u kB\n"
@@ -208,6 +209,8 @@
K(nr_active_anon_pages()) + K(nr_active_cache_pages()),
K(nr_active_anon_pages()),
K(nr_active_cache_pages()),
+ K(nr_inactive_dirty_pages()) + K(nr_inactive_dirty_pages())
+ + K(nr_inactive_laundry_pages()),
K(nr_inactive_dirty_pages()),
K(nr_inactive_laundry_pages()),
K(nr_inactive_clean_pages()),
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-12-18 19:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <11HNp-oH-19@gated-at.bofh.it>
[not found] ` <11I6J-UO-15@gated-at.bofh.it>
[not found] ` <13yZr-2nX-23@gated-at.bofh.it>
2003-12-18 15:40 ` [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: Mem: and Swap: lines in /proc/meminfo Ronny V. Vindenes
2003-12-18 19:21 ` Mike Fedyk
2003-12-18 19:53 ` Rik van Riel
2003-12-11 22:42 Rik van Riel
2003-12-11 23:05 ` Mike Fedyk
2003-12-17 1:12 ` [PATCH 2.4 Rmap] Add Inactive to /proc/meminfo was: " Mike Fedyk
2003-12-17 3:59 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).