* [PATCH 1/1] USB: EHCI: Tegra: Fix wrong register definition
@ 2012-09-18 8:42 Jim Lin
2012-09-18 14:33 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Jim Lin @ 2012-09-18 8:42 UTC (permalink / raw)
To: gregkh, swarren; +Cc: linux-usb, linux-kernel, Jim Lin
Fix the issue that EHCI registers, hostpc[0] and usbmode_ex,
are not correctly accessed on Tegra3 platform.
Signed-off-by: Jim Lin <jilin@nvidia.com>
---
include/linux/usb/ehci_def.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb/ehci_def.h
index de4b9ed..134bb4a 100644
--- a/include/linux/usb/ehci_def.h
+++ b/include/linux/usb/ehci_def.h
@@ -171,18 +171,18 @@ struct ehci_regs {
#define USBMODE_CM_HC (3<<0) /* host controller mode */
#define USBMODE_CM_IDLE (0<<0) /* idle state */
- u32 reserved4[7];
+ u32 reserved4[6];
/* Moorestown has some non-standard registers, partially due to the fact that
* its EHCI controller has both TT and LPM support. HOSTPCx are extensions to
* PORTSCx
*/
/* HOSTPC: offset 0x84 */
- u32 hostpc[0]; /* HOSTPC extension */
+ u32 hostpc[1]; /* HOSTPC extension */
#define HOSTPC_PHCD (1<<22) /* Phy clock disable */
#define HOSTPC_PSPD (3<<25) /* Port speed detection */
- u32 reserved5[17];
+ u32 reserved5[16];
/* USBMODE_EX: offset 0xc8 */
u32 usbmode_ex; /* USB Device mode extension */
--
1.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] USB: EHCI: Tegra: Fix wrong register definition
2012-09-18 8:42 [PATCH 1/1] USB: EHCI: Tegra: Fix wrong register definition Jim Lin
@ 2012-09-18 14:33 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2012-09-18 14:33 UTC (permalink / raw)
To: Jim Lin; +Cc: gregkh, swarren, linux-usb, linux-kernel
On Tue, 18 Sep 2012, Jim Lin wrote:
> Fix the issue that EHCI registers, hostpc[0] and usbmode_ex,
> are not correctly accessed on Tegra3 platform.
>
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> ---
> include/linux/usb/ehci_def.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/usb/ehci_def.h b/include/linux/usb/ehci_def.h
> index de4b9ed..134bb4a 100644
> --- a/include/linux/usb/ehci_def.h
> +++ b/include/linux/usb/ehci_def.h
> @@ -171,18 +171,18 @@ struct ehci_regs {
> #define USBMODE_CM_HC (3<<0) /* host controller mode */
> #define USBMODE_CM_IDLE (0<<0) /* idle state */
>
> - u32 reserved4[7];
> + u32 reserved4[6];
>
> /* Moorestown has some non-standard registers, partially due to the fact that
> * its EHCI controller has both TT and LPM support. HOSTPCx are extensions to
> * PORTSCx
> */
> /* HOSTPC: offset 0x84 */
> - u32 hostpc[0]; /* HOSTPC extension */
> + u32 hostpc[1]; /* HOSTPC extension */
> #define HOSTPC_PHCD (1<<22) /* Phy clock disable */
> #define HOSTPC_PSPD (3<<25) /* Port speed detection */
>
> - u32 reserved5[17];
> + u32 reserved5[16];
>
> /* USBMODE_EX: offset 0xc8 */
> u32 usbmode_ex; /* USB Device mode extension */
I was _certain_ this had been done correctly. Oh well, it just goes to
show you can't be too careful. Thanks for fixing the mistake in
reserved4.
By the way, it is certain that the HOSTPC register will never be used
on controllers having more than one port? If that's not certain, you
should leave the array size of hostpc set to 0.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-18 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-18 8:42 [PATCH 1/1] USB: EHCI: Tegra: Fix wrong register definition Jim Lin
2012-09-18 14:33 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).