[PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out side of the ifs.

[PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out side of the ifs.

[David Daney]

From: David Daney <david.daney@cavium.com>

When CONFIG_USB_SUPPORT is not selected we get things like:

scripts/kconfig/mconf Kconfig
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)

It is much cleaner to make the various system Kconfigs select
USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config
information into USB's Kconfig, but the warnings are annoying.

Eliminate the warning by moving the definition of
USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements.

Signed-off-by: David Daney <david.daney@cavium.com>
---
 drivers/usb/Kconfig      | 3 +++
 drivers/usb/host/Kconfig | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 73f62ca..38f97c5 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -9,6 +9,9 @@ config USB_ARCH_HAS_OHCI
 config USB_ARCH_HAS_EHCI
 	bool
 
+config USB_EHCI_BIG_ENDIAN_MMIO
+	bool
+
 config USB_ARCH_HAS_XHCI
 	bool
 
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 8e8e694..75e9f30 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -113,9 +113,6 @@ config USB_EHCI_HCD_PMC_MSP
 		Enables support for the onchip USB controller on the PMC_MSP7100 Family SoC's.
 		If unsure, say N.
 
-config USB_EHCI_BIG_ENDIAN_MMIO
-	bool
-
 config USB_EHCI_BIG_ENDIAN_DESC
 	bool
 
-- 
1.7.11.7

Re: [PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out side of the ifs.

[Alan Stern]

On Fri, 9 Aug 2013, David Daney wrote:

> From: David Daney <david.daney@cavium.com>
> 
> When CONFIG_USB_SUPPORT is not selected we get things like:
> 
> scripts/kconfig/mconf Kconfig
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> 
> It is much cleaner to make the various system Kconfigs select
> USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config
> information into USB's Kconfig, but the warnings are annoying.
> 
> Eliminate the warning by moving the definition of
> USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements.

This is a good thing to do, but you should also move 
USB_EHCI_BIG_ENDIAN_DESC.

And while you're at it, might as well move USB_OHCI_BIG_ENDIAN_DESC, 
USB_OHCI_BIG_ENDIAN_MMIO, and USB_OHCI_LITTLE_ENDIAN outside their "if" 
blocks.

Alan Stern