From: Alan Stern <stern@rowland.harvard.edu>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, <linux-samsung-soc@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kgene.kim@samsung.com>,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators
Date: Wed, 11 Jun 2014 11:39:10 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1406111131200.890-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1402064411-18244-1-git-send-email-gautam.vivek@samsung.com>
On Fri, 6 Jun 2014, Vivek Gautam wrote:
> Facilitate getting required 3.3V and 1.0V VDD supply for
> EHCI controller on Exynos.
>
> With patches for regulators' nodes merged in 3.15:
> c8c253f ARM: dts: Add regulator entries to smdk5420
> 275dcd2 ARM: dts: add max77686 pmic node for smdk5250,
>
> certain perripherals will now need to ensure that,
> they request VDD regulators in their drivers, and enable
> them so as to make them working.
"Certain peripherals"? Don't you mean "certain controllers"?
Does this mean some controllers don't need to use the VDD regulators?
> @@ -193,7 +196,31 @@ static int exynos_ehci_probe(struct platform_device *pdev)
>
> err = exynos_ehci_get_phy(&pdev->dev, exynos_ehci);
> if (err)
> - goto fail_clk;
> + goto fail_regulator1;
> +
> + exynos_ehci->vdd33 = devm_regulator_get(&pdev->dev, "vdd33");
> + if (!IS_ERR(exynos_ehci->vdd33)) {
> + err = regulator_enable(exynos_ehci->vdd33);
> + if (err) {
> + dev_err(&pdev->dev,
> + "Failed to enable 3.3V Vdd supply\n");
> + goto fail_regulator1;
> + }
> + } else {
> + dev_warn(&pdev->dev, "Regulator 3.3V Vdd supply not found\n");
> + }
What if this is one of the controllers that don't need to use a VDD
regulator? Do you really want to print out a warning in that case?
Should you call devm_regulator_get_optional() instead?
Alan Stern
next prev parent reply other threads:[~2014-06-11 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:20 [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators Vivek Gautam
2014-06-06 14:20 ` [PATCH v2 2/2] usb: ohci-exynos: " Vivek Gautam
2014-06-25 12:43 ` [PATCH v3 " Vivek Gautam
2014-06-11 15:39 ` Alan Stern [this message]
2014-06-12 4:21 ` [PATCH v2 1/2] usb: ehci-exynos: " Jingoo Han
2014-06-13 11:33 ` Vivek Gautam
2014-06-25 12:42 ` [PATCH v3 " Vivek Gautam
2015-05-31 6:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1406111131200.890-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).