From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
Jingoo Han <jg1.han@samsung.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v3 1/2] usb: ehci-exynos: Make provision for vdd regulators
Date: Sun, 31 May 2015 15:34:31 +0900 [thread overview]
Message-ID: <CAJKOXPeccCOBd6-jMJSZVtNMR82EUztZexqv1qParC9ad=YOtA@mail.gmail.com> (raw)
In-Reply-To: <1403700144-30720-1-git-send-email-gautam.vivek@samsung.com>
2014-06-25 21:42 GMT+09:00 Vivek Gautam <gautam.vivek@samsung.com>:
> Facilitate getting required 3.3V and 1.0V VDD supply for
> EHCI controller on Exynos.
>
> With the patches for regulators' nodes merged in 3.15:
> c8c253f ARM: dts: Add regulator entries to smdk5420
> 275dcd2 ARM: dts: add max77686 pmic node for smdk5250,
> the exynos systems turn on only minimal number of regulators.
>
> Until now, the VDD regulator supplies were either turned on
> by the bootloader, or the regulators were enabled by default
> in the kernel, so that the controller drivers did not need to
> care about turning on these regulators on their own.
> This was rather bad about these controller drivers.
> So ensuring now that the controller driver requests the necessary
> VDD regulators (if available, unless there are direct VDD rails),
> and enable them so as to make them working.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> ---
>
> Changes from v2:
> - replaced devm_regulator_get() with devm_regulator_get_optional().
> - Added Documentation for the vdd supplies for the controller.
> - Re-did the commit message.
The patch looks useful but it seems it was forgotten. Do you have any
plans to resend it?
Best regards,
Krzysztof
prev parent reply other threads:[~2015-05-31 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 14:20 [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators Vivek Gautam
2014-06-06 14:20 ` [PATCH v2 2/2] usb: ohci-exynos: " Vivek Gautam
2014-06-25 12:43 ` [PATCH v3 " Vivek Gautam
2014-06-11 15:39 ` [PATCH v2 1/2] usb: ehci-exynos: " Alan Stern
2014-06-12 4:21 ` Jingoo Han
2014-06-13 11:33 ` Vivek Gautam
2014-06-25 12:42 ` [PATCH v3 " Vivek Gautam
2015-05-31 6:34 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPeccCOBd6-jMJSZVtNMR82EUztZexqv1qParC9ad=YOtA@mail.gmail.com' \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).