linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Linux 2.4.29-rc2
@ 2005-01-12 15:13 Marcelo Tosatti
  2005-01-14 22:55 ` Steffen Moser
  0 siblings, 1 reply; 16+ messages in thread
From: Marcelo Tosatti @ 2005-01-12 15:13 UTC (permalink / raw)
  To: linux-kernel

Hi, 

Here goes the second release candidate of v2.4.29.

It contains mainly security fixes, including backports from 2.6-ac Coverity
fixes, rework of the do_brk() fixes as suggested by Linus, and a fix for the
pagefault SMP race disclosed today: 

CAN-2005-0001
http://www.isec.pl/vulnerabilities/isec-0022-pagefault.txt


Summary of changes from v2.4.29-rc1 to v2.4.29-rc2
============================================

Christoph Hellwig:
  o [XFS] make sure to always reclaim inodes in xfs_finish_reclaim
  o [XFS] Fix NFS inode data corruption
  o [XFS] Disable variable sized transfers on loop devices
  o [XFS] Fix compilations for parisc

Geert Uytterhoeven:
  o Kill unused variables in the tty code
  o Kill unused variables in the net code

Jan Harkes:
  o Fix Coda bugs found by Coverity checker

Marcelo Tosatti:
  o Update Dave Jones email address in MAINTAINERS file
  o Linus Torvalds: Warn if mmap_sem is not locked in do_brk
  o Change do_uselib() fix to match v2.6, rip do_brk_locked()
  o Brad Spengler: Fix random poolsize sysctl (from 2.6.10-ac)
  o Alan Cox: Fix moxa serial bound checking issue (from 2.6.10-ac)
  o Brad Spengler: Fix RLIMIT_MEMLOCK issue
  o get_user_pages: Change BUG_ON to WARN_ON
  o Alan Cox: rose_rt_ioctl lack of bounds checking, reported by Coverity (from 2.6.10-ac)
  o Alan Cox: sdla_xfer lack of bounds checking, reported by Coverity (from 2.6.10-ac)
  o Makefile
  o Revert dubious get_user_pages() bug checking
  o Olaf Kirch: sendmsg compat wrapper fixes
  o Cset exclude: marcelo@logos.cnet|ChangeSet|20050110190211|08215
  o Fix expand_stack() SMP race
  o Add missing Documentation/tty.txt from tty/ldisc locking updates
  o Completly remove old do_brk() fix
  o Linus Torvalds: Create helper for mmap_sem write-lock check in do_brk()
  o Fix mmap.c typo

Mikael Pettersson:
  o sungem UniNorth 2 GMAC support

Nathan Scott:
  o [XFS] Add sanity checks before use of attr_multi opcount parameter

Pete Zaitcev:
  o EHCI race fix


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-12 15:13 Linux 2.4.29-rc2 Marcelo Tosatti
@ 2005-01-14 22:55 ` Steffen Moser
  2005-01-14 23:17   ` Marcelo Tosatti
  2005-01-15  5:20   ` Adrian Bunk
  0 siblings, 2 replies; 16+ messages in thread
From: Steffen Moser @ 2005-01-14 22:55 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: linux-kernel

Hi Marcelo,

* On Wed, Jan 12, 2005 at 01:13 PM (-0200), Marcelo Tosatti wrote:

> Here goes the second release candidate of v2.4.29.

I've just encountered a little problem with both "linux-2.4.29-rc1" 
and "linux-2.4.29-rc2" on one of two machines. 


[1.] One line summary of the problem: 

Kernel module "serial.o" cannot be loaded


[2.] Full description of the problem/report:

I cannot load the module "serial.o" anymore, so I won't have serial 
port support (which is needed to have the machine communicating with
the UPS):

 | fsa01:~ # modprobe serial
 | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_ldisc_flush
 | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_wakeup
 | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o failed
 | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod serial failed

Up to now I've tested 2.4.29-rc1 and 2.4.29-rc2 only on two machines
("fsa01": SuSE Linux 7.2, "gateway": SuSE Linux 8.0). 

So far I can only state:

 - The problem only occurs on machine "fsa01" - using both 
   "2.4.29-rc1" and "2.4.29-rc2". 

 - The problem doesn't occur using 2.4.27 and 2.4.28 on the same
   machine using the same ".config" which can be found here [1].

 - There is no (!) problem on "gateway" (there I've only tested
   "2.4.29-rc1", yet). "gateway"'s ".config" can be found here [2]. 
 
 - I haven't tested "2.4.29-pre1" ... "2.4.29-pre3", yet. So I can't
   say which kernel version "introduced" the problem.

 
[3.] Keywords (i.e., modules, networking, kernel):

modules, tty


[4.] Kernel version (from /proc/version):

 | fsa01:~ # cat /proc/version
 | Linux version 2.4.29-rc2 (root@fsa01) (gcc version 2.95.3 20010315 (SuSE)) #3 Fri Jan 14 20:21:08 CET 2005

"2.4.29-rc1" is also affected on the same machine.


[5.] Output of Oops.. message (if applicable) with symbolic information 
     resolved (see Documentation/oops-tracing.txt):

There is no Oops message, even "dmesg" and "/var/log/messages"
respectively don't show anything wrong besides:

 | Jan 14 21:02:09 fsa01 insmod: /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod char-major-4 failed

which is generated during boot up.


[6.] A small shell script or example program which triggers the
     problem (if possible):

I just try to insert the module "serial.o"


[7.] Environment

[7.1.] Software (add the output of the ver_linux script here)

 - fsa01 (problem occurs):

 | If some fields are empty or look unusual you may have an old version.
 | Compare to the current minimal requirements in Documentation/Changes.
 | 
 | Linux fsa01 2.4.29-rc2 #3 Fri Jan 14 20:21:08 CET 2005 i686 unknown
 | 
 | Gnu C                  2.95.3
 | Gnu make               3.79.1
 | binutils               2.10.91.0.4
 | util-linux             2.11l
 | mount                  2.11l
 | modutils               2.4.5
 | e2fsprogs              1.25
 | pcmcia-cs              3.1.25
 | quota-tools            3.08.
 | Linux C Library        x    1 root     root      1341670 Dec 18  2001 /lib/libc.so.6
 | Dynamic linker (ldd)   2.2.2
 | Procps                 2.0.7
 | Net-tools              1.60
 | Kbd                    1.04
 | Sh-utils               2.0
 | Modules Loaded         ipv6 3c59x ipchains

 - gateway (no problem):

 | If some fields are empty or look unusual you may have an old version.
 | Compare to the current minimal requirements in Documentation/Changes.
 | 
 | Linux gateway 2.4.29-rc1 #4 Tue Jan 11 14:57:41 CET 2005 i686 unknown
 | 
 | Gnu C                  2.95.3
 | Gnu make               3.79.1
 | util-linux             2.11n
 | mount                  2.11n
 | modutils               2.4.12
 | e2fsprogs              1.26
 | jfsutils               1.0.15
 | xfsprogs               2.0.0
 | PPP                    2.4.1
 | Linux C Library        x    1 root     root      1394302 Aug 10  2002 /lib/libc.so.6
 | Dynamic linker (ldd)   2.2.5
 | Procps                 2.0.7
 | Net-tools              1.60
 | Kbd                    1.06
 | Sh-utils               2.0
 | Modules Loaded         serial ip_nat_ftp ip_conntrack_ftp ipt_REJECT
 |                        iptable_filter ipt_MASQUERADE iptable_nat ip_conntrack 
 |                        ip_tables ipv6 3c59x

[7.2.] Processor information (from /proc/cpuinfo):

 | v00001@fsa01:~ > cat /proc/cpuinfo
 | processor       : 0
 | vendor_id       : GenuineIntel
 | cpu family      : 6
 | model           : 8
 | model name      : Pentium III (Coppermine)
 | stepping        : 10
 | cpu MHz         : 871.032
 | cache size      : 256 KB
 | fdiv_bug        : no
 | hlt_bug         : no
 | f00f_bug        : no
 | coma_bug        : no
 | fpu             : yes
 | fpu_exception   : yes
 | cpuid level     : 2
 | wp              : yes
 | flags           : fpu vme de pse tsc msr pae mce cx8 sep mtrr pge mca cmov pat pse36 mmx fxsr sse
 | bogomips        : 1736.70


[7.3.] Module information (from /proc/modules):

 | v00001@fsa01:~ > cat /proc/modules
 | ipv6                  144736  -1 (autoclean)
 | 3c59x                  25088   1 (autoclean)
 | ipchains               37504   0


[7.4.] Loaded driver and hardware information (/proc/ioports,
       /proc/iomem):

 | v00001@fsa01:~ > cat /proc/ioports
 | 0000-001f : dma1
 | 0020-003f : pic1
 | 0040-005f : timer
 | 0060-006f : keyboard
 | 0080-008f : dma page reg
 | 00a0-00bf : pic2
 | 00c0-00df : dma2
 | 00f0-00ff : fpu
 | 01f0-01f7 : ide0
 | 03c0-03df : vga+
 | 03f6-03f6 : ide0
 | 0cf8-0cff : PCI conf1
 | a000-a01f : Intel Corp. 82801BA/BAM USB (Hub #2)
 | a400-a41f : Intel Corp. 82801BA/BAM USB (Hub #1)
 | a800-a80f : Intel Corp. 82801BA IDE U100
 |   a800-a807 : ide0
 |   a808-a80f : ide1
 | b800-b87f : 3Com Corporation 3c905C-TX/TX-M [Tornado] (#2)
 |   b800-b87f : 02:0d.0
 | d000-d07f : 3Com Corporation 3c905C-TX/TX-M [Tornado]
 |   d000-d07f : 02:0c.0
 | d400-d4ff : Adaptec AIC-7892A U160/m
 | d800-d87f : Silicon Integrated Systems [SiS] 86C326 5598/6326
 | e800-e80f : Intel Corp. 82801BA/BAM SMBus

 | v00001@fsa01:~ > cat /proc/iomem
 | 00000000-0009f7ff : System RAM
 | 0009f800-0009ffff : reserved
 | 000a0000-000bffff : Video RAM area
 | 000c0000-000c7fff : Video ROM
 | 000c8000-000ce5ff : Extension ROM
 | 000d0000-000d07ff : Extension ROM
 | 000d4000-000d47ff : Extension ROM
 | 000f0000-000fffff : System ROM
 | 00100000-1ffeafff : System RAM
 |   00100000-0022d5a6 : Kernel code
 |   0022d5a7-002af243 : Kernel data
 | 1ffeb000-1ffeefff : ACPI Tables
 | 1ffef000-1fffefff : reserved
 | 1ffff000-1fffffff : ACPI Non-volatile Storage
 | f5000000-f500007f : 3Com Corporation 3c905C-TX/TX-M [Tornado] (#2)
 | f5800000-f580007f : 3Com Corporation 3c905C-TX/TX-M [Tornado]
 | f6000000-f6000fff : Adaptec AIC-7892A U160/m
 |   f6000000-f6000fff : aic7xxx
 | f6800000-f680ffff : Silicon Integrated Systems [SiS] 86C326 5598/6326
 | f7800000-f7ffffff : Silicon Integrated Systems [SiS] 86C326 5598/6326
 | f8000000-fbffffff : Intel Corp. 82815 815 Chipset Host Bridge and Memory Controller Hub
 | ffff0000-ffffffff : reserved


[7.5.] PCI information ('lspci -vvv' as root):

Find this information at [3] (fsa01) and [4] (gateway).


[7.6.] SCSI information (from /proc/scsi/scsi):

 | v00001@fsa01:~ > cat /proc/scsi/scsi
 | Attached devices:
 | Host: scsi0 Channel: 00 Id: 00 Lun: 00
 |   Vendor: IBM      Model: DPSS-336950M     Rev: S96H
 |   Type:   Direct-Access                    ANSI SCSI revision: 03
 | Host: scsi0 Channel: 00 Id: 01 Lun: 00
 |   Vendor: IBM      Model: DPSS-336950M     Rev: S96H
 |   Type:   Direct-Access                    ANSI SCSI revision: 03
 | Host: scsi0 Channel: 00 Id: 03 Lun: 00
 |   Vendor: HP       Model: C1537A           Rev: L005
 |   Type:   Sequential-Access                ANSI SCSI revision: 02
 | Host: scsi0 Channel: 00 Id: 04 Lun: 00
 |   Vendor: IBM      Model: DNES-318350      Rev: SA30
 |   Type:   Direct-Access                    ANSI SCSI revision: 03
 | Host: scsi0 Channel: 00 Id: 05 Lun: 00
 |   Vendor: IBM      Model: DNES-318350      Rev: SA30
 |   Type:   Direct-Access                    ANSI SCSI revision: 03


[7.7.] Other information that might be relevant to the problem
       (please look in /proc and include all information that you
       think to be relevant):

If you need more information or testing, please let me know... 

I suppose the problem isn't related to the hardware of "fsa01" but 
perhaps to the different ".config" or the different version of the 
modutils, for example. 

Are you or is someone else able to reproduce the problem I have?

TIA!

Bye,
Steffen

[1] http://www.steffen-moser.de/temp/ml/lkml/2005-01-14_01/fsa01_config 
[2] http://www.steffen-moser.de/temp/ml/lkml/2005-01-14_01/gateway_config
[3] http://www.steffen-moser.de/temp/ml/lkml/2005-01-14_01/fsa01_lspci
[4] http://www.steffen-moser.de/temp/ml/lkml/2005-01-14_01/gateway_lspci

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-14 22:55 ` Steffen Moser
@ 2005-01-14 23:17   ` Marcelo Tosatti
  2005-01-15  2:58     ` David Dyck
                       ` (3 more replies)
  2005-01-15  5:20   ` Adrian Bunk
  1 sibling, 4 replies; 16+ messages in thread
From: Marcelo Tosatti @ 2005-01-14 23:17 UTC (permalink / raw)
  To: Steffen Moser; +Cc: linux-kernel, David Dyck


David, this also fix your problem.

On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
> Hi Marcelo,
> 
> * On Wed, Jan 12, 2005 at 01:13 PM (-0200), Marcelo Tosatti wrote:
> 
> > Here goes the second release candidate of v2.4.29.
> 
> I've just encountered a little problem with both "linux-2.4.29-rc1" 
> and "linux-2.4.29-rc2" on one of two machines. 
> 
> 
> [1.] One line summary of the problem: 
> 
> Kernel module "serial.o" cannot be loaded
> 
> 
> [2.] Full description of the problem/report:
> 
> I cannot load the module "serial.o" anymore, so I won't have serial 
> port support (which is needed to have the machine communicating with
> the UPS):
> 
>  | fsa01:~ # modprobe serial
>  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_ldisc_flush
>  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_wakeup
>  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o failed
>  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod serial failed

Steffen, 

Please try this:

--- a/drivers/char/tty_io.c.orig	2005-01-14 21:11:58.002189784 -0200
+++ b/drivers/char/tty_io.c	2005-01-14 21:12:53.743715784 -0200
@@ -718,7 +718,7 @@
 	wake_up_interruptible(&tty->write_wait);
 }
 
-EXPORT_SYMBOL_GPL(tty_wakeup);
+EXPORT_SYMBOL(tty_wakeup);
 
 void tty_ldisc_flush(struct tty_struct *tty)
 {
@@ -730,7 +730,7 @@
 	}
 }
 
-EXPORT_SYMBOL_GPL(tty_ldisc_flush);
+EXPORT_SYMBOL(tty_ldisc_flush);
 
 void do_tty_hagup(void *data)
 {

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-14 23:17   ` Marcelo Tosatti
@ 2005-01-15  2:58     ` David Dyck
  2005-01-15  3:04       ` David Dyck
  2005-01-15  5:23       ` Adrian Bunk
  2005-01-15  5:14     ` Adrian Bunk
                       ` (2 subsequent siblings)
  3 siblings, 2 replies; 16+ messages in thread
From: David Dyck @ 2005-01-15  2:58 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: Steffen Moser, linux-kernel

On Fri, 14 Jan 2005 at 21:17 -0200, Marcelo Tosatti <marcelo.tosatti@cyclad...:

> David, this also fix your problem.


Sorry, no

I tried your patch to drivers/char/tty_io.c
(using EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL)

My first test (apply the patch, make bzImage and modules again
results in the same errors as before

# insmod $PWD/cyclades.o
/lib/modules/2.4.29-rc2/kernel/drivers/char/cyclades.o: unresolved symbol tty_ldisc_flush
/lib/modules/2.4.29-rc2/kernel/drivers/char/cyclades.o: unresolved symbol tty_wakeup

$ grep tty_ldisc_flush /proc/ksyms
c01db0dc tty_ldisc_flush_R__ver_tty_ldisc_flush


 heading back to 2.4.29-pre2...
     David


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15  2:58     ` David Dyck
@ 2005-01-15  3:04       ` David Dyck
  2005-01-15  5:23       ` Adrian Bunk
  1 sibling, 0 replies; 16+ messages in thread
From: David Dyck @ 2005-01-15  3:04 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: Steffen Moser, linux-kernel

On Fri, 14 Jan 2005 at 18:58 -0800, David Dyck <david.dyck@fluke.com> wrote:

> On Fri, 14 Jan 2005 at 21:17 -0200, Marcelo Tosatti <marcelo.tosatti@cyclad...:
>
> > David, this also fix your problem.
>
>
> Sorry, no
>
> I tried your patch to drivers/char/tty_io.c
> (using EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL)
>
>  heading back to 2.4.29-pre2...
>      David

I noticed when booting 2.4.29-pre2 that I getting
other unresolved symbols

$ cd /lib/modules/2.4.29-pre2/kernel/fs/isofs
$ sudo insmod isofs.o

isofs.o: unresolved symbol zlib_inflate_workspacesize_Rce5ac24f
isofs.o: unresolved symbol zlib_inflateEnd_R9ef45f92
isofs.o: unresolved symbol zlib_inflate_R64cf8602
isofs.o: unresolved symbol zlib_inflateInit__R456e911d

I don't know if these are related

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-14 23:17   ` Marcelo Tosatti
  2005-01-15  2:58     ` David Dyck
@ 2005-01-15  5:14     ` Adrian Bunk
  2005-01-15  5:16       ` Adrian Bunk
  2005-01-15  7:43     ` Arjan van de Ven
  2005-01-15 10:07     ` Steffen Moser
  3 siblings, 1 reply; 16+ messages in thread
From: Adrian Bunk @ 2005-01-15  5:14 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: Steffen Moser, linux-kernel, David Dyck

On Fri, Jan 14, 2005 at 09:17:12PM -0200, Marcelo Tosatti wrote:
>...
> On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
>...
> > [1.] One line summary of the problem: 
> > 
> > Kernel module "serial.o" cannot be loaded
> > 
> > 
> > [2.] Full description of the problem/report:
> > 
> > I cannot load the module "serial.o" anymore, so I won't have serial 
> > port support (which is needed to have the machine communicating with
> > the UPS):
> > 
> >  | fsa01:~ # modprobe serial
> >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_ldisc_flush
> >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_wakeup
> >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o failed
> >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod serial failed
> 
> Steffen, 
> 
> Please try this:
>...
> -EXPORT_SYMBOL_GPL(tty_wakeup);
> +EXPORT_SYMBOL(tty_wakeup);
>...
> -EXPORT_SYMBOL_GPL(tty_ldisc_flush);
> +EXPORT_SYMBOL(tty_ldisc_flush);
>...

This shouldn't make any difference unless 2.4.29-rc2 contains non-GPL 
code.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15  5:14     ` Adrian Bunk
@ 2005-01-15  5:16       ` Adrian Bunk
  0 siblings, 0 replies; 16+ messages in thread
From: Adrian Bunk @ 2005-01-15  5:16 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: Steffen Moser, linux-kernel, David Dyck

On Sat, Jan 15, 2005 at 06:14:10AM +0100, Adrian Bunk wrote:
> On Fri, Jan 14, 2005 at 09:17:12PM -0200, Marcelo Tosatti wrote:
> >...
> > On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
> >...
> > > [1.] One line summary of the problem: 
> > > 
> > > Kernel module "serial.o" cannot be loaded
> > > 
> > > 
> > > [2.] Full description of the problem/report:
> > > 
> > > I cannot load the module "serial.o" anymore, so I won't have serial 
> > > port support (which is needed to have the machine communicating with
> > > the UPS):
> > > 
> > >  | fsa01:~ # modprobe serial
> > >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_ldisc_flush
> > >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: unresolved symbol tty_wakeup
> > >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o failed
> > >  | /lib/modules/2.4.29-rc2/kernel/drivers/char/serial.o: insmod serial failed
> > 
> > Steffen, 
> > 
> > Please try this:
> >...
> > -EXPORT_SYMBOL_GPL(tty_wakeup);
> > +EXPORT_SYMBOL(tty_wakeup);
> >...
> > -EXPORT_SYMBOL_GPL(tty_ldisc_flush);
> > +EXPORT_SYMBOL(tty_ldisc_flush);
> >...
> 
> This shouldn't make any difference unless 2.4.29-rc2 contains non-GPL 
> code.

Rethinking (and rereading the bug report), I understand how it could 
make a difference...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-14 22:55 ` Steffen Moser
  2005-01-14 23:17   ` Marcelo Tosatti
@ 2005-01-15  5:20   ` Adrian Bunk
  2005-01-15 11:43     ` Marcelo Tosatti
  1 sibling, 1 reply; 16+ messages in thread
From: Adrian Bunk @ 2005-01-15  5:20 UTC (permalink / raw)
  To: Marcelo Tosatti, linux-kernel

On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:

>...
>  - fsa01 (problem occurs):
>...
>  | modutils               2.4.5
>...
>  - gateway (no problem):
>...
>  | modutils               2.4.12
>....

OK, this seems to be the problem:
modutils before 2.4.10 don't know about EXPORT_SYMBOL_GPL.


Please upgrade modutils on fsa01 and report whether it fixes the 
problem.


If this was the problem, the patch below should be sufficient
(modutils 2.4.10 isn't a very strong dependency - even Debian stable 
ships 2.4.15).


<--  snip  -->


For support of EXPORT_SYMBOL_GPL, at least modutils 2.4.10 is required.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.4.29-rc2-full/Documentation/Changes.old	2005-01-15 06:17:46.000000000 +0100
+++ linux-2.4.29-rc2-full/Documentation/Changes	2005-01-15 06:18:26.000000000 +0100
@@ -52,7 +52,7 @@
 o  Gnu make               3.77                    # make --version
 o  binutils               2.9.1.0.25              # ld -v
 o  util-linux             2.10o                   # fdformat --version
-o  modutils               2.4.2                   # insmod -V
+o  modutils               2.4.10                  # insmod -V
 o  e2fsprogs              1.25                    # tune2fs
 o  jfsutils               1.0.12                  # fsck.jfs -V
 o  reiserfsprogs          3.6.3                   # reiserfsck -V 2>&1|grep reiserfsprogs
@@ -156,11 +156,8 @@
 Modutils
 --------
 
-Upgrade to recent modutils to fix various outstanding bugs which are
-seen more frequently under 2.4.x, and to enable auto-loading of USB
-modules.  In addition, the layout of modules under
-/lib/modules/`uname -r`/ has been made more sane.  This change also
-requires that you upgrade to a recent modutils.
+Upgrade to recent modutils is required for support of
+EXPORT_SYMBOL_GPL.
 
 Mkinitrd
 --------


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15  2:58     ` David Dyck
  2005-01-15  3:04       ` David Dyck
@ 2005-01-15  5:23       ` Adrian Bunk
  2005-01-15  6:39         ` David Dyck
  1 sibling, 1 reply; 16+ messages in thread
From: Adrian Bunk @ 2005-01-15  5:23 UTC (permalink / raw)
  To: David Dyck; +Cc: Marcelo Tosatti, Steffen Moser, linux-kernel

On Fri, Jan 14, 2005 at 06:58:11PM -0800, David Dyck wrote:
> On Fri, 14 Jan 2005 at 21:17 -0200, Marcelo Tosatti <marcelo.tosatti@cyclad...:
> 
> > David, this also fix your problem.
> 
> 
> Sorry, no
> 
> I tried your patch to drivers/char/tty_io.c
> (using EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL)
> 
> My first test (apply the patch, make bzImage and modules again
> results in the same errors as before
> 
> # insmod $PWD/cyclades.o
> /lib/modules/2.4.29-rc2/kernel/drivers/char/cyclades.o: unresolved symbol tty_ldisc_flush
> /lib/modules/2.4.29-rc2/kernel/drivers/char/cyclades.o: unresolved symbol tty_wakeup
> 
> $ grep tty_ldisc_flush /proc/ksyms
> c01db0dc tty_ldisc_flush_R__ver_tty_ldisc_flush

Please send:
- your .config
- the output of
    bash scripts/ver_linux

>  heading back to 2.4.29-pre2...
>      David

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15  5:23       ` Adrian Bunk
@ 2005-01-15  6:39         ` David Dyck
  0 siblings, 0 replies; 16+ messages in thread
From: David Dyck @ 2005-01-15  6:39 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Marcelo Tosatti, Steffen Moser, linux-kernel

On Sat, 15 Jan 2005 at 06:23 +0100, Adrian Bunk <bunk@stusta.de> wrote:

>
> On Fri, Jan 14, 2005 at 06:58:11PM -0800, David Dyck wrote:
> > On Fri, 14 Jan 2005 at 21:17 -0200, Marcelo Tosatti <marcelo.tosatti@cyclad...:
> >
> > > David, this also fix your problem.
> >
> >
> > Sorry, no
> >
>
> Please send:
> - your .config
> - the output of
>     bash scripts/ver_linux
> cu
> Adrian

Adrian,
 I've included my ver_linux, but don't spend too much time on them
because I had a procedural error (I applied Marcelo's patch, and
then just typed "make bzImage modules" and installed.

I wanted to give the patch a quick try before heading out to eat.
I now did a rebuild by saving my old .config
 and did the make mrproper, restored .config, make oldconfig dep bzImages modules
and reinstalled and rebooted.  after rebooting the cyclades driver loads
and I was able to talk to my serial port again.

Thanks to all for the patch and encouragement - keep
up the good work.

 David

If some fields are empty or look unusual you may have an old version.
Compare to the current minimal requirements in Documentation/Changes.

Linux dd 2.4.29-rc2 #1 Fri Jan 14 21:49:39 PST 2005 i686

Gnu C                  egcs-2.91.66.1
Gnu make               3.79.1
binutils               2.10
util-linux             2.10o
mount                  2.10o
modutils               2.4.2
e2fsprogs              1.25
Linux C Library        5.4.44
ldd: version 1.9.9
Linux C++ Library      27.2.1
Linux C++ Library      27.2.1
Procps                 1.01
Net-tools              1.51
Kbd                    0.89
Sh-utils               2.0
Modules Loaded         cyclades usb-uhci usbcore 3c59x


#
# Automatically generated make config: don't edit
#
CONFIG_X86=y
# CONFIG_SBUS is not set
CONFIG_UID16=y

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_MODVERSIONS=y
CONFIG_KMOD=y

#
# Processor type and features
#
# CONFIG_M386 is not set
# CONFIG_M486 is not set
# CONFIG_M586 is not set
# CONFIG_M586TSC is not set
# CONFIG_M586MMX is not set
CONFIG_M686=y
# CONFIG_MPENTIUMIII is not set
# CONFIG_MPENTIUM4 is not set
# CONFIG_MK6 is not set
# CONFIG_MK7 is not set
# CONFIG_MK8 is not set
# CONFIG_MELAN is not set
# CONFIG_MCRUSOE is not set
# CONFIG_MWINCHIPC6 is not set
# CONFIG_MWINCHIP2 is not set
# CONFIG_MWINCHIP3D is not set
# CONFIG_MCYRIXIII is not set
# CONFIG_MVIAC3_2 is not set
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_CMPXCHG=y
CONFIG_X86_XADD=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
# CONFIG_RWSEM_GENERIC_SPINLOCK is not set
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_X86_L1_CACHE_SHIFT=5
CONFIG_X86_HAS_TSC=y
CONFIG_X86_GOOD_APIC=y
CONFIG_X86_PGE=y
CONFIG_X86_USE_PPRO_CHECKSUM=y
CONFIG_X86_PPRO_FENCE=y
CONFIG_X86_F00F_WORKS_OK=y
CONFIG_X86_MCE=y
# CONFIG_TOSHIBA is not set
# CONFIG_I8K is not set
# CONFIG_MICROCODE is not set
# CONFIG_X86_MSR is not set
# CONFIG_X86_CPUID is not set
# CONFIG_EDD is not set
CONFIG_NOHIGHMEM=y
# CONFIG_HIGHMEM4G is not set
# CONFIG_HIGHMEM64G is not set
# CONFIG_HIGHMEM is not set
# CONFIG_MATH_EMULATION is not set
# CONFIG_MTRR is not set
# CONFIG_SMP is not set
# CONFIG_X86_UP_APIC is not set
# CONFIG_X86_UP_IOAPIC is not set
# CONFIG_X86_TSC_DISABLE is not set
CONFIG_X86_TSC=y

#
# General setup
#
CONFIG_NET=y
CONFIG_PCI=y
# CONFIG_PCI_GOBIOS is not set
# CONFIG_PCI_GODIRECT is not set
CONFIG_PCI_GOANY=y
CONFIG_PCI_BIOS=y
CONFIG_PCI_DIRECT=y
CONFIG_ISA=y
CONFIG_PCI_NAMES=y
# CONFIG_EISA is not set
# CONFIG_MCA is not set
# CONFIG_HOTPLUG is not set
# CONFIG_PCMCIA is not set
# CONFIG_HOTPLUG_PCI is not set
CONFIG_SYSVIPC=y
# CONFIG_BSD_PROCESS_ACCT is not set
CONFIG_SYSCTL=y
CONFIG_KCORE_ELF=y
# CONFIG_KCORE_AOUT is not set
CONFIG_BINFMT_AOUT=y
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=m
# CONFIG_OOM_KILLER is not set
CONFIG_PM=y
# CONFIG_APM is not set

#
# ACPI Support
#
# CONFIG_ACPI is not set

#
# Memory Technology Devices (MTD)
#
# CONFIG_MTD is not set

#
# Parallel port support
#
CONFIG_PARPORT=m
CONFIG_PARPORT_PC=m
CONFIG_PARPORT_PC_CML1=m
# CONFIG_PARPORT_SERIAL is not set
# CONFIG_PARPORT_PC_FIFO is not set
# CONFIG_PARPORT_PC_SUPERIO is not set
# CONFIG_PARPORT_PC_PCMCIA is not set
# CONFIG_PARPORT_AMIGA is not set
# CONFIG_PARPORT_MFC3 is not set
# CONFIG_PARPORT_ATARI is not set
# CONFIG_PARPORT_GSC is not set
# CONFIG_PARPORT_SUNBPP is not set
# CONFIG_PARPORT_IP22 is not set
# CONFIG_PARPORT_OTHER is not set
# CONFIG_PARPORT_1284 is not set

#
# Plug and Play configuration
#
CONFIG_PNP=m
CONFIG_ISAPNP=m

#
# Block devices
#
CONFIG_BLK_DEV_FD=y
# CONFIG_BLK_DEV_XD is not set
# CONFIG_PARIDE is not set
# CONFIG_BLK_CPQ_DA is not set
# CONFIG_BLK_CPQ_CISS_DA is not set
# CONFIG_CISS_SCSI_TAPE is not set
# CONFIG_CISS_MONITOR_THREAD is not set
# CONFIG_BLK_DEV_DAC960 is not set
# CONFIG_BLK_DEV_UMEM is not set
# CONFIG_BLK_DEV_SX8 is not set
CONFIG_BLK_DEV_LOOP=y
# CONFIG_BLK_DEV_NBD is not set
CONFIG_BLK_DEV_RAM=m
CONFIG_BLK_DEV_RAM_SIZE=4096
# CONFIG_BLK_DEV_INITRD is not set
CONFIG_BLK_STATS=y

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set
# CONFIG_BLK_DEV_MD is not set
# CONFIG_MD_LINEAR is not set
# CONFIG_MD_RAID0 is not set
# CONFIG_MD_RAID1 is not set
# CONFIG_MD_RAID5 is not set
# CONFIG_MD_MULTIPATH is not set
# CONFIG_BLK_DEV_LVM is not set

#
# Networking options
#
CONFIG_PACKET=y
# CONFIG_PACKET_MMAP is not set
CONFIG_NETLINK_DEV=y
# CONFIG_NETFILTER is not set
# CONFIG_FILTER is not set
CONFIG_UNIX=y
CONFIG_INET=y
# CONFIG_IP_MULTICAST is not set
# CONFIG_IP_ADVANCED_ROUTER is not set
# CONFIG_IP_PNP is not set
# CONFIG_NET_IPIP is not set
# CONFIG_NET_IPGRE is not set
# CONFIG_ARPD is not set
# CONFIG_INET_ECN is not set
# CONFIG_SYN_COOKIES is not set
# CONFIG_IPV6 is not set
# CONFIG_KHTTPD is not set

#
#    SCTP Configuration (EXPERIMENTAL)
#
# CONFIG_IP_SCTP is not set
# CONFIG_ATM is not set
# CONFIG_VLAN_8021Q is not set

#
#
#
# CONFIG_IPX is not set
# CONFIG_ATALK is not set
# CONFIG_DECNET is not set
# CONFIG_BRIDGE is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_LLC is not set
# CONFIG_NET_DIVERT is not set
# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set
# CONFIG_NET_FASTROUTE is not set
# CONFIG_NET_HW_FLOWCONTROL is not set

#
# QoS and/or fair queueing
#
# CONFIG_NET_SCHED is not set

#
# Network testing
#
# CONFIG_NET_PKTGEN is not set

#
# Telephony Support
#
CONFIG_PHONE=m
# CONFIG_PHONE_IXJ is not set
# CONFIG_PHONE_IXJ_PCMCIA is not set

#
# ATA/IDE/MFM/RLL support
#
CONFIG_IDE=y

#
# IDE, ATA and ATAPI Block devices
#
CONFIG_BLK_DEV_IDE=y

#
# Please see Documentation/ide.txt for help/info on IDE drives
#
# CONFIG_BLK_DEV_HD_IDE is not set
# CONFIG_BLK_DEV_HD is not set
# CONFIG_BLK_DEV_IDE_SATA is not set
CONFIG_BLK_DEV_IDEDISK=y
# CONFIG_IDEDISK_MULTI_MODE is not set
# CONFIG_IDEDISK_STROKE is not set
# CONFIG_BLK_DEV_IDECS is not set
# CONFIG_BLK_DEV_DELKIN is not set
CONFIG_BLK_DEV_IDECD=y
# CONFIG_BLK_DEV_IDETAPE is not set
# CONFIG_BLK_DEV_IDEFLOPPY is not set
# CONFIG_BLK_DEV_IDESCSI is not set
# CONFIG_IDE_TASK_IOCTL is not set

#
# IDE chipset support/bugfixes
#
CONFIG_BLK_DEV_CMD640=y
CONFIG_BLK_DEV_CMD640_ENHANCED=y
# CONFIG_BLK_DEV_ISAPNP is not set
CONFIG_BLK_DEV_IDEPCI=y
# CONFIG_BLK_DEV_GENERIC is not set
CONFIG_IDEPCI_SHARE_IRQ=y
CONFIG_BLK_DEV_IDEDMA_PCI=y
# CONFIG_BLK_DEV_OFFBOARD is not set
# CONFIG_BLK_DEV_IDEDMA_FORCED is not set
# CONFIG_IDEDMA_PCI_AUTO is not set
# CONFIG_IDEDMA_ONLYDISK is not set
CONFIG_BLK_DEV_IDEDMA=y
# CONFIG_IDEDMA_PCI_WIP is not set
# CONFIG_BLK_DEV_ADMA100 is not set
# CONFIG_BLK_DEV_AEC62XX is not set
# CONFIG_BLK_DEV_ALI15X3 is not set
# CONFIG_WDC_ALI15X3 is not set
# CONFIG_BLK_DEV_AMD74XX is not set
# CONFIG_AMD74XX_OVERRIDE is not set
# CONFIG_BLK_DEV_ATIIXP is not set
# CONFIG_BLK_DEV_CMD64X is not set
# CONFIG_BLK_DEV_TRIFLEX is not set
# CONFIG_BLK_DEV_CY82C693 is not set
# CONFIG_BLK_DEV_CS5530 is not set
# CONFIG_BLK_DEV_HPT34X is not set
# CONFIG_HPT34X_AUTODMA is not set
# CONFIG_BLK_DEV_HPT366 is not set
# CONFIG_BLK_DEV_PIIX is not set
# CONFIG_BLK_DEV_NS87415 is not set
# CONFIG_BLK_DEV_OPTI621 is not set
# CONFIG_BLK_DEV_PDC202XX_OLD is not set
# CONFIG_PDC202XX_BURST is not set
# CONFIG_BLK_DEV_PDC202XX_NEW is not set
CONFIG_BLK_DEV_RZ1000=y
# CONFIG_BLK_DEV_SC1200 is not set
# CONFIG_BLK_DEV_SVWKS is not set
# CONFIG_BLK_DEV_SIIMAGE is not set
# CONFIG_BLK_DEV_SIS5513 is not set
# CONFIG_BLK_DEV_SLC90E66 is not set
# CONFIG_BLK_DEV_TRM290 is not set
# CONFIG_BLK_DEV_VIA82CXXX is not set
# CONFIG_IDE_CHIPSETS is not set
# CONFIG_IDEDMA_AUTO is not set
# CONFIG_IDEDMA_IVB is not set
# CONFIG_DMA_NONPCI is not set
# CONFIG_BLK_DEV_ATARAID is not set
# CONFIG_BLK_DEV_ATARAID_PDC is not set
# CONFIG_BLK_DEV_ATARAID_HPT is not set
# CONFIG_BLK_DEV_ATARAID_MEDLEY is not set
# CONFIG_BLK_DEV_ATARAID_SII is not set

#
# SCSI support
#
# CONFIG_SCSI is not set

#
# Fusion MPT device support
#
# CONFIG_FUSION is not set
# CONFIG_FUSION_BOOT is not set
# CONFIG_FUSION_ISENSE is not set
# CONFIG_FUSION_CTL is not set
# CONFIG_FUSION_LAN is not set

#
# IEEE 1394 (FireWire) support (EXPERIMENTAL)
#
# CONFIG_IEEE1394 is not set

#
# I2O device support
#
# CONFIG_I2O is not set
# CONFIG_I2O_PCI is not set
# CONFIG_I2O_BLOCK is not set
# CONFIG_I2O_LAN is not set
# CONFIG_I2O_SCSI is not set
# CONFIG_I2O_PROC is not set

#
# Network device support
#
CONFIG_NETDEVICES=y

#
# ARCnet devices
#
# CONFIG_ARCNET is not set
CONFIG_DUMMY=m
# CONFIG_BONDING is not set
# CONFIG_EQUALIZER is not set
# CONFIG_TUN is not set
# CONFIG_ETHERTAP is not set
# CONFIG_NET_SB1000 is not set

#
# Ethernet (10 or 100Mbit)
#
CONFIG_NET_ETHERNET=y
# CONFIG_SUNLANCE is not set
# CONFIG_HAPPYMEAL is not set
# CONFIG_SUNBMAC is not set
# CONFIG_SUNQE is not set
# CONFIG_SUNGEM is not set
CONFIG_NET_VENDOR_3COM=y
# CONFIG_EL1 is not set
# CONFIG_EL2 is not set
# CONFIG_ELPLUS is not set
# CONFIG_EL16 is not set
CONFIG_EL3=y
# CONFIG_3C515 is not set
# CONFIG_ELMC is not set
# CONFIG_ELMC_II is not set
CONFIG_VORTEX=m
# CONFIG_TYPHOON is not set
# CONFIG_LANCE is not set
# CONFIG_NET_VENDOR_SMC is not set
# CONFIG_NET_VENDOR_RACAL is not set
# CONFIG_AT1700 is not set
# CONFIG_DEPCA is not set
# CONFIG_HP100 is not set
# CONFIG_NET_ISA is not set
# CONFIG_NET_PCI is not set
# CONFIG_NET_POCKET is not set

#
# Ethernet (1000 Mbit)
#
# CONFIG_ACENIC is not set
# CONFIG_DL2K is not set
# CONFIG_E1000 is not set
# CONFIG_MYRI_SBUS is not set
# CONFIG_NS83820 is not set
# CONFIG_HAMACHI is not set
# CONFIG_YELLOWFIN is not set
# CONFIG_R8169 is not set
# CONFIG_SK98LIN is not set
# CONFIG_TIGON3 is not set
# CONFIG_FDDI is not set
# CONFIG_HIPPI is not set
# CONFIG_PLIP is not set
# CONFIG_PPP is not set
# CONFIG_SLIP is not set

#
# Wireless LAN (non-hamradio)
#
# CONFIG_NET_RADIO is not set

#
# Token Ring devices
#
# CONFIG_TR is not set
# CONFIG_NET_FC is not set
# CONFIG_RCPCI is not set
# CONFIG_SHAPER is not set

#
# Wan interfaces
#
# CONFIG_WAN is not set

#
# Amateur Radio support
#
# CONFIG_HAMRADIO is not set

#
# IrDA (infrared) support
#
# CONFIG_IRDA is not set

#
# ISDN subsystem
#
# CONFIG_ISDN is not set

#
# Old CD-ROM drivers (not SCSI, not IDE)
#
# CONFIG_CD_NO_IDESCSI is not set

#
# Input core support
#
# CONFIG_INPUT is not set
# CONFIG_INPUT_KEYBDEV is not set
# CONFIG_INPUT_MOUSEDEV is not set
# CONFIG_INPUT_JOYDEV is not set
# CONFIG_INPUT_EVDEV is not set
# CONFIG_INPUT_UINPUT is not set

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_SERIAL=y
# CONFIG_SERIAL_CONSOLE is not set
# CONFIG_SERIAL_EXTENDED is not set
CONFIG_SERIAL_NONSTANDARD=y
# CONFIG_COMPUTONE is not set
# CONFIG_ROCKETPORT is not set
CONFIG_CYCLADES=m
# CONFIG_CYZ_INTR is not set
# CONFIG_DIGIEPCA is not set
# CONFIG_DIGI is not set
# CONFIG_ESPSERIAL is not set
# CONFIG_MOXA_INTELLIO is not set
# CONFIG_MOXA_SMARTIO is not set
# CONFIG_ISI is not set
# CONFIG_SYNCLINK is not set
# CONFIG_SYNCLINKMP is not set
# CONFIG_N_HDLC is not set
# CONFIG_RISCOM8 is not set
# CONFIG_SPECIALIX is not set
# CONFIG_SX is not set
# CONFIG_RIO is not set
# CONFIG_STALDRV is not set
CONFIG_UNIX98_PTYS=y
CONFIG_UNIX98_PTY_COUNT=256
# CONFIG_PRINTER is not set
# CONFIG_PPDEV is not set
# CONFIG_TIPAR is not set

#
# I2C support
#
# CONFIG_I2C is not set

#
# Mice
#
# CONFIG_BUSMOUSE is not set
CONFIG_MOUSE=y
CONFIG_PSMOUSE=y
# CONFIG_82C710_MOUSE is not set
# CONFIG_PC110_PAD is not set
# CONFIG_MK712_MOUSE is not set

#
# Joysticks
#
# CONFIG_INPUT_GAMEPORT is not set

#
# Input core support is needed for gameports
#

#
# Input core support is needed for joysticks
#
# CONFIG_QIC02_TAPE is not set
# CONFIG_IPMI_HANDLER is not set
# CONFIG_IPMI_PANIC_EVENT is not set
# CONFIG_IPMI_DEVICE_INTERFACE is not set
# CONFIG_IPMI_KCS is not set
# CONFIG_IPMI_WATCHDOG is not set

#
# Watchdog Cards
#
# CONFIG_WATCHDOG is not set
# CONFIG_SCx200 is not set
# CONFIG_SCx200_GPIO is not set
# CONFIG_AMD_RNG is not set
# CONFIG_INTEL_RNG is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_AMD_PM768 is not set
CONFIG_NVRAM=m
CONFIG_RTC=m
# CONFIG_DTLK is not set
# CONFIG_R3964 is not set
# CONFIG_APPLICOM is not set
# CONFIG_SONYPI is not set

#
# Ftape, the floppy tape device driver
#
# CONFIG_FTAPE is not set
# CONFIG_AGP is not set

#
# Direct Rendering Manager (XFree86 DRI support)
#
# CONFIG_DRM is not set
# CONFIG_MWAVE is not set
# CONFIG_OBMOUSE is not set

#
# Multimedia devices
#
CONFIG_VIDEO_DEV=m

#
# Video For Linux
#
# CONFIG_VIDEO_PROC_FS is not set
# CONFIG_I2C_PARPORT is not set

#
# Video Adapters
#
# CONFIG_VIDEO_BT848 is not set
# CONFIG_VIDEO_PMS is not set
# CONFIG_VIDEO_BWQCAM is not set
# CONFIG_VIDEO_CQCAM is not set
# CONFIG_VIDEO_CPIA is not set
# CONFIG_VIDEO_SAA5249 is not set
# CONFIG_TUNER_3036 is not set
# CONFIG_VIDEO_STRADIS is not set
# CONFIG_VIDEO_ZORAN is not set
# CONFIG_VIDEO_ZORAN_BUZ is not set
# CONFIG_VIDEO_ZORAN_DC10 is not set
# CONFIG_VIDEO_ZORAN_LML33 is not set
# CONFIG_VIDEO_ZR36120 is not set
# CONFIG_VIDEO_MEYE is not set

#
# Radio Adapters
#
# CONFIG_RADIO_CADET is not set
# CONFIG_RADIO_RTRACK is not set
# CONFIG_RADIO_RTRACK2 is not set
# CONFIG_RADIO_AZTECH is not set
# CONFIG_RADIO_GEMTEK is not set
# CONFIG_RADIO_GEMTEK_PCI is not set
# CONFIG_RADIO_MAXIRADIO is not set
# CONFIG_RADIO_MAESTRO is not set
# CONFIG_RADIO_MIROPCM20 is not set
# CONFIG_RADIO_MIROPCM20_RDS is not set
# CONFIG_RADIO_SF16FMI is not set
# CONFIG_RADIO_SF16FMR2 is not set
# CONFIG_RADIO_TERRATEC is not set
# CONFIG_RADIO_TRUST is not set
# CONFIG_RADIO_TYPHOON is not set
# CONFIG_RADIO_ZOLTRIX is not set

#
# File systems
#
# CONFIG_QUOTA is not set
# CONFIG_QFMT_V2 is not set
CONFIG_AUTOFS_FS=y
# CONFIG_AUTOFS4_FS is not set
CONFIG_REISERFS_FS=y
# CONFIG_REISERFS_CHECK is not set
# CONFIG_REISERFS_PROC_INFO is not set
# CONFIG_ADFS_FS is not set
# CONFIG_ADFS_FS_RW is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BEFS_DEBUG is not set
# CONFIG_BFS_FS is not set
CONFIG_EXT3_FS=y
CONFIG_JBD=y
CONFIG_JBD_DEBUG=y
CONFIG_FAT_FS=m
CONFIG_MSDOS_FS=m
# CONFIG_UMSDOS_FS is not set
CONFIG_VFAT_FS=m
# CONFIG_EFS_FS is not set
# CONFIG_JFFS_FS is not set
# CONFIG_JFFS2_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_TMPFS is not set
CONFIG_RAMFS=y
CONFIG_ISO9660_FS=m
CONFIG_JOLIET=y
CONFIG_ZISOFS=y
CONFIG_JFS_FS=y
CONFIG_JFS_DEBUG=y
CONFIG_JFS_STATISTICS=y
CONFIG_MINIX_FS=m
# CONFIG_VXFS_FS is not set
# CONFIG_NTFS_FS is not set
# CONFIG_NTFS_RW is not set
# CONFIG_HPFS_FS is not set
CONFIG_PROC_FS=y
# CONFIG_DEVFS_FS is not set
# CONFIG_DEVFS_MOUNT is not set
# CONFIG_DEVFS_DEBUG is not set
CONFIG_DEVPTS_FS=y
# CONFIG_QNX4FS_FS is not set
# CONFIG_QNX4FS_RW is not set
# CONFIG_ROMFS_FS is not set
CONFIG_EXT2_FS=y
# CONFIG_SYSV_FS is not set
# CONFIG_UDF_FS is not set
# CONFIG_UDF_RW is not set
# CONFIG_UFS_FS is not set
# CONFIG_UFS_FS_WRITE is not set
# CONFIG_XFS_FS is not set
# CONFIG_XFS_QUOTA is not set
# CONFIG_XFS_RT is not set
# CONFIG_XFS_TRACE is not set
# CONFIG_XFS_DEBUG is not set

#
# Network File Systems
#
# CONFIG_CODA_FS is not set
# CONFIG_INTERMEZZO_FS is not set
CONFIG_NFS_FS=y
CONFIG_NFS_V3=y
# CONFIG_NFS_DIRECTIO is not set
# CONFIG_ROOT_NFS is not set
CONFIG_NFSD=y
CONFIG_NFSD_V3=y
# CONFIG_NFSD_TCP is not set
CONFIG_SUNRPC=y
CONFIG_LOCKD=y
CONFIG_LOCKD_V4=y
CONFIG_SMB_FS=m
# CONFIG_SMB_NLS_DEFAULT is not set
CONFIG_SMB_UNIX=y
# CONFIG_NCP_FS is not set
# CONFIG_NCPFS_PACKET_SIGNING is not set
# CONFIG_NCPFS_IOCTL_LOCKING is not set
# CONFIG_NCPFS_STRONG is not set
# CONFIG_NCPFS_NFS_NS is not set
# CONFIG_NCPFS_OS2_NS is not set
# CONFIG_NCPFS_SMALLDOS is not set
# CONFIG_NCPFS_NLS is not set
# CONFIG_NCPFS_EXTRAS is not set
CONFIG_ZISOFS_FS=m

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y
CONFIG_SMB_NLS=y
CONFIG_NLS=y

#
# Native Language Support
#
CONFIG_NLS_DEFAULT="iso8859-1"
CONFIG_NLS_CODEPAGE_437=y
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
# CONFIG_NLS_CODEPAGE_850 is not set
# CONFIG_NLS_CODEPAGE_852 is not set
# CONFIG_NLS_CODEPAGE_855 is not set
# CONFIG_NLS_CODEPAGE_857 is not set
# CONFIG_NLS_CODEPAGE_860 is not set
# CONFIG_NLS_CODEPAGE_861 is not set
# CONFIG_NLS_CODEPAGE_862 is not set
# CONFIG_NLS_CODEPAGE_863 is not set
# CONFIG_NLS_CODEPAGE_864 is not set
# CONFIG_NLS_CODEPAGE_865 is not set
# CONFIG_NLS_CODEPAGE_866 is not set
# CONFIG_NLS_CODEPAGE_869 is not set
# CONFIG_NLS_CODEPAGE_936 is not set
# CONFIG_NLS_CODEPAGE_950 is not set
# CONFIG_NLS_CODEPAGE_932 is not set
# CONFIG_NLS_CODEPAGE_949 is not set
# CONFIG_NLS_CODEPAGE_874 is not set
# CONFIG_NLS_ISO8859_8 is not set
# CONFIG_NLS_CODEPAGE_1250 is not set
# CONFIG_NLS_CODEPAGE_1251 is not set
CONFIG_NLS_ISO8859_1=y
# CONFIG_NLS_ISO8859_2 is not set
# CONFIG_NLS_ISO8859_3 is not set
# CONFIG_NLS_ISO8859_4 is not set
# CONFIG_NLS_ISO8859_5 is not set
# CONFIG_NLS_ISO8859_6 is not set
# CONFIG_NLS_ISO8859_7 is not set
# CONFIG_NLS_ISO8859_9 is not set
# CONFIG_NLS_ISO8859_13 is not set
# CONFIG_NLS_ISO8859_14 is not set
# CONFIG_NLS_ISO8859_15 is not set
# CONFIG_NLS_KOI8_R is not set
# CONFIG_NLS_KOI8_U is not set
# CONFIG_NLS_UTF8 is not set

#
# Console drivers
#
CONFIG_VGA_CONSOLE=y
CONFIG_VIDEO_SELECT=y
# CONFIG_MDA_CONSOLE is not set

#
# Frame-buffer support
#
# CONFIG_FB is not set

#
# Sound
#
CONFIG_SOUND=m
# CONFIG_SOUND_ALI5455 is not set
# CONFIG_SOUND_BT878 is not set
# CONFIG_SOUND_CMPCI is not set
# CONFIG_SOUND_EMU10K1 is not set
# CONFIG_MIDI_EMU10K1 is not set
# CONFIG_SOUND_FUSION is not set
# CONFIG_SOUND_CS4281 is not set
# CONFIG_SOUND_ES1370 is not set
# CONFIG_SOUND_ES1371 is not set
# CONFIG_SOUND_ESSSOLO1 is not set
# CONFIG_SOUND_MAESTRO is not set
# CONFIG_SOUND_MAESTRO3 is not set
# CONFIG_SOUND_FORTE is not set
# CONFIG_SOUND_ICH is not set
# CONFIG_SOUND_RME96XX is not set
# CONFIG_SOUND_SONICVIBES is not set
# CONFIG_SOUND_TRIDENT is not set
# CONFIG_SOUND_MSNDCLAS is not set
# CONFIG_SOUND_MSNDPIN is not set
# CONFIG_SOUND_VIA82CXXX is not set
# CONFIG_MIDI_VIA82CXXX is not set
CONFIG_SOUND_OSS=m
# CONFIG_SOUND_TRACEINIT is not set
# CONFIG_SOUND_DMAP is not set
# CONFIG_SOUND_AD1816 is not set
# CONFIG_SOUND_AD1889 is not set
# CONFIG_SOUND_SGALAXY is not set
# CONFIG_SOUND_ADLIB is not set
# CONFIG_SOUND_ACI_MIXER is not set
CONFIG_SOUND_CS4232=m
# CONFIG_SOUND_SSCAPE is not set
# CONFIG_SOUND_GUS is not set
CONFIG_SOUND_VMIDI=m
# CONFIG_SOUND_TRIX is not set
# CONFIG_SOUND_MSS is not set
# CONFIG_SOUND_MPU401 is not set
# CONFIG_SOUND_NM256 is not set
# CONFIG_SOUND_MAD16 is not set
# CONFIG_SOUND_PAS is not set
# CONFIG_PAS_JOYSTICK is not set
# CONFIG_SOUND_PSS is not set
CONFIG_SOUND_SB=m
# CONFIG_SOUND_AWE32_SYNTH is not set
# CONFIG_SOUND_KAHLUA is not set
# CONFIG_SOUND_WAVEFRONT is not set
# CONFIG_SOUND_MAUI is not set
CONFIG_SOUND_YM3812=m
# CONFIG_SOUND_OPL3SA1 is not set
# CONFIG_SOUND_OPL3SA2 is not set
# CONFIG_SOUND_YMFPCI is not set
# CONFIG_SOUND_YMFPCI_LEGACY is not set
# CONFIG_SOUND_UART6850 is not set
# CONFIG_SOUND_AEDSP16 is not set
# CONFIG_SOUND_TVMIXER is not set
# CONFIG_SOUND_AD1980 is not set
# CONFIG_SOUND_WM97XX is not set

#
# USB support
#
CONFIG_USB=m
CONFIG_USB_DEBUG=y

#
# Miscellaneous USB options
#
CONFIG_USB_DEVICEFS=y
# CONFIG_USB_BANDWIDTH is not set

#
# USB Host Controller Drivers
#
# CONFIG_USB_EHCI_HCD is not set
CONFIG_USB_UHCI=m
CONFIG_USB_UHCI_ALT=m
# CONFIG_USB_OHCI is not set
# CONFIG_USB_SL811HS_ALT is not set
# CONFIG_USB_SL811HS is not set

#
# USB Device Class drivers
#
# CONFIG_USB_AUDIO is not set
# CONFIG_USB_EMI26 is not set
# CONFIG_USB_BLUETOOTH is not set
# CONFIG_USB_MIDI is not set

#
#   SCSI support is needed for USB Storage
#
# CONFIG_USB_STORAGE is not set
# CONFIG_USB_STORAGE_DEBUG is not set
# CONFIG_USB_STORAGE_DATAFAB is not set
# CONFIG_USB_STORAGE_FREECOM is not set
# CONFIG_USB_STORAGE_ISD200 is not set
# CONFIG_USB_STORAGE_DPCM is not set
# CONFIG_USB_STORAGE_HP8200e is not set
# CONFIG_USB_STORAGE_SDDR09 is not set
# CONFIG_USB_STORAGE_SDDR55 is not set
# CONFIG_USB_STORAGE_JUMPSHOT is not set
# CONFIG_USB_ACM is not set
# CONFIG_USB_PRINTER is not set

#
# USB Human Interface Devices (HID)
#
# CONFIG_USB_HID is not set

#
#     Input core support is needed for USB HID input layer or HIDBP support
#
# CONFIG_USB_HIDINPUT is not set
# CONFIG_USB_HIDDEV is not set
# CONFIG_USB_KBD is not set
# CONFIG_USB_MOUSE is not set
# CONFIG_USB_AIPTEK is not set
# CONFIG_USB_WACOM is not set
# CONFIG_USB_KBTAB is not set
# CONFIG_USB_POWERMATE is not set

#
# USB Imaging devices
#
# CONFIG_USB_DC2XX is not set
# CONFIG_USB_MDC800 is not set
# CONFIG_USB_SCANNER is not set
# CONFIG_USB_MICROTEK is not set
# CONFIG_USB_HPUSBSCSI is not set

#
# USB Multimedia devices
#
# CONFIG_USB_IBMCAM is not set
# CONFIG_USB_KONICAWC is not set
# CONFIG_USB_OV511 is not set
# CONFIG_USB_PWC is not set
# CONFIG_USB_SE401 is not set
CONFIG_USB_STV680=m
# CONFIG_USB_W9968CF is not set
# CONFIG_USB_VICAM is not set
# CONFIG_USB_DSBR is not set
# CONFIG_USB_DABUSB is not set

#
# USB Network adaptors
#
# CONFIG_USB_PEGASUS is not set
# CONFIG_USB_RTL8150 is not set
# CONFIG_USB_KAWETH is not set
# CONFIG_USB_CATC is not set
# CONFIG_USB_CDCETHER is not set
# CONFIG_USB_USBNET is not set

#
# USB port drivers
#
# CONFIG_USB_USS720 is not set

#
# USB Serial Converter support
#
CONFIG_USB_SERIAL=m
# CONFIG_USB_SERIAL_DEBUG is not set
CONFIG_USB_SERIAL_GENERIC=y
CONFIG_USB_SERIAL_BELKIN=m
# CONFIG_USB_SERIAL_WHITEHEAT is not set
# CONFIG_USB_SERIAL_DIGI_ACCELEPORT is not set
# CONFIG_USB_SERIAL_EMPEG is not set
# CONFIG_USB_SERIAL_FTDI_SIO is not set
CONFIG_USB_SERIAL_VISOR=m
# CONFIG_USB_SERIAL_IPAQ is not set
# CONFIG_USB_SERIAL_IR is not set
# CONFIG_USB_SERIAL_EDGEPORT is not set
# CONFIG_USB_SERIAL_EDGEPORT_TI is not set
# CONFIG_USB_SERIAL_KEYSPAN_PDA is not set
# CONFIG_USB_SERIAL_KEYSPAN is not set
# CONFIG_USB_SERIAL_MCT_U232 is not set
# CONFIG_USB_SERIAL_KLSI is not set
# CONFIG_USB_SERIAL_KOBIL_SCT is not set
CONFIG_USB_SERIAL_PL2303=m
# CONFIG_USB_SERIAL_CYBERJACK is not set
# CONFIG_USB_SERIAL_XIRCOM is not set
# CONFIG_USB_SERIAL_OMNINET is not set

#
# USB Miscellaneous drivers
#
# CONFIG_USB_RIO500 is not set
# CONFIG_USB_AUERSWALD is not set
# CONFIG_USB_TIGL is not set
# CONFIG_USB_BRLVGER is not set
# CONFIG_USB_LCD is not set

#
# Support for USB gadgets
#
# CONFIG_USB_GADGET is not set

#
# Bluetooth support
#
# CONFIG_BLUEZ is not set

#
# Kernel hacking
#
CONFIG_DEBUG_KERNEL=y
CONFIG_DEBUG_STACKOVERFLOW=y
# CONFIG_DEBUG_HIGHMEM is not set
# CONFIG_DEBUG_SLAB is not set
# CONFIG_DEBUG_IOVIRT is not set
CONFIG_MAGIC_SYSRQ=y
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_FRAME_POINTER is not set
CONFIG_LOG_BUF_SHIFT=0

#
# Cryptographic options
#
# CONFIG_CRYPTO is not set

#
# Library routines
#
# CONFIG_CRC32 is not set
CONFIG_ZLIB_INFLATE=m
CONFIG_ZLIB_DEFLATE=m

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-14 23:17   ` Marcelo Tosatti
  2005-01-15  2:58     ` David Dyck
  2005-01-15  5:14     ` Adrian Bunk
@ 2005-01-15  7:43     ` Arjan van de Ven
  2005-01-15 10:07     ` Steffen Moser
  3 siblings, 0 replies; 16+ messages in thread
From: Arjan van de Ven @ 2005-01-15  7:43 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: Steffen Moser, linux-kernel, David Dyck


> Please try this:
> 
> --- a/drivers/char/tty_io.c.orig	2005-01-14 21:11:58.002189784 -0200
> +++ b/drivers/char/tty_io.c	2005-01-14 21:12:53.743715784 -0200
> @@ -718,7 +718,7 @@
>  	wake_up_interruptible(&tty->write_wait);
>  }
>  
> -EXPORT_SYMBOL_GPL(tty_wakeup);
> +EXPORT_SYMBOL(tty_wakeup);
>  
when you merge this, please also add a comment that says "this is
actually a _GPL export but we can't do that in 2.4 for modutils compat
reasons"

To not loose that information and to make the status clear that people
shouldn't rely on these in binary modules


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-14 23:17   ` Marcelo Tosatti
                       ` (2 preceding siblings ...)
  2005-01-15  7:43     ` Arjan van de Ven
@ 2005-01-15 10:07     ` Steffen Moser
  3 siblings, 0 replies; 16+ messages in thread
From: Steffen Moser @ 2005-01-15 10:07 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: linux-kernel, David Dyck

Hi!

* On Fri, Jan 14, 2005 at 09:17 PM (-0200), Marcelo Tosatti wrote:

> Steffen, 
> 
> Please try this:
> 
> [...]

I've just applied the patch which fixed the problem. :-)

Thank you very much for your great work! 

Bye,
Steffen

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15  5:20   ` Adrian Bunk
@ 2005-01-15 11:43     ` Marcelo Tosatti
  2005-01-15 20:50       ` Adrian Bunk
  0 siblings, 1 reply; 16+ messages in thread
From: Marcelo Tosatti @ 2005-01-15 11:43 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel


Hi Adrian!

On Sat, Jan 15, 2005 at 06:20:50AM +0100, Adrian Bunk wrote:
> On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
> 
> >...
> >  - fsa01 (problem occurs):
> >...
> >  | modutils               2.4.5
> >...
> >  - gateway (no problem):
> >...
> >  | modutils               2.4.12
> >....
> 
> OK, this seems to be the problem:
> modutils before 2.4.10 don't know about EXPORT_SYMBOL_GPL.
> 
> Please upgrade modutils on fsa01 and report whether it fixes the 
> problem.

Yes, thats the right solution - however I think it might be worth to have 
the non-GPL versions. Several old distros ship modutils older than 2.4.10
- eg SuSE Linux 7.1 (Oct 2001).

> If this was the problem, the patch below should be sufficient
> (modutils 2.4.10 isn't a very strong dependency - even Debian stable 
> ships 2.4.15).
> 
> 
> <--  snip  -->
> 
> 
> For support of EXPORT_SYMBOL_GPL, at least modutils 2.4.10 is required.
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.4.29-rc2-full/Documentation/Changes.old	2005-01-15 06:17:46.000000000 +0100
> +++ linux-2.4.29-rc2-full/Documentation/Changes	2005-01-15 06:18:26.000000000 +0100
> @@ -52,7 +52,7 @@
>  o  Gnu make               3.77                    # make --version
>  o  binutils               2.9.1.0.25              # ld -v
>  o  util-linux             2.10o                   # fdformat --version
> -o  modutils               2.4.2                   # insmod -V
> +o  modutils               2.4.10                  # insmod -V
>  o  e2fsprogs              1.25                    # tune2fs
>  o  jfsutils               1.0.12                  # fsck.jfs -V
>  o  reiserfsprogs          3.6.3                   # reiserfsck -V 2>&1|grep reiserfsprogs
> @@ -156,11 +156,8 @@
>  Modutils
>  --------
>  
> -Upgrade to recent modutils to fix various outstanding bugs which are
> -seen more frequently under 2.4.x, and to enable auto-loading of USB
> -modules.  In addition, the layout of modules under
> -/lib/modules/`uname -r`/ has been made more sane.  This change also
> -requires that you upgrade to a recent modutils.
> +Upgrade to recent modutils is required for support of
> +EXPORT_SYMBOL_GPL.
>  
>  Mkinitrd
>  --------

Yes, this is change is interesting. I propose the following, with Arjan's comment
suggestion and yours 2.4.2/2.4.10 change.

--- drivers/char/tty_io.c.orig	2005-01-15 11:28:49.116993816 -0200
+++ drivers/char/tty_io.c	2005-01-15 11:33:45.063003184 -0200
@@ -718,7 +718,12 @@
 	wake_up_interruptible(&tty->write_wait);
 }
 
-EXPORT_SYMBOL_GPL(tty_wakeup);
+/*
+ * tty_wakeup/tty_ldisc_flush are actually _GPL exports but we can't do 
+ * that in 2.4 for modutils compat reasons.
+ */
+EXPORT_SYMBOL(tty_wakeup);
+
 
 void tty_ldisc_flush(struct tty_struct *tty)
 {
@@ -730,7 +735,12 @@
 	}
 }
 
-EXPORT_SYMBOL_GPL(tty_ldisc_flush);
+
+/*
+ * tty_wakeup/tty_ldisc_flush are actually _GPL exports but we can't do 
+ * that in 2.4 for modutils compat reasons.
+ */
+EXPORT_SYMBOL(tty_ldisc_flush);
 
 void do_tty_hangup(void *data)
 {
--- Documentation/Changes.orig	2005-01-15 11:26:42.221284896 -0200
+++ Documentation/Changes	2005-01-15 11:27:50.330930656 -0200
@@ -52,7 +52,7 @@
 o  Gnu make               3.77                    # make --version
 o  binutils               2.9.1.0.25              # ld -v
 o  util-linux             2.10o                   # fdformat --version
-o  modutils               2.4.2                   # insmod -V
+o  modutils               2.4.10                   # insmod -V
 o  e2fsprogs              1.25                    # tune2fs
 o  jfsutils               1.0.12                  # fsck.jfs -V
 o  reiserfsprogs          3.6.3                   # reiserfsck -V 2>&1|grep reiserfsprogs
@@ -159,8 +159,8 @@
 Upgrade to recent modutils to fix various outstanding bugs which are
 seen more frequently under 2.4.x, and to enable auto-loading of USB
 modules.  In addition, the layout of modules under
-/lib/modules/`uname -r`/ has been made more sane.  This change also
-requires that you upgrade to a recent modutils.
+/lib/modules/`uname -r`/ has been made more sane, and EXPORT_SYMBOL_GPL 
+also requires that you upgrade to a recent modutils.
 
 Mkinitrd
 --------




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15 20:50       ` Adrian Bunk
@ 2005-01-15 18:31         ` Marcelo Tosatti
  2005-01-15 20:57         ` Jan Knutar
  1 sibling, 0 replies; 16+ messages in thread
From: Marcelo Tosatti @ 2005-01-15 18:31 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel

On Sat, Jan 15, 2005 at 09:50:02PM +0100, Adrian Bunk wrote:
> On Sat, Jan 15, 2005 at 09:43:09AM -0200, Marcelo Tosatti wrote:
> > 
> > Hi Adrian!
> > 
> > On Sat, Jan 15, 2005 at 06:20:50AM +0100, Adrian Bunk wrote:
> > > On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
> > > 
> > > >...
> > > >  - fsa01 (problem occurs):
> > > >...
> > > >  | modutils               2.4.5
> > > >...
> > > >  - gateway (no problem):
> > > >...
> > > >  | modutils               2.4.12
> > > >....
> > > 
> > > OK, this seems to be the problem:
> > > modutils before 2.4.10 don't know about EXPORT_SYMBOL_GPL.
> > > 
> > > Please upgrade modutils on fsa01 and report whether it fixes the 
> > > problem.
> > 
> > Yes, thats the right solution - however I think it might be worth to have 
> > the non-GPL versions. Several old distros ship modutils older than 2.4.10
> > - eg SuSE Linux 7.1 (Oct 2001).
> >...
> 
> Do a grep for EXPORT_SYMBOL_GPL in the 2.4.29-rc2 sources.
> 
> It seems for some reason people didn't scream in older 2.4 releases that 
> already had the same problem in several places.
> 
> I see you have applied both my patch documenting modutils 2.4.10 was 
> required and the EXPORT_SYMBOL_GPL -> EXPORT_SYMBOL patch for tty_io.c .
> 
> I don't like this mixed approach. IMHO, there are two clean solutions:
> 1. document modutils 2.4.10 was required, undo the EXPORT_SYMBOL_GPL -> 
>    EXPORT_SYMBOL changes in tty_io.c
> 2. undo the EXPORT_SYMBOL_GPL -> EXPORT_SYMBOL changes in tty_io.c and
>    change module.h to #define EXPORT_SYMBOL_GPL to EXPORT_SYMBOL
> 
> Both approaches have their obvious advantages and disadvantages, but 
> they don't have the flaw that they special case tty_io.c .

Adrian,

I know of the other GPL exports but no one complained about problems with them. :)

Yes, you are right, to be orthogonal and clean it would be necessary to do 
require modutils-2.4.10 and have EXPORT_SYMBOL_GPL.

I just dont want to break existing user setups - due to the security problems
many might upgrade.

I'm just trying to be user-friendly. 



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15 11:43     ` Marcelo Tosatti
@ 2005-01-15 20:50       ` Adrian Bunk
  2005-01-15 18:31         ` Marcelo Tosatti
  2005-01-15 20:57         ` Jan Knutar
  0 siblings, 2 replies; 16+ messages in thread
From: Adrian Bunk @ 2005-01-15 20:50 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: linux-kernel

On Sat, Jan 15, 2005 at 09:43:09AM -0200, Marcelo Tosatti wrote:
> 
> Hi Adrian!
> 
> On Sat, Jan 15, 2005 at 06:20:50AM +0100, Adrian Bunk wrote:
> > On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
> > 
> > >...
> > >  - fsa01 (problem occurs):
> > >...
> > >  | modutils               2.4.5
> > >...
> > >  - gateway (no problem):
> > >...
> > >  | modutils               2.4.12
> > >....
> > 
> > OK, this seems to be the problem:
> > modutils before 2.4.10 don't know about EXPORT_SYMBOL_GPL.
> > 
> > Please upgrade modutils on fsa01 and report whether it fixes the 
> > problem.
> 
> Yes, thats the right solution - however I think it might be worth to have 
> the non-GPL versions. Several old distros ship modutils older than 2.4.10
> - eg SuSE Linux 7.1 (Oct 2001).
>...

Do a grep for EXPORT_SYMBOL_GPL in the 2.4.29-rc2 sources.

It seems for some reason people didn't scream in older 2.4 releases that 
already had the same problem in several places.

I see you have applied both my patch documenting modutils 2.4.10 was 
required and the EXPORT_SYMBOL_GPL -> EXPORT_SYMBOL patch for tty_io.c .

I don't like this mixed approach. IMHO, there are two clean solutions:
1. document modutils 2.4.10 was required, undo the EXPORT_SYMBOL_GPL -> 
   EXPORT_SYMBOL changes in tty_io.c
2. undo the EXPORT_SYMBOL_GPL -> EXPORT_SYMBOL changes in tty_io.c and
   change module.h to #define EXPORT_SYMBOL_GPL to EXPORT_SYMBOL

Both approaches have their obvious advantages and disadvantages, but 
they don't have the flaw that they special case tty_io.c .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: Linux 2.4.29-rc2
  2005-01-15 20:50       ` Adrian Bunk
  2005-01-15 18:31         ` Marcelo Tosatti
@ 2005-01-15 20:57         ` Jan Knutar
  1 sibling, 0 replies; 16+ messages in thread
From: Jan Knutar @ 2005-01-15 20:57 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Marcelo Tosatti, linux-kernel

On Saturday 15 January 2005 22:50, Adrian Bunk wrote:

> Do a grep for EXPORT_SYMBOL_GPL in the 2.4.29-rc2 sources.

I noticed this as well...

> It seems for some reason people didn't scream in older 2.4 releases that 
> already had the same problem in several places.

I always ASSUMED it was something wrong with my userspace because
I was only seeing this problem on one of the boxen running 2.4 that I have, I
upgraded modutils but the problem didn't vanish. Since none of the modules
which failed depmod -a were important for me I guessed there was some
other part of the ancient Rh6.1 install that was too old...
Unfortunately, I only use that machine every few months and can't test
anything :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2005-01-15 21:31 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-12 15:13 Linux 2.4.29-rc2 Marcelo Tosatti
2005-01-14 22:55 ` Steffen Moser
2005-01-14 23:17   ` Marcelo Tosatti
2005-01-15  2:58     ` David Dyck
2005-01-15  3:04       ` David Dyck
2005-01-15  5:23       ` Adrian Bunk
2005-01-15  6:39         ` David Dyck
2005-01-15  5:14     ` Adrian Bunk
2005-01-15  5:16       ` Adrian Bunk
2005-01-15  7:43     ` Arjan van de Ven
2005-01-15 10:07     ` Steffen Moser
2005-01-15  5:20   ` Adrian Bunk
2005-01-15 11:43     ` Marcelo Tosatti
2005-01-15 20:50       ` Adrian Bunk
2005-01-15 18:31         ` Marcelo Tosatti
2005-01-15 20:57         ` Jan Knutar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).