linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][2.6] Add release() function for virtual_eisa_root
@ 2003-08-10 21:03 Zwane Mwaikambo
  0 siblings, 0 replies; only message in thread
From: Zwane Mwaikambo @ 2003-08-10 21:03 UTC (permalink / raw)
  To: Linux Kernel; +Cc: Patrick Mochel

This gets rid of the following warning. Will the warning get removed later 
on or should we fix these?

EISA: Probing bus 0 at 
EISA: Mainboard INT3190 detected.
EISA: Detected 0 cards.
Device 'eisa0' does not have a release() function, it is broken and must 
be fixed.
Badness in device_release at drivers/base/core.c:84
Call Trace:
 [<c02d4054>] kobject_cleanup+0x64/0x70
 [<c044d5e1>] virtual_eisa_root_init+0x41/0x50
 [<c06d085b>] do_initcalls+0x2b/0xa0
 [<c01070f6>] init+0x56/0x210
 [<c01070a0>] init+0x0/0x210
 [<c0109125>] kernel_thread_helper+0x5/0x10

Index: linux-2.6.0-test2-mm2/drivers/eisa/virtual_root.c
===================================================================
RCS file: /build/cvsroot/linux-2.6.0-test2/drivers/eisa/virtual_root.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 virtual_root.c
--- linux-2.6.0-test2-mm2/drivers/eisa/virtual_root.c	30 Jul 2003 00:06:12 -0000	1.1.1.1
+++ linux-2.6.0-test2-mm2/drivers/eisa/virtual_root.c	3 Aug 2003 07:39:47 -0000
@@ -22,6 +22,7 @@
 #endif
 
 static int force_probe = EISA_FORCE_PROBE_DEFAULT;
+static void virtual_eisa_release(struct device *);
 
 /* The default EISA device parent (virtual root device).
  * Now use a platform device, since that's the obvious choice. */
@@ -31,6 +32,7 @@ static struct platform_device eisa_root_
 	.id   = 0,
 	.dev  = {
 		.name = "Virtual EISA Bridge",
+		.release = virtual_eisa_release,
 	},
 };
 
@@ -41,6 +43,12 @@ static struct eisa_root_device eisa_bus_
 	.slots	       = EISA_MAX_SLOTS,
 	.dma_mask      = 0xffffffff,
 };
+
+static void virtual_eisa_release (struct device *dev)
+{
+	/* nothing really to do here */
+	return;
+}
 
 static int virtual_eisa_root_init (void)
 {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-08-10 21:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-10 21:03 [PATCH][2.6] Add release() function for virtual_eisa_root Zwane Mwaikambo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).