From: Christoph Lameter <clameter@sgi.com>
To: Martin Hicks <mort@wildopensource.com>
Cc: Marco Cipullo <cipullo@libero.it>, linux-kernel@vger.kernel.org
Subject: Re: From last __GFP_ZERO changes
Date: Fri, 7 Jan 2005 12:02:13 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0501071200280.28689@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20050107193354.GT18461@localhost>
On Fri, 7 Jan 2005, Martin Hicks wrote:
>
> On Thu, Jan 06, 2005 at 12:43:58PM +0100, Marco Cipullo wrote:
> > From last __GFP_ZERO changes:
> >
> > --- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> > +++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> > @@ -135,12 +135,10 @@
> > goto no_bio;
> >
> > for (i = 0; i < PAGES_PER_PACKET; i++) {
> > - pkt->pages[i] = alloc_page(GFP_KERNEL);
> > + pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO);
> >
> > Is this OK?
> >
> > Or should be
> >
> > for (i = 0; i < PAGES_PER_PACKET; i++) {
> > - pkt->pages[i] = alloc_page(GFP_KERNEL);
> > + pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO);
>
> It definitely should be the latter.
Correct. Please submit the patch. I see a patch that fixes a pktcdvd.c
issue in Andrews tree so it was likely already fixed without me hearing of
it.
prev parent reply other threads:[~2005-01-07 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 11:43 From last __GFP_ZERO changes Marco Cipullo
2005-01-07 19:33 ` Martin Hicks
2005-01-07 20:02 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0501071200280.28689@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=cipullo@libero.it \
--cc=linux-kernel@vger.kernel.org \
--cc=mort@wildopensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).