* From last __GFP_ZERO changes
@ 2005-01-06 11:43 Marco Cipullo
2005-01-07 19:33 ` Martin Hicks
0 siblings, 1 reply; 3+ messages in thread
From: Marco Cipullo @ 2005-01-06 11:43 UTC (permalink / raw)
To: linux-kernel
>From last __GFP_ZERO changes:
--- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
+++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
@@ -135,12 +135,10 @@
goto no_bio;
for (i = 0; i < PAGES_PER_PACKET; i++) {
- pkt->pages[i] = alloc_page(GFP_KERNEL);
+ pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO);
Is this OK?
Or should be
for (i = 0; i < PAGES_PER_PACKET; i++) {
- pkt->pages[i] = alloc_page(GFP_KERNEL);
+ pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO);
Bye
Marco
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: From last __GFP_ZERO changes
2005-01-06 11:43 From last __GFP_ZERO changes Marco Cipullo
@ 2005-01-07 19:33 ` Martin Hicks
2005-01-07 20:02 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Martin Hicks @ 2005-01-07 19:33 UTC (permalink / raw)
To: Marco Cipullo, clameter; +Cc: linux-kernel
On Thu, Jan 06, 2005 at 12:43:58PM +0100, Marco Cipullo wrote:
> From last __GFP_ZERO changes:
>
> --- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> +++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> @@ -135,12 +135,10 @@
> goto no_bio;
>
> for (i = 0; i < PAGES_PER_PACKET; i++) {
> - pkt->pages[i] = alloc_page(GFP_KERNEL);
> + pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO);
>
> Is this OK?
>
> Or should be
>
> for (i = 0; i < PAGES_PER_PACKET; i++) {
> - pkt->pages[i] = alloc_page(GFP_KERNEL);
> + pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO);
It definitely should be the latter.
CCing Christoph so he can fix this up.
mh
--
Martin Hicks Wild Open Source Inc.
mort@wildopensource.com 613-266-2296
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: From last __GFP_ZERO changes
2005-01-07 19:33 ` Martin Hicks
@ 2005-01-07 20:02 ` Christoph Lameter
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2005-01-07 20:02 UTC (permalink / raw)
To: Martin Hicks; +Cc: Marco Cipullo, linux-kernel
On Fri, 7 Jan 2005, Martin Hicks wrote:
>
> On Thu, Jan 06, 2005 at 12:43:58PM +0100, Marco Cipullo wrote:
> > From last __GFP_ZERO changes:
> >
> > --- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> > +++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> > @@ -135,12 +135,10 @@
> > goto no_bio;
> >
> > for (i = 0; i < PAGES_PER_PACKET; i++) {
> > - pkt->pages[i] = alloc_page(GFP_KERNEL);
> > + pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO);
> >
> > Is this OK?
> >
> > Or should be
> >
> > for (i = 0; i < PAGES_PER_PACKET; i++) {
> > - pkt->pages[i] = alloc_page(GFP_KERNEL);
> > + pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO);
>
> It definitely should be the latter.
Correct. Please submit the patch. I see a patch that fixes a pktcdvd.c
issue in Andrews tree so it was likely already fixed without me hearing of
it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-07 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-06 11:43 From last __GFP_ZERO changes Marco Cipullo
2005-01-07 19:33 ` Martin Hicks
2005-01-07 20:02 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).