linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] handle IRQ_PENDING for simple irq handler
@ 2007-12-12 19:50 Steven Rostedt
  2007-12-12 20:12 ` Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2007-12-12 19:50 UTC (permalink / raw)
  To: LKML, linux-rt-users; +Cc: Ingo Molnar, Thomas Gleixner


With the IO-APIC pcix hack (level=>edge masking), we can receive
interrupts while masked. But these interrupts might be missed.

Also, normal "simple" interrupts might be missed too on leaving of
thread handler.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>

Index: linux-2.6.21-rt-hack/kernel/irq/manage.c
===================================================================
--- linux-2.6.21-rt-hack.orig/kernel/irq/manage.c
+++ linux-2.6.21-rt-hack/kernel/irq/manage.c
@@ -628,14 +628,17 @@ static void thread_simple_irq(irq_desc_t
 	unsigned int irq = desc - irq_desc;
 	irqreturn_t action_ret;

-	if (action && !desc->depth) {
+	do {
+		if (!action || desc->depth)
+			break;
+		desc->status &= ~IRQ_PENDING;
 		spin_unlock(&desc->lock);
 		action_ret = handle_IRQ_event(irq, action);
 		cond_resched_hardirq_context();
 		spin_lock_irq(&desc->lock);
 		if (!noirqdebug)
 			note_interrupt(irq, desc, action_ret);
-	}
+	} while (desc->status & IRQ_PENDING);
 	desc->status &= ~IRQ_INPROGRESS;
 }




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] handle IRQ_PENDING for simple irq handler
  2007-12-12 19:50 [PATCH] handle IRQ_PENDING for simple irq handler Steven Rostedt
@ 2007-12-12 20:12 ` Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2007-12-12 20:12 UTC (permalink / raw)
  To: LKML, linux-rt-users; +Cc: Ingo Molnar, Thomas Gleixner

Note, that should have been [PATCH RT], this is NOT for mainline!

-- Steve


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-12-12 20:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-12 19:50 [PATCH] handle IRQ_PENDING for simple irq handler Steven Rostedt
2007-12-12 20:12 ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).