linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Line up CPU caps messages once more
@ 2005-01-17  0:40 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2005-01-17  0:40 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: H. Peter Anvin, Dave Jones


A while back I submitted a patch that made the "CPU: After * identify, 
caps:" messages produced by printk's in arch/i386/kernel/cpu/common.c line 
up nicely (http://www.ussg.iu.edu/hypermail/linux/kernel/0406.3/0222.html).
The patch was accepted back then, but recently a new patch  
http://linux.bkbits.net:8080/linux-2.6/diffs/arch/i386/kernel/cpu/common.c@1.35?nav=index.html|src/|src/arch|src/arch/i386|src/arch/i386/kernel|src/arch/i386/kernel/cpu|hist/arch/i386/kernel/cpu/common.c 
 broke that nice lineup of the messages again, so here's a patch to 
restore the visually pleasing printing of those messages (it also adds 
two comments this time to indicate that the extra spaces are there for a 
reason).
Hopefully this will make it back in, it looks so much nicer when stuff 
lines up like this:
CPU: After generic identify, caps: 0183f9ff c1c7f9ff 00000000 00000000 00000000 00000000 00000000
CPU: After vendor identify, caps:  0183f9ff c1c7f9ff 00000000 00000000 00000000 00000000 00000000
CPU: After all inits, caps:        0183f9ff c1c7f9ff 00000000 00000020 00000000 00000000 00000000


Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>

diff -up linux-2.6.11-rc1-bk4-orig/arch/i386/kernel/cpu/common.c linux-2.6.11-rc1-bk4/arch/i386/kernel/cpu/common.c
--- linux-2.6.11-rc1-bk4-orig/arch/i386/kernel/cpu/common.c	2005-01-12 23:26:01.000000000 +0100
+++ linux-2.6.11-rc1-bk4/arch/i386/kernel/cpu/common.c	2005-01-17 01:16:29.000000000 +0100
@@ -350,7 +350,8 @@ void __init identify_cpu(struct cpuinfo_
 	if (this_cpu->c_identify) {
 		this_cpu->c_identify(c);
 
-		printk(KERN_DEBUG "CPU: After vendor identify, caps:");
+		/* extra spacing at the end on purpose to line up message with above printk */
+		printk(KERN_DEBUG "CPU: After vendor identify, caps: ");
 		for (i = 0; i < NCAPINTS; i++)
 			printk(" %08lx", c->x86_capability[i]);
 		printk("\n");
@@ -404,7 +405,8 @@ void __init identify_cpu(struct cpuinfo_
 
 	/* Now the feature flags better reflect actual CPU features! */
 
-	printk(KERN_DEBUG "CPU: After all inits, caps:");
+	/* extra spacing at the end on purpose to line up message with above printk */
+	printk(KERN_DEBUG "CPU: After all inits, caps:       ");
 	for (i = 0; i < NCAPINTS; i++)
 		printk(" %08lx", c->x86_capability[i]);
 	printk("\n");




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-01-17  0:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-17  0:40 [PATCH] Line up CPU caps messages once more Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).