linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netdrv gianfar: Fix usage of gfar_read in debug code
@ 2005-01-26  0:17 Kumar Gala
  2005-01-27 22:08 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2005-01-26  0:17 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, linuxppc-embedded, afleming

Fixes instances where gfar_read() was invoked in debug codewith a value, 
rather than a pointer.

Signed-of-by: Andy Fleming <afleming@freescale.com>
Signed-of-by: Kumar Gala <afleming@freescale.com>

---

diff -Nru a/drivers/net/gianfar.c b/drivers/net/gianfar.c
--- a/drivers/net/gianfar.c	2005-01-25 18:14:13 -06:00
+++ b/drivers/net/gianfar.c	2005-01-25 18:14:13 -06:00
@@ -1190,8 +1190,8 @@
 	} else {
 #ifdef VERBOSE_GFAR_ERRORS
 		printk(KERN_DEBUG "%s: receive called twice (%x)[%x]\n",
-		       dev->name, gfar_read(priv->regs->ievent),
-		       gfar_read(priv->regs->imask));
+		       dev->name, gfar_read(&priv->regs->ievent),
+		       gfar_read(&priv->regs->imask));
 #endif
 	}
 #else
@@ -1415,7 +1415,7 @@
 
 #ifdef VERBOSE_GFAR_ERRORS
 		printk(KERN_DEBUG "%s: busy error (rhalt: %x)\n", dev->name,
-		       gfar_read(priv->regs->rstat));
+		       gfar_read(&priv->regs->rstat));
 #endif
 	}
 	if (events & IEVENT_BABR) {
@@ -1793,7 +1793,7 @@
 
 #ifdef VERBOSE_GFAR_ERRORS
 		printk(KERN_DEBUG "%s: busy error (rhalt: %x)\n", dev->name,
-		       gfar_read(priv->regs->rstat));
+		       gfar_read(&priv->regs->rstat));
 #endif
 	}
 	if (events & IEVENT_BABR) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] netdrv gianfar: Fix usage of gfar_read in debug code
  2005-01-26  0:17 [PATCH] netdrv gianfar: Fix usage of gfar_read in debug code Kumar Gala
@ 2005-01-27 22:08 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-01-27 22:08 UTC (permalink / raw)
  To: Kumar Gala; +Cc: akpm, linux-kernel, linuxppc-embedded, afleming

applied


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-01-27 22:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-26  0:17 [PATCH] netdrv gianfar: Fix usage of gfar_read in debug code Kumar Gala
2005-01-27 22:08 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).