* [2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd)
@ 2006-02-25 16:01 Adrian Bunk
2006-02-25 22:05 ` Jan Engelhardt
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-02-25 16:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: Adam Kropelin, Paul.Clements, linux-kernel
If we can detect a problem at compile time, the compilation should fail.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 20 Feb 2006
- 3 Sep 2005
--- linux-2.6.13-mm1-full/drivers/block/nbd.c.old 2005-09-02 23:48:27.000000000 +0200
+++ linux-2.6.13-mm1-full/drivers/block/nbd.c 2005-09-03 01:08:04.000000000 +0200
@@ -643,10 +643,7 @@
int err = -ENOMEM;
int i;
- if (sizeof(struct nbd_request) != 28) {
- printk(KERN_CRIT "nbd: sizeof nbd_request needs to be 28 in order to work!\n" );
- return -EIO;
- }
+ BUILD_BUG_ON(sizeof(struct nbd_request) != 28);
if (nbds_max > MAX_NBD) {
printk(KERN_CRIT "nbd: cannot allocate more than %u nbds; %u requested.\n", MAX_NBD,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd)
2006-02-25 16:01 [2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd) Adrian Bunk
@ 2006-02-25 22:05 ` Jan Engelhardt
0 siblings, 0 replies; 2+ messages in thread
From: Jan Engelhardt @ 2006-02-25 22:05 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, Adam Kropelin, Paul.Clements, linux-kernel
>
>If we can detect a problem at compile time, the compilation should fail.
>
Hi,
do the same with fs/minix/*, it also checks sizeof() to 32/64 at runtime.
Jan Engelhardt
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-25 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-25 16:01 [2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd) Adrian Bunk
2006-02-25 22:05 ` Jan Engelhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).