* [2.6 patch] drivers/char/moxa.c: remove an unused function
@ 2004-12-05 17:02 Adrian Bunk
2004-12-05 20:14 ` Tomasz Kłoczko
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2004-12-05 17:02 UTC (permalink / raw)
To: linux-kernel
The patch below removes an unused global function.
diffstat output:
drivers/char/moxa.c | 18 ------------------
1 files changed, 18 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm3-full/drivers/char/moxa.c.old 2004-11-07 00:28:05.000000000 +0100
+++ linux-2.6.10-rc1-mm3-full/drivers/char/moxa.c 2004-11-07 00:28:41.000000000 +0100
@@ -1765,7 +1765,6 @@
* 2. MoxaPortEnable(int port); *
* 3. MoxaPortDisable(int port); *
* 4. MoxaPortGetMaxBaud(int port); *
- * 5. MoxaPortGetCurBaud(int port); *
* 6. MoxaPortSetBaud(int port, long baud); *
* 7. MoxaPortSetMode(int port, int databit, int stopbit, int parity); *
* 8. MoxaPortSetTermio(int port, unsigned char *termio); *
@@ -1876,15 +1875,6 @@
* 38400/57600/115200 bps
*
*
- * Function 9: Get the current baud rate of this port.
- * Syntax:
- * long MoxaPortGetCurBaud(int port);
- * int port : port number (0 - 127)
- *
- * return: 0 : this port is invalid
- * 50 - 115200 bps
- *
- *
* Function 10: Setting baud rate of this port.
* Syntax:
* long MoxaPortSetBaud(int port, long baud);
@@ -3093,14 +3083,6 @@
return (0);
}
-long MoxaPortGetCurBaud(int port)
-{
-
- if (moxaChkPort[port] == 0)
- return (0);
- return (moxaCurBaud[port]);
-}
-
static void MoxaSetFifo(int port, int enable)
{
void __iomem *ofsAddr = moxaTableAddr[port];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/char/moxa.c: remove an unused function
2004-12-05 17:02 [2.6 patch] drivers/char/moxa.c: remove an unused function Adrian Bunk
@ 2004-12-05 20:14 ` Tomasz Kłoczko
2004-12-06 0:41 ` [2.6 patch] drivers/char/moxa.c: #if 0 " Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Kłoczko @ 2004-12-05 20:14 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1225 bytes --]
On Sun, 5 Dec 2004, Adrian Bunk wrote:
> The patch below removes an unused global function.
>
>
> diffstat output:
> drivers/char/moxa.c | 18 ------------------
> 1 files changed, 18 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.10-rc1-mm3-full/drivers/char/moxa.c.old 2004-11-07 00:28:05.000000000 +0100
> +++ linux-2.6.10-rc1-mm3-full/drivers/char/moxa.c 2004-11-07 00:28:41.000000000 +0100
> @@ -1765,7 +1765,6 @@
> * 2. MoxaPortEnable(int port); *
> * 3. MoxaPortDisable(int port); *
> * 4. MoxaPortGetMaxBaud(int port); *
>- * 5. MoxaPortGetCurBaud(int port); *
> * 6. MoxaPortSetBaud(int port, long baud); *
> * 7. MoxaPortSetMode(int port, int databit, int stopbit, int parity); *
> * 8. MoxaPortSetTermio(int port, unsigned char *termio); *
[..]
Prabaly it will be good renumber this or make unnumbered (and all other
comments with "Function <num>:" :)
[..]
--
-----------------------------------------------------------
*Ludzie nie mają problemów, tylko sobie sami je stwarzają*
-----------------------------------------------------------
Tomasz Kłoczko, sys adm @zie.pg.gda.pl|*e-mail: kloczek@rudy.mif.pg.gda.pl*
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/char/moxa.c: #if 0 an unused function
2004-12-05 20:14 ` Tomasz Kłoczko
@ 2004-12-06 0:41 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2004-12-06 0:41 UTC (permalink / raw)
To: Tomasz K?oczko; +Cc: linux-kernel
On Sun, Dec 05, 2004 at 09:14:08PM +0100, Tomasz K?oczko wrote:
>...
> >- * 5. MoxaPortGetCurBaud(int port);
> >*
> > * 6. MoxaPortSetBaud(int port, long baud);
> > *
> > * 7. MoxaPortSetMode(int port, int databit, int stopbit, int parity);
> > *
> > * 8. MoxaPortSetTermio(int port, unsigned char *termio);
> > *
> [..]
>
> Prabaly it will be good renumber this or make unnumbered (and all other
> comments with "Function <num>:" :)
Perhaps the following patch is the best solution:
diffstat output:
drivers/char/moxa.c | 2 ++
1 files changed, 2 insertions(+)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c.old 2004-12-06 01:30:18.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c 2004-12-06 01:30:39.000000000 +0100
@@ -3090,6 +3090,7 @@
return (0);
}
+#if 0
long MoxaPortGetCurBaud(int port)
{
@@ -3097,6 +3098,7 @@
return (0);
return (moxaCurBaud[port]);
}
+#endif /* 0 */
static void MoxaSetFifo(int port, int enable)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-12-06 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-05 17:02 [2.6 patch] drivers/char/moxa.c: remove an unused function Adrian Bunk
2004-12-05 20:14 ` Tomasz Kłoczko
2004-12-06 0:41 ` [2.6 patch] drivers/char/moxa.c: #if 0 " Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).